From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B7B74568F; Tue, 23 Jul 2024 10:31:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E158940F1A; Tue, 23 Jul 2024 10:31:10 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2049.outbound.protection.outlook.com [40.107.243.49]) by mails.dpdk.org (Postfix) with ESMTP id 55B1B40A77 for ; Tue, 23 Jul 2024 10:16:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UKFen18xA2x7z87/IHeyl48PaH9UtvYoLcrlhScdL02E/VjjyXCRpbbObWXmpdnm6jmiiTes8qzgqdlW5uazt3KK3xUggmxn39q14J89pVLf5Qos7kvHapDJzwT5eWwxM+FiYyX7LhJcHx0T0+PitfTKGaonqyihlnDxuhfQmMBcUUygka36Nx1dtcUnlodG7cqrW1dcJfG33RJpFQvtVD0XnFqWTEoJ/jd+b0NjVdOEKWBT1tWm1949FRgo6JycVqTVgDEuC37FSX4KAb9hjdR3qkIjldFGcdhJa4LFc7xzBKN4UKRv3iSWC5pFl/sfTFcTAt+myz0boRu+bT11yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GYStICWGAf/D8jZJUq7o+gtUBR7fWrg6MyLovakcghQ=; b=R87F/V9m5/ioxs3ZtKbO7eqhZgw2MEtBtSfK/ouF0rGBWtST9fXLpO2BIhiHB8gpMu+XEL49JuyjMtX9AvfqNLjBmVVaXjaggqEKvddAjIcIVrYpG7QacZaFrf5kbDynq81MoKePya89GJjFv910ZMcU7CDFcE2FX9h+Cqpyt0eIMdrUMHh4q3V47nTNbF6E+kUqG/NLPPXDVZFTAWDMnIFRSJ0uh8td95n7gToA0EMrtPUlKATEDWm/Aj1Dr3uxrJnEIjTEnwjox+GJ8jPo337flNihfyRIVXd+Tz4ItQdN35WKXoYEmPATrKlfvWDSlVdHZSCSOLBGtNrG8vFYpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GYStICWGAf/D8jZJUq7o+gtUBR7fWrg6MyLovakcghQ=; b=RJJySTcaHKLKIV7+emJaNzPzLyGhGPvhvbW3tPeNQXkRgSd2s0qWe0yVRZubdFACsBZbrsLEMffHTb2hubOzSBK2WkYFgtX9zQ/sV0/ybbWNDtjzWe7ZkjgX/os9HgQY1GYjJnWbMMpudxYFZ0AjcbpKm0yMtHhJd79IR5MCYNCEBS93H94E//GeUYhc58yCHGpNXwud9lET+yA0yWD4ueRhI1fal80+jdjIsKF3OJij5z8Zc2lwneREEUHVb2MHcOxXN6oEBmui1K6u79HabyvXLBF6F9eaJN/Rbo5KA2XYJsD0vUHvKxm8nPaU3PBNYifGi1upI4Ldi6cJtS9Lpw== Received: from DS7PR03CA0337.namprd03.prod.outlook.com (2603:10b6:8:55::25) by MW5PR12MB5599.namprd12.prod.outlook.com (2603:10b6:303:194::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.19; Tue, 23 Jul 2024 08:16:16 +0000 Received: from DS2PEPF0000343E.namprd02.prod.outlook.com (2603:10b6:8:55:cafe::5a) by DS7PR03CA0337.outlook.office365.com (2603:10b6:8:55::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.20 via Frontend Transport; Tue, 23 Jul 2024 08:16:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS2PEPF0000343E.mail.protection.outlook.com (10.167.18.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.11 via Frontend Transport; Tue, 23 Jul 2024 08:16:16 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 23 Jul 2024 01:16:02 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 23 Jul 2024 01:15:59 -0700 From: Bing Zhao To: , , , CC: , , , "Maayan Kashani" Subject: [PATCH 4/4] net/mlx5: fix log error on non-template rule destroy Date: Tue, 23 Jul 2024 11:15:22 +0300 Message-ID: <20240723081522.1087433-5-bingz@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240723081522.1087433-1-bingz@nvidia.com> References: <20240723081522.1087433-1-bingz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF0000343E:EE_|MW5PR12MB5599:EE_ X-MS-Office365-Filtering-Correlation-Id: 3b1c9730-3b88-435e-bb48-08dcaaefb948 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DCWZoQi0ogdsUbfLQ2+pXJ2HtnS7vQswZszhlmaFCuxbaTbDQlG31UeiDmqb?= =?us-ascii?Q?cQp5CMmur8KRs6FvkAXZmf5jLOyW0yMiWgz9DcN44poZK7HmcgfSKyuyIdYT?= =?us-ascii?Q?YKa4pmDKD4Zp9KRz/+ta6M1r4tGL5G86Zkdf32AsTE4c/PsZwJUUr6r5pCS6?= =?us-ascii?Q?hYo4hmrVEKTIsJByC/2J3dk/zNmH+PNKw3lFbilyGCO70nhV5keyTJhCol0q?= =?us-ascii?Q?jWCa7JPVyv4lmbjRjgnOeapsqfV98AnR8u6JjaRg9KZRZaLAk/GuUXZsK+2U?= =?us-ascii?Q?xdnKqNIJSGteKgc6ae+a2byORVLG//VfHTLFSQIqzqTC+ZPrnfDVCSgEkdp5?= =?us-ascii?Q?I1KyCxl/7LN2ZGXE3Iw9Xe0mXUk+gtDH27KNJzC6/CVHIdF2kFRXyXVu0yAQ?= =?us-ascii?Q?qUHE6Qtief5gRpjDiqOfQwJiWX0R7Nd/wFoMlBccP3/Ltk0LaE5FPkKVfAPz?= =?us-ascii?Q?oOqxeaLS6ehHU5wQ7PQLxvLqHN9wL7AKxnrv+AyzH6XZeyRifJTxz5mA/gVD?= =?us-ascii?Q?9MjJ1p7+ir85Gri/2/h2idqr8hZkCqF0eONO7b9tagK1xaX/7arwuoqcQhM1?= =?us-ascii?Q?6GupjWlA9u8aqyifU+yLtwv27PDnVh96pJrpRHvx/rXoMI6pMejOIZgqOtOU?= =?us-ascii?Q?k8v8xRKRpmKwGOpdyefbYBvKQBMAI5a09mRLs221QhATtLBJk0H11dbNbbrX?= =?us-ascii?Q?Dw5q4pLtOJt853MXtpq+0HsOlZ2ZzAr+tIvTD9P2jNOz9xSqIAzfkpqXJwL2?= =?us-ascii?Q?JCgaAUtYYSJ2dtATh2JRoqlR2H20GhTNC9xj9JDQjMf4XzNXN47OxtRGWbDh?= =?us-ascii?Q?270TWBFqUjJQnuyxwoZCKZQZa5dh9rboWUOWRo6CWi53nOXw+A0wn79rmZYI?= =?us-ascii?Q?+qdRPFeNViYm8x7+m7YwhVYhsJuWmBkggUuVV7kSPY1trMqvRiRSXAaDGQOR?= =?us-ascii?Q?I/9An7FD7ayqqgFO/C9i7h8H4+c4Gi32eVZwY2oeDjI2UxC5gjcYlxqyGJl5?= =?us-ascii?Q?lkH2tLTBWaGNjoh4s1e1BpAv5RMif/U98nC03daA5BUcDWgHM2eY+L4o7Bpp?= =?us-ascii?Q?xhJLyJK2c+O6RpyLNjKtW5G1dWtNA+RoAKehkc5gdPgtdhyWHDTWHX4roocj?= =?us-ascii?Q?ragPy7uppYbBAMrhJKCvUgACrePUr3bSRGFL6ZEdCrpvfJDSTXeywe2HXezg?= =?us-ascii?Q?dNzY6AnsHFBjPf1VERYA2arzRSu55md6xKrMMqXK9Xb42XzESVnQAogLDZLL?= =?us-ascii?Q?h9jBJcy8xfONk/TlOeWEUNntg5qJY/dsZGXSzLUxiuPBUtCiQ3N/evSL/KBn?= =?us-ascii?Q?Qp/EF3znFWCCf7iosA/4sOUHXhXNMaFtCp0Q9A15n5UtqbBVuvqV6G9vwBtj?= =?us-ascii?Q?F8KLgD7EN3vabX+bZBZHKtE1ewjB6edFTKb6hIq3dtW2kwhdsSa5bmdWVQzZ?= =?us-ascii?Q?SKPIatA/uRIgMPh2MrKbFqUX77D47Q2s?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2024 08:16:16.0193 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3b1c9730-3b88-435e-bb48-08dcaaefb948 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF0000343E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5599 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Log error message is raised on port stop when using same encap action with two different rules. It is a false alarm, checking return value not equals zero from hlist unregister function was wrong since it returns 1 if the object is still referenced. Remove the check for return value for encap, decap, modify header and matcher resource release under flow destroy cause all uses list/hlist with return value 0/1. Fixes: ff4064d5b1fe ("net/mlx5: support bulk actions in non-template flow") Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 46f6665846..8a59d3c013 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -13792,17 +13792,12 @@ flow_hw_destroy(struct rte_eth_dev *dev, struct rte_flow_hw *flow) if (flow->nt2hws->flow_aux) mlx5_free(flow->nt2hws->flow_aux); - if (flow->nt2hws->rix_encap_decap) { - ret = flow_encap_decap_resource_release(dev, flow->nt2hws->rix_encap_decap); - if (ret) - DRV_LOG(ERR, "failed to release encap decap."); - } + if (flow->nt2hws->rix_encap_decap) + flow_encap_decap_resource_release(dev, flow->nt2hws->rix_encap_decap); if (flow->nt2hws->modify_hdr) { MLX5_ASSERT(flow->nt2hws->modify_hdr->action); - ret = mlx5_hlist_unregister(priv->sh->modify_cmds, - &flow->nt2hws->modify_hdr->entry); - if (ret) - DRV_LOG(ERR, "failed to release modify action."); + mlx5_hlist_unregister(priv->sh->modify_cmds, + &flow->nt2hws->modify_hdr->entry); } if (flow->nt2hws->matcher) flow_hw_unregister_matcher(dev, flow->nt2hws->matcher); -- 2.34.1