* [PATCH] eventdev: do not use zero length arrays
@ 2024-07-25 17:15 Stephen Hemminger
2024-09-17 15:28 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2024-07-25 17:15 UTC (permalink / raw)
To: dev
Cc: Stephen Hemminger, Liang Ma, Peter Mccarthy, Harry van Haaren,
Amit Prakash Shukla, Jerin Jacob
Zero length array's are a GNU C extension and should be replaced
by use of flexible arrayrs. This has been fixed almost everywhere
in DPDK 24.07 but looks like some event code got missed.
Generated by devtools/cocci/zero_length_array.cocci
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/event/opdl/opdl_ring.c | 2 +-
drivers/event/sw/event_ring.h | 2 +-
lib/eventdev/rte_event_dma_adapter.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/event/opdl/opdl_ring.c b/drivers/event/opdl/opdl_ring.c
index 6799ec996b..60991c4b03 100644
--- a/drivers/event/opdl/opdl_ring.c
+++ b/drivers/event/opdl/opdl_ring.c
@@ -119,7 +119,7 @@ struct opdl_ring {
/* Stages indexed by ID */
struct opdl_stage *stages;
/* Memory for storing slot data */
- alignas(RTE_CACHE_LINE_SIZE) uint8_t slots[0];
+ alignas(RTE_CACHE_LINE_SIZE) uint8_t slots[];
};
diff --git a/drivers/event/sw/event_ring.h b/drivers/event/sw/event_ring.h
index 29db267b77..35931888dd 100644
--- a/drivers/event/sw/event_ring.h
+++ b/drivers/event/sw/event_ring.h
@@ -27,7 +27,7 @@ struct rob_ring {
uint32_t size;
uint32_t write_idx;
uint32_t read_idx;
- alignas(RTE_CACHE_LINE_SIZE) void *ring[0];
+ alignas(RTE_CACHE_LINE_SIZE) void *ring[];
};
static inline struct rob_ring *
diff --git a/lib/eventdev/rte_event_dma_adapter.h b/lib/eventdev/rte_event_dma_adapter.h
index 768390cd30..5c480b82ff 100644
--- a/lib/eventdev/rte_event_dma_adapter.h
+++ b/lib/eventdev/rte_event_dma_adapter.h
@@ -204,7 +204,7 @@ struct rte_event_dma_adapter_op {
/**< Number of source segments. */
uint16_t nb_dst;
/**< Number of destination segments. */
- struct rte_dma_sge src_dst_seg[0];
+ struct rte_dma_sge src_dst_seg[];
/**< Source and destination segments. */
};
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] eventdev: do not use zero length arrays
2024-07-25 17:15 [PATCH] eventdev: do not use zero length arrays Stephen Hemminger
@ 2024-09-17 15:28 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2024-09-17 15:28 UTC (permalink / raw)
To: Stephen Hemminger
Cc: dev, Liang Ma, Peter Mccarthy, Harry van Haaren,
Amit Prakash Shukla, Jerin Jacob
On Thu, Jul 25, 2024 at 11:24 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Zero length array's are a GNU C extension and should be replaced
> by use of flexible arrayrs. This has been fixed almost everywhere
> in DPDK 24.07 but looks like some event code got missed.
>
> Generated by devtools/cocci/zero_length_array.cocci
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied to dpdk-next-eventdev/for-main. Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-17 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-25 17:15 [PATCH] eventdev: do not use zero length arrays Stephen Hemminger
2024-09-17 15:28 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).