From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D32D1456B8; Fri, 26 Jul 2024 17:37:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9796E410ED; Fri, 26 Jul 2024 17:37:03 +0200 (CEST) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id B75C040E22 for ; Fri, 26 Jul 2024 17:37:01 +0200 (CEST) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7a130ae7126so818280a12.0 for ; Fri, 26 Jul 2024 08:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1722008221; x=1722613021; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fnN/tU2Vx8N2T+jDrVkHgmN6KZSVMzy2Z4ZEY/4t0x8=; b=NFjutNPQj1EN/AW1JH8j85k3/ddX3p56XXZ4Xcz/SaEnRfEuL8JfLQSpCaakWNNJnk GysRI3ypvF/MDGf2jJe9fU586C7d9PvL+puWYM1MpmKkLHwvrEos/4TSGGwgleXRVKzi QEOt4Ar5BUiuI+PNfrBYnmo+Wz47GO+2t0HxZoVTmcUCL6V9mYns/UeYk23tGag9NLBM KTHKV08s9nUUSWMMNlvicRkCI3oBsOgewJAiZGxNRlUYPLIR7TRD+W4dcSiPvymR1jc5 FW4+/KjH/s2+oa/KsHVoYG1iksZR7IMzmpa9+qyW2LzIWXR5Kd9Wqq46JXBrNluJrefv Hx9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722008221; x=1722613021; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fnN/tU2Vx8N2T+jDrVkHgmN6KZSVMzy2Z4ZEY/4t0x8=; b=SYTJyd1g1iBoeCIHMBULjZG8PckFwqRxK4cFg6nwD4k/Yr5/dWMY21I1mUn1kzgxkS 5rhCbYeoyMCkUM90K+Lwtyu+qYE1z8Bx0slF6mVA83ZzdFmcFro2VWpmPbqKxRRUbWJj LvQ18U+w+xNPhZ3biYBqHjE4igaCY7m/BFrNJLqBEV1Iqrbd+JBCJS79yT8gL+aUb9bg qxegWyLpPCrrDiDD7Nsc+RorLsGtouz7JkVaJaLkNMt5qTxElDIPRKhC3YDHEtfg7EKK TPQWwvcrarngli+OgMnBcrAsu8TTxAahYkodSf1G4dIYXRK6Y/vof0zGvBIbV/KdSkbl pXeA== X-Gm-Message-State: AOJu0Yw0E1VVrESZPGiglCbGgFnpBAxfUO9jnKqgmKoHCOcU/boq+oTN k9HuMrmvcQbFjpCW5xgVHsNTg6YJhVx0hfl4A70vvhIhPpXMtD0c1mvH4Q9qXSQpZbbg8Kk6+28 P X-Google-Smtp-Source: AGHT+IEGCS5UoftmAU32I2UGY/5n+1dr92tj5KYVM2HjMRE8AjOBiRxO12akX85I0U7Mbrb20TRhsA== X-Received: by 2002:a17:90a:6d27:b0:2c8:f3b7:ec45 with SMTP id 98e67ed59e1d1-2cf2ec03a86mr6306513a91.36.1722008220577; Fri, 26 Jul 2024 08:37:00 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cf28c7fe33sm3629211a91.13.2024.07.26.08.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 08:37:00 -0700 (PDT) Date: Fri, 26 Jul 2024 08:36:58 -0700 From: Stephen Hemminger To: Anatoly Burakov Cc: dev@dpdk.org, john.mcnamara@intel.com Subject: Re: [RFC PATCH v1 1/1] devtools: add vscode configuration generator Message-ID: <20240726083658.14abf478@hermes.local> In-Reply-To: <6a6b20c037cffcc5f68a341c4b4e4f21990ae991.1721997016.git.anatoly.burakov@intel.com> References: <6a6b20c037cffcc5f68a341c4b4e4f21990ae991.1721997016.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 26 Jul 2024 13:42:56 +0100 Anatoly Burakov wrote: > A lot of developers use Visual Studio Code as their primary IDE. This > script generates a configuration file for VSCode that sets up basic build > tasks, launch tasks, as well as C/C++ code analysis settings that will > take into account compile_commands.json that is automatically generated > by meson. > > Files generated by script: > - .vscode/settings.json: stores variables needed by other files > - .vscode/tasks.json: defines build tasks > - .vscode/launch.json: defines launch tasks > - .vscode/c_cpp_properties.json: defines code analysis settings > > The script uses a combination of globbing and meson file parsing to > discover available apps, examples, and drivers, and generates a > project-wide settings file, so that the user can later switch between > debug/release/etc. configurations while keeping their desired apps, > examples, and drivers, built by meson, and ensuring launch configurations > still work correctly whatever the configuration selected. > > This script uses whiptail as TUI, which is expected to be universally > available as it is shipped by default on most major distributions. > However, the script is also designed to be scriptable and can be run > without user interaction, and have its configuration supplied from > command-line arguments. > > Signed-off-by: Anatoly Burakov The TUI doesn't matter much since I would expect this gets run 100% on Windows. In general looks good, you might want to address $ flake8 ./devtools/gen-vscode-config.py --max-line 100 ./devtools/gen-vscode-config.py:352:47: E741 ambiguous variable name 'l' ./devtools/gen-vscode-config.py:499:16: E713 test for membership should be 'not in' ./devtools/gen-vscode-config.py:546:101: E501 line too long (120 > 100 characters)