DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH 1/1] ml/cnxk: enable data caching for all MRVL layers
@ 2024-07-31  6:06 Srikanth Yalavarthi
  2024-09-19 17:33 ` Jerin Jacob
  0 siblings, 1 reply; 2+ messages in thread
From: Srikanth Yalavarthi @ 2024-07-31  6:06 UTC (permalink / raw)
  To: Srikanth Yalavarthi; +Cc: dev, sshankarnara, aprabhu, ptakkar

From: Anup Prabhu <aprabhu@marvell.com>

Enabled data caching for all MRVL layers in TVM models

Signed-off-by: Anup Prabhu <aprabhu@marvell.com>
---
 drivers/ml/cnxk/cn10k_ml_ops.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c
index 834e55e88e9..f6b2baa0df0 100644
--- a/drivers/ml/cnxk/cn10k_ml_ops.c
+++ b/drivers/ml/cnxk/cn10k_ml_ops.c
@@ -996,13 +996,8 @@ cn10k_ml_layer_start(void *device, uint16_t model_id, const char *layer_name)
 	if (ret < 0) {
 		cn10k_ml_layer_stop(device, model_id, layer_name);
 	} else {
-		if (cn10k_mldev->cache_model_data) {
-			if ((model->type == ML_CNXK_MODEL_TYPE_GLOW &&
-			     model->subtype == ML_CNXK_MODEL_SUBTYPE_GLOW_MRVL) ||
-			    (model->type == ML_CNXK_MODEL_TYPE_TVM &&
-			     model->subtype == ML_CNXK_MODEL_SUBTYPE_TVM_MRVL))
-				ret = cn10k_ml_cache_model_data(cnxk_mldev, layer);
-		}
+		if (cn10k_mldev->cache_model_data)
+			ret = cn10k_ml_cache_model_data(cnxk_mldev, layer);
 	}
 
 	return ret;
-- 
2.45.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] ml/cnxk: enable data caching for all MRVL layers
  2024-07-31  6:06 [PATCH 1/1] ml/cnxk: enable data caching for all MRVL layers Srikanth Yalavarthi
@ 2024-09-19 17:33 ` Jerin Jacob
  0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2024-09-19 17:33 UTC (permalink / raw)
  To: Srikanth Yalavarthi; +Cc: dev, sshankarnara, aprabhu, ptakkar

On Wed, Jul 31, 2024 at 12:08 PM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> From: Anup Prabhu <aprabhu@marvell.com>
>
> Enabled data caching for all MRVL layers in TVM models

Add why?

If it is Fix, please add Fixes: tag

Also, MRVL can be removed

>
> Signed-off-by: Anup Prabhu <aprabhu@marvell.com>
> ---
>  drivers/ml/cnxk/cn10k_ml_ops.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c
> index 834e55e88e9..f6b2baa0df0 100644
> --- a/drivers/ml/cnxk/cn10k_ml_ops.c
> +++ b/drivers/ml/cnxk/cn10k_ml_ops.c
> @@ -996,13 +996,8 @@ cn10k_ml_layer_start(void *device, uint16_t model_id, const char *layer_name)
>         if (ret < 0) {
>                 cn10k_ml_layer_stop(device, model_id, layer_name);
>         } else {
> -               if (cn10k_mldev->cache_model_data) {
> -                       if ((model->type == ML_CNXK_MODEL_TYPE_GLOW &&
> -                            model->subtype == ML_CNXK_MODEL_SUBTYPE_GLOW_MRVL) ||
> -                           (model->type == ML_CNXK_MODEL_TYPE_TVM &&
> -                            model->subtype == ML_CNXK_MODEL_SUBTYPE_TVM_MRVL))
> -                               ret = cn10k_ml_cache_model_data(cnxk_mldev, layer);
> -               }
> +               if (cn10k_mldev->cache_model_data)
> +                       ret = cn10k_ml_cache_model_data(cnxk_mldev, layer);
>         }
>
>         return ret;
> --
> 2.45.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-19 17:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-31  6:06 [PATCH 1/1] ml/cnxk: enable data caching for all MRVL layers Srikanth Yalavarthi
2024-09-19 17:33 ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).