From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: maxime.coquelin@redhat.com, chenbox@nvidia.com, dev@dpdk.org
Subject: Re: [PATCH v4] virtio: optimize stats counters performance
Date: Wed, 31 Jul 2024 16:45:35 -0700 [thread overview]
Message-ID: <20240731164535.319944c0@hermes.local> (raw)
In-Reply-To: <20240731225816.39567-1-mb@smartsharesystems.com>
On Wed, 31 Jul 2024 22:58:16 +0000
Morten Brørup <mb@smartsharesystems.com> wrote:
> +
> +static inline void
> +virtio_update_packet_stats(struct virtnet_stats *const stats, const struct rte_mbuf *const mbuf)
> +{
> + uint32_t s = mbuf->pkt_len;
> + const struct rte_ether_addr *ea = rte_pktmbuf_mtod(mbuf, const struct rte_ether_addr *);
> +
> + stats->bytes += s;
> +
> + if (s >= 1024)
> + stats->size_bins[6 + (s > 1518)]++;
> + else if (s <= 64)
> + stats->size_bins[s >> 6]++;
> + else
> + stats->size_bins[32UL - rte_clz32(s) - 5]++;
> +
> + RTE_BUILD_BUG_ON(offsetof(struct virtnet_stats, broadcast) !=
> + offsetof(struct virtnet_stats, multicast) + sizeof(uint64_t));
> + if (unlikely(rte_is_multicast_ether_addr(ea)))
> + (&stats->multicast)[rte_is_broadcast_ether_addr(ea)]++;
> +}
>
Why move it to virtio_rxtx.h it was fine where it was.
next prev parent reply other threads:[~2024-07-31 23:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 13:17 [PATCH] " Morten Brørup
2024-07-31 14:04 ` [PATCH v2] " Morten Brørup
2024-07-31 15:13 ` [PATCH v3] " Morten Brørup
2024-07-31 22:58 ` [PATCH v4] " Morten Brørup
2024-07-31 23:45 ` Stephen Hemminger [this message]
2024-07-31 23:51 ` Morten Brørup
2024-08-01 16:03 ` [PATCH v5] " Morten Brørup
2024-08-01 16:17 ` Stephen Hemminger
2024-08-01 20:38 ` Morten Brørup
2024-08-02 14:49 ` Morten Brørup
2024-08-02 2:23 ` lihuisong (C)
2024-08-02 2:42 ` Stephen Hemminger
2024-08-02 3:17 ` lihuisong (C)
2024-08-02 11:27 ` Morten Brørup
2024-08-05 1:14 ` lihuisong (C)
2024-08-05 1:19 ` lihuisong (C)
2024-08-06 8:23 ` Chenbo Xia
2024-09-10 15:01 ` Maxime Coquelin
2024-09-19 12:04 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731164535.319944c0@hermes.local \
--to=stephen@networkplumber.org \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).