From: Stephen Hemminger <stephen@networkplumber.org>
To: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Varun Lakkur Ambaji Rao <varun.la@gmail.com>
Subject: Re: [PATCH v3] net/gve : Update EOP & csum bit in txd rte_mbuf chain
Date: Thu, 1 Aug 2024 11:54:49 -0700 [thread overview]
Message-ID: <20240801115449.407d1d7f@hermes.local> (raw)
In-Reply-To: <1722533273-2405457-1-git-send-email-tathagat.dpdk@gmail.com>
On Thu, 1 Aug 2024 17:27:53 +0000
Tathagat Priyadarshi <tathagat.dpdk@gmail.com> wrote:
> + if (ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO)
> + csum = 1;
> + else
> + cusm = 0;
> +
Obvious typo, did you do a final test build?
Could also use logical inverse operator instead of if() which will
generate better code sometimes.
csum = !!(ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO);
next prev parent reply other threads:[~2024-08-01 18:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 16:38 [PATCH] net/gve : Update EOP " Tathagat Priyadarshi
2024-07-31 20:30 ` Joshua Washington
2024-08-01 10:23 ` Tathagat Priyadarshi
2024-08-01 11:16 ` Ferruh Yigit
2024-08-01 16:24 ` Joshua Washington
2024-08-01 17:50 ` Tathagat Priyadarshi
2024-08-01 11:31 ` [PATCH v2] " Tathagat Priyadarshi
2024-08-01 17:27 ` [PATCH v3] net/gve : Update EOP & csum " Tathagat Priyadarshi
2024-08-01 18:54 ` Stephen Hemminger [this message]
2024-08-01 18:58 ` Tathagat Priyadarshi
2024-08-01 17:48 ` [PATCH v4] " Tathagat Priyadarshi
2024-08-02 5:08 ` [PATCH v5] " Tathagat Priyadarshi
2024-08-02 5:10 ` Tathagat Priyadarshi
2024-08-06 14:44 ` Tathagat Priyadarshi
2024-08-07 7:36 ` Ferruh Yigit
2024-08-07 9:39 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801115449.407d1d7f@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tathagat.dpdk@gmail.com \
--cc=varun.la@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).