From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94D6345716; Thu, 1 Aug 2024 20:54:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3149B40E19; Thu, 1 Aug 2024 20:54:54 +0200 (CEST) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id AD26240668 for ; Thu, 1 Aug 2024 20:54:52 +0200 (CEST) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2cd5e3c27c5so5057542a91.3 for ; Thu, 01 Aug 2024 11:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1722538492; x=1723143292; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=00wgOAwigDLlKUNAbx3VoYtQoSfNs1iMqevu74I5Gv4=; b=ioBSjVe3VMCtROIXztxRUPyYnFL2BD6rhAVIBrjsQ62x55Gwhp0NAQuYhqf23Zlj9L DkAD7y4TqPi5w2FF0XE0ra0PMiAX34z91jZNy2jEKQgHahS6mx3SLz42fPro74v6YEnL eSkrj4pgZLCsmVYat/gUKlmYMxzkhmVJM9Cy6Eenqae1tL+7qxz/YGYdR48a5nkI4KXM C893/WbbuvfZGYJaLsAZtAFoyCBdiydFbY5gfzAjtNnFfzcMKNCesFC4KYFM4mVoZIgW N+NBzXK1GcKTRKz7Y0kie3ic3BQmycacfgIFfYj3fe5E8BY5PND00RktoHNJzH/LRzUk ZNgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722538492; x=1723143292; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=00wgOAwigDLlKUNAbx3VoYtQoSfNs1iMqevu74I5Gv4=; b=X9ujQxr+oafBDSNLoQRNOUa1iu8eoliHR5L+xPMg7SYtMjKPloruW5J8H0g11lSsLn aQ1In+lzm7+WisOwSHZl7a4E1tCLksn4W0tbim9b1bhH4CQqnww52cju2tHPFU12lu3B zx2n+ZWe0UQscg+Edotq41CPALWk99h3phC+wWKXK0ADnQvsUgNL2LQRzdWnG8Vw/V0R JW1gdBCtJiV+XoQeTzBJ6yueP7+Efan+GmhwrBaQlE6kuOxM3Cx/8yPXa7Cqvs3hjLls 5aYTA1sqp2sg6lMmQcbLneg8z+IJbhoyQPulxhgVIP6TcXvAACao55FqNxUhR1Dy6q8z 4PqA== X-Gm-Message-State: AOJu0Yxa2G6WcN1wgZUHr1I0r166fNdTdC6nhf25YD1tHcR+tdr4O7nU +6hlfRPoBMt7B3Gl2OXvJDD3XphEdXceaf4pffFhIYbjjZmZZZTVm94wJ+2vcvU= X-Google-Smtp-Source: AGHT+IFRs6vz5Z4igIJgnI4jL8pUcF3KUcevcQAnNd+JxmyeuXJlobPInB2gk2m2vcIIANcSRWrkig== X-Received: by 2002:a17:90b:5207:b0:2cf:deea:963 with SMTP id 98e67ed59e1d1-2cff9517c94mr1480755a91.27.1722538491676; Thu, 01 Aug 2024 11:54:51 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cffaf69acbsm286748a91.1.2024.08.01.11.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 11:54:51 -0700 (PDT) Date: Thu, 1 Aug 2024 11:54:49 -0700 From: Stephen Hemminger To: Tathagat Priyadarshi Cc: dev@dpdk.org, stable@dpdk.org, Varun Lakkur Ambaji Rao Subject: Re: [PATCH v3] net/gve : Update EOP & csum bit in txd rte_mbuf chain Message-ID: <20240801115449.407d1d7f@hermes.local> In-Reply-To: <1722533273-2405457-1-git-send-email-tathagat.dpdk@gmail.com> References: <1722443901-2400194-1-git-send-email-tathagat.dpdk@gmail.com> <1722533273-2405457-1-git-send-email-tathagat.dpdk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 1 Aug 2024 17:27:53 +0000 Tathagat Priyadarshi wrote: > + if (ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO) > + csum = 1; > + else > + cusm = 0; > + Obvious typo, did you do a final test build? Could also use logical inverse operator instead of if() which will generate better code sometimes. csum = !!(ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO);