From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E8084571E; Fri, 2 Aug 2024 20:06:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F04AF40E24; Fri, 2 Aug 2024 20:06:18 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 39ACF40E22 for ; Fri, 2 Aug 2024 20:06:18 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2cd34c8c588so5651061a91.0 for ; Fri, 02 Aug 2024 11:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1722621977; x=1723226777; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vC75bUNTlCRuZGdwuKOFWQEvwuKIR7/uy9uUTJyX+lk=; b=GtGphTdWho954exetMQd+XcaCHrePOlbuHJ0oPUo52rzwqSPPlLdqqTA8AWRyRKsxy z7K3BJPzw4qQv4GXPQw8RQNB/e2caECHIoqI3uV4i6WjeWNEeZFiW1xgrV4zBLwkIKgI qsTrvpSLE/+DuYUuCzBcCZXmnVphfEijndvM7tNKNJgtw2sLnibuJq8Ctwip69fqQ9fY m2OsYa/7V+dJEDcOpeER5EpKuEvcaRfRl0G8zZJe8XFRVGcFXCL+eK2XooYaAUGP7l31 opNYemjqCrXRupbpXthyXgGmkI//mnTpaPKvQZsWOWjuhjPUcPT7xc1FxgTQTXMLmRbU yHbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722621977; x=1723226777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vC75bUNTlCRuZGdwuKOFWQEvwuKIR7/uy9uUTJyX+lk=; b=fnSoTHk03TyE7C2e57qRSSPTyaZmsIC9DGE3dGSAf4o4fSUEeoSR1BuotleYM5ZNrt 5VvGBTMwjv8M4fEkJJsaNLjTbUd9wPzbiEhDt5PjKJiD8Ppxnt+/b4nk5GWyInXh91n/ Ko6bDDx2vjdZpnHDTkw3W/4u3lrptdh/r1XPSZXnAjqCTBrFEDcbKy9ngYCuVpLivAaw MIirAc6L8W2NlS2qk0raezi4IUQfrEtfBDrQpwN9szqyioCxaPwQOdGkq2i6ugY9pJ8J k3RchroZtYHpBT1e50CIBWdHMlGsKmJc6l7FTQozPCqH7GSlRzT3oBVq94wxiAwHs+dZ vxxw== X-Gm-Message-State: AOJu0YyQeQ+64FGvFE5cYSlS9A4hPr+aqOG7UC399QgJAZ67PXOumAGE UuFslFeL366e74duZLPzLIAgJgFjU/joS6of2/fuPIgDjgYarA5wb4sWlix0T8Y= X-Google-Smtp-Source: AGHT+IEhGNLwOz9aiNBZkpfR3bggk1qggE+iDRBXLkXSLLMOEKBiEAXhMYp+z+0z1Rxp14eoNO/VpA== X-Received: by 2002:a17:90b:4a92:b0:2c2:c149:ca4 with SMTP id 98e67ed59e1d1-2cff9559033mr4765812a91.43.1722621977140; Fri, 02 Aug 2024 11:06:17 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cfdc4e3c41sm5497870a91.48.2024.08.02.11.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 11:06:16 -0700 (PDT) Date: Fri, 2 Aug 2024 11:06:14 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: Subject: Re: [PATCH v5 3/4] test: add test for packet dissector Message-ID: <20240802110614.06b4d416@hermes.local> In-Reply-To: References: <20240312220129.70667-1-stephen@networkplumber.org> <20240801190617.201574-1-stephen@networkplumber.org> <20240801190617.201574-4-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 2 Aug 2024 09:38:23 +0100 Bruce Richardson wrote: > > + rte_dissect_mbuf(obuf, sizeof(obuf), &mb, 0); > > + > > + return TEST_SUCCESS; > > +} > > What are these test cases actually verifying - can any of them actually > fail? I don't see the output being checked anywhere. > > /Bruce Mostly the tests are to make sure that code doesn't crash when given invalid packet data or truncated packet.