From: Stephen Hemminger <stephen@networkplumber.org>
To: Yong Zhang <zhang.yong25@zte.com.cn>
Cc: dev@dpdk.org
Subject: Re: [v1,1/5] raw/zxdh: introduce zxdh raw device driver
Date: Mon, 5 Aug 2024 08:45:56 -0700 [thread overview]
Message-ID: <20240805084556.46ddf663@hermes.local> (raw)
In-Reply-To: <20240805133750.1542615-1-zhang.yong25@zte.com.cn>
On Mon, 5 Aug 2024 21:34:53 +0800
Yong Zhang <zhang.yong25@zte.com.cn> wrote:
> +struct zxdh_gdma_buff_desc {
> + uint SrcAddr_L;
> + uint DstAddr_L;
> + uint Xpara;
> + uint ZY_para;
> + uint ZY_SrcStep;
> + uint ZY_DstStep;
> + uint ExtAddr;
> + uint LLI_Addr_L;
> + uint LLI_Addr_H;
> + uint ChCont;
> + uint LLI_User;
> + uint ErrAddr;
> + uint Control;
> + uint SrcAddr_H;
> + uint DstAddr_H;
> + uint Reserved;
> +};
> +
Why is this driver using uint type?
It should be using datatypes with explicit size (like uint32_t) to
make sure it can be used on both 32 and 64 bit builds.
next prev parent reply other threads:[~2024-08-05 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 13:34 Yong Zhang
2024-08-05 13:34 ` [v1,2/5] raw/zxdh: add support for queue setup operation Yong Zhang
2024-08-05 13:34 ` [v1,3/5] raw/zxdh: add support for standard rawdev operations Yong Zhang
2024-08-05 13:35 ` [v1,4/5] raw/zxdh: add support for enqueue operation Yong Zhang
2024-08-05 13:35 ` [v1,5/5] raw/zxdh: add support for dequeue operation Yong Zhang
2024-08-05 15:45 ` Stephen Hemminger [this message]
2024-08-12 6:40 ` [v1,1/5] raw/zxdh: introduce zxdh raw device driver zhang.yong25
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805084556.46ddf663@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=zhang.yong25@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).