From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95B2B45741; Mon, 5 Aug 2024 17:46:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A20F402D2; Mon, 5 Aug 2024 17:46:01 +0200 (CEST) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 3E32040295 for ; Mon, 5 Aug 2024 17:46:00 +0200 (CEST) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-710887a8083so1096679b3a.0 for ; Mon, 05 Aug 2024 08:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1722872759; x=1723477559; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=kgODRjMKEcoLNza4G9F1sGtiAwUSSCpIgbvas9qGVek=; b=vqy896CpC+6+Sc5OtKcaalbqhSz2pts8iVASZo1gAE7/yatT0XSm6xm64Rx7u4yzRv +5s3uGQYrqxGja0jN0scInHR+UokhBpYIMgOY9K1NEaLtywrsjG/EgxRPzr8ZCKV3US9 Jlrxe2HnBbyveVGOMThufYbns2AHifr8Ugu5w2+TchIt5WsRK4JeneaNfeB7/UUmU5rT pFNFXretjSTSWiMfqhRCjPSPCTfTiCy/JH21mSEg8mmYBL7SyMyoEtHIuucrWRn9Myi6 ODxPt8QyESpRyDS4d0C+mWS0dasP0aSj/a3uDtEsNPzP0FTvnI3ix2hg1iK55tgCi1og jfhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722872759; x=1723477559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kgODRjMKEcoLNza4G9F1sGtiAwUSSCpIgbvas9qGVek=; b=YNkyasNU3gw5DcyPAQqus+LmbwczV3uQfTP/sMBSu56W7b6FQBbJ1nOynBrfA0oKoA CfoY4VoXBCwTEZCqUqQXo/6MX+0TfZ+Igdzn57Fz8pFj5NcP4APqCDBT0pY6KGcGQKZv VJIdnRaMgypsQAydiMCLhBJgLGcacw42X05tYz3tfIvpqQlVSYis7YyKXadonRMDPdYz FU3ytqK3hbGcWQ8wwIhaNwCZ8Qt21zQFDAkRuIms1TX/x8AL2HdBqDc7Cp1CvbPK/boY EntQZEz8RYUpcFOcC2pDFPDSgdRDwBCKInb/jTYNuccSfplOnWcGSEjEY9sOEF8kFfyF lTGg== X-Gm-Message-State: AOJu0YxVSa/HykKAiFwwV0Q1FMEoDfFLvtv4TKzfQbiVql8ECPKmMfwr YYO28K4NzG+L/tMv/9XtwbxIhhfnRbeivQpL7pZQhXXtn9whU1Qle4AEVjls25o= X-Google-Smtp-Source: AGHT+IG2ZG74S468sKTcMGN8aKYvGYrAuAijepw2F3AvZJ/bpewLWfnZLnPDVRzepFTgYkEZTxHtbA== X-Received: by 2002:a05:6a00:ac4:b0:70b:30ce:dfdb with SMTP id d2e1a72fcca58-7106d0811b7mr11650757b3a.24.1722872759119; Mon, 05 Aug 2024 08:45:59 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7106ed2bff6sm5547650b3a.198.2024.08.05.08.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Aug 2024 08:45:58 -0700 (PDT) Date: Mon, 5 Aug 2024 08:45:56 -0700 From: Stephen Hemminger To: Yong Zhang Cc: dev@dpdk.org Subject: Re: [v1,1/5] raw/zxdh: introduce zxdh raw device driver Message-ID: <20240805084556.46ddf663@hermes.local> In-Reply-To: <20240805133750.1542615-1-zhang.yong25@zte.com.cn> References: <20240805133750.1542615-1-zhang.yong25@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 5 Aug 2024 21:34:53 +0800 Yong Zhang wrote: > +struct zxdh_gdma_buff_desc { > + uint SrcAddr_L; > + uint DstAddr_L; > + uint Xpara; > + uint ZY_para; > + uint ZY_SrcStep; > + uint ZY_DstStep; > + uint ExtAddr; > + uint LLI_Addr_L; > + uint LLI_Addr_H; > + uint ChCont; > + uint LLI_User; > + uint ErrAddr; > + uint Control; > + uint SrcAddr_H; > + uint DstAddr_H; > + uint Reserved; > +}; > + Why is this driver using uint type? It should be using datatypes with explicit size (like uint32_t) to make sure it can be used on both 32 and 64 bit builds.