From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56AEC45761; Wed, 7 Aug 2024 22:44:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 439C240DFD; Wed, 7 Aug 2024 22:44:44 +0200 (CEST) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by mails.dpdk.org (Postfix) with ESMTP id 18F61402AE for ; Wed, 7 Aug 2024 22:44:43 +0200 (CEST) Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2ef1c12ae23so2172601fa.0 for ; Wed, 07 Aug 2024 13:44:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723063482; x=1723668282; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AiXjaJrc6fTV0GEuIkl9Iu3vxsjjAMUlTskHt1EjsUs=; b=J8VXXLiCuVFQ25b9y/k2AQh41uKMPQB/qzi9FFP9wkHoaC73p1K+RqCWiKT0WDATk2 6UKJHhFrHVX52onqP2/H81WBAEGlvJfuCVxICv2+D2/MQj0ImF7Wg8q6PF0ybSEx5trn KuWwZ6YJkMg8T7XkS9MQR/qA4Dm3pI+3eh0RrYFM7A7OfdNhk0z+PwNMBOFdLoI0G1M/ U7btuUUj0x2gx3UFRpr5QKWWmiMKb3rXPmX7PhQn21nQMUzBEeOQZ1YuBnEMip8w/+iC a/f+hnO2o4PCtP+ycVIL2DPWqz+O4cfEtbz7CRPNniaM3RKjqdQokppuTiOW9caIYVTD zPfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723063482; x=1723668282; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AiXjaJrc6fTV0GEuIkl9Iu3vxsjjAMUlTskHt1EjsUs=; b=KXfcDRQjFnu+ED1Gt3LA3SMhSuAC+6Q5Gldv8A+85cIqUwjXRXrKWUO1XIGgWWK/4S bWqR4asEeCKiUzjBXvSO8OdHPxv147N1AC03qlyNI7WpIopqSND1PFO5iXXDBvxXz0yA v4BPINTAZmmYJEsQ9Cz5byHGzJVE1Doq+T07fA1pLsVE+owUhGErvAZa4suEmb0cyITO m9/TMAOgWRSOd0TRZ7Cn/QLpVTJJ/Az7YogCYRGuteYlpn/mZShqVSPcvJ2UptFeGmq0 GGOL/oo4Wurz2+/rGB2WGn7PXzl+i5JpsoyTpIYdO1YU1aOc1xmBb8WJxUIqemh8YuXy Mg0w== X-Gm-Message-State: AOJu0Yxa9NwlkcHo8PsUDMk5aOTT9T+dpP2lj4KNJvjedCLH2AtEb3dD 6hbcpsedB+FlX3M/iaT5sVvnZu8gMixKhJTeQZxdjKlFQBtDB2h7/4N1ow== X-Google-Smtp-Source: AGHT+IENYzQUcBOc3XFzHv01X0uZdQ4q0Bn3yISOAGoVPvuch84KloF00dpT4S5dNdNBRZHP5JhVTQ== X-Received: by 2002:a2e:320b:0:b0:2ee:8ea4:d649 with SMTP id 38308e7fff4ca-2f15aa87765mr131358921fa.16.1723063481624; Wed, 07 Aug 2024 13:44:41 -0700 (PDT) Received: from saturn.intmts.ru ([46.175.25.246]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f15e1c7581sm19102691fa.68.2024.08.07.13.44.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 13:44:41 -0700 (PDT) From: Igor Gutorov To: dev@dpdk.org Cc: Igor Gutorov Subject: [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits Date: Wed, 7 Aug 2024 23:44:04 +0300 Message-ID: <20240807204406.700332-1-igootorov@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Slava > > Is an `int` appropriate for `log_max_wq_sz`? Seems like a `uint8_t` > > is sufficient, but I've left it an `int` for consistency with the > > other `log_max_*` values. > > Right, uint8_t looks to be enough. No objection to optimize others to > uint8_t. Changed log_max_wq_sz to uint8_t in the main patch. The others are changed in a separate patch. Let me know if it'd be preferrable to squash the patches. > > > > > 4. Please, format your patch according to the "fix" template. > > > > I've reworded the commit message a little bit. But I don't see these > > issues on Bugzilla, I've stumbled upon them independently. If you'd > > like the bug reports to be created, let me know. > > I meant this: https://doc.dpdk.org/guides/contributing/patches.html > Please see chapter "8.7. Commit Messages: Body" about "Fixes" and "Cc: > stable@dpdk.org". It is a bit difficult for me to reference a commit for the "Fixes", since it's a bit hard to call this a regression specifically. I set this tag to the commit that first introduced configuring the device. Is that appropriate? > > Also, please run checking script: /devtools/check-git-log.sh' -1 to > verify commit message compliance. Thanks! No warnings now, except for "Wrong headline prefix" for the first patch because it modifies both common/mlx5 and net/mlx5. I can split the patch into two if needed. v3: * Added uint8_t optimization * Fixed commit messages v2: * Patch reworked to query HCA attributes Igor Gutorov (2): net/mlx5: fix reported Rx/Tx desc limits common/mlx5: reduce HCA attribute type sizes drivers/common/mlx5/mlx5_devx_cmds.c | 1 + drivers/common/mlx5/mlx5_devx_cmds.h | 9 +++++---- drivers/net/mlx5/mlx5_ethdev.c | 4 ++++ drivers/net/mlx5/mlx5_rxq.c | 8 ++++++++ drivers/net/mlx5/mlx5_txq.c | 8 ++++++++ 5 files changed, 26 insertions(+), 4 deletions(-) -- 2.45.2