From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 153114576C; Thu, 8 Aug 2024 17:19:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 026CE427E1; Thu, 8 Aug 2024 17:19:17 +0200 (CEST) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id DE32F4278D for ; Thu, 8 Aug 2024 17:19:14 +0200 (CEST) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7106e2d0ec1so961009b3a.2 for ; Thu, 08 Aug 2024 08:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1723130354; x=1723735154; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=pbt2rX5OvZlTsds3gpw6Z62uujBZ/jhmyvFWlvGmdaI=; b=ZggLV12OmqHseq/4Japm+KmyJP3YqIOV16tc7mXzNcH32dMunQrmYDLWYP+yWsIYA1 lGoPiwM64YwrVcAfIB7+sGIfBFRI5yYk1WMxhEkxFxh7KnLHX95pcUHWXom52gL9CBIQ MgbKBTgIWMqI8VVoXShJG4DCi5EwlEn92arnrHXHUVuVc8ubRcN8dex0wi4TAovKoxWz qKsKNaw+AyNDV8tFBg6Yx9NDqydOT1zXos/imCN+wQlyXebmojifQw9NSYJU/ri/Q6Fb mVTFuo/vcZgecaXjPH2/4dhCpif/mWJM2mRVG35mjz5GtYfuZx0xTtZt1nhFJaEybtho XUaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723130354; x=1723735154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pbt2rX5OvZlTsds3gpw6Z62uujBZ/jhmyvFWlvGmdaI=; b=kLFrXzNoy2I+M7MUhc9hxRx9vW9BN/HRrjbdttwQCuMgwcXnptjQQVzmDp9d4+7uze K4g3DlbvrdteupEMkeAAyzyCjPz4LbH2zP3ZPqvmhYrTwEWqsQR8UEv6E83iWRzpruQn PXTZH7WFQMUA3FmHMnp/6VpU3Pr/wxzCfV1tayplM+oE5m7lgaVKaezqG1jD0RX3FdB3 lDQ4oAKzPW5iAf3Dc/+oiCxgVu0FmuOT5+GXMSCY1hKmuJ8D3IybT08Nu2qRVceFIgHH LZrCDKvrXbjiXXAI5l+JYkjwORsZhZ0Aq02ZnMpqZWpgg/gSw6bL+KNGGPXSebm2SFQs O4LA== X-Gm-Message-State: AOJu0Yzs0acaublkt52zNdcTjctvlNCa1BD34Wug9K0AAXv4ZzaCG3+a JKcGeSPr9R0iORGRWSAD7AtQJ4zt5c4M/H5qc9SGYdHOwMH6UVMNNKKcIM4yrWI= X-Google-Smtp-Source: AGHT+IHfZTEQUrkJ+AS1sx0yw9KG/Y73Ca/oORcp4Bix41UoOTGj73x9RFmC2ghUfdbEg0gF5DyeVg== X-Received: by 2002:a05:6a00:1248:b0:705:9ddb:db6b with SMTP id d2e1a72fcca58-710cada68b6mr2881653b3a.13.1723130353972; Thu, 08 Aug 2024 08:19:13 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710cb20a671sm1241684b3a.24.2024.08.08.08.19.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 08:19:13 -0700 (PDT) Date: Thu, 8 Aug 2024 08:19:12 -0700 From: Stephen Hemminger To: Hanxiao Li Cc: dev@dpdk.org Subject: Re: [PATCH 3/4] [v1,3/4] zsda: add support for queue operation Message-ID: <20240808081912.31f633d7@hermes.local> In-Reply-To: <20240808085030.1685755-3-li.hanxiao@zte.com.cn> References: <20240808085030.1685755-1-li.hanxiao@zte.com.cn> <20240808085030.1685755-3-li.hanxiao@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 8 Aug 2024 16:50:13 +0800 Hanxiao Li wrote: > +int > +zsda_get_queue_cfg(struct zsda_pci_device *zsda_pci_dev) > +{ > + uint8_t i = 0; Useless initialization, you are setting it the first loop. > + uint32_t index = 0; > + enum zsda_service_type type = ZSDA_SERVICE_INVALID; > + struct zsda_qp_hw *zsda_hw_qps = zsda_pci_dev->zsda_hw_qps; > + struct qinfo qcfg; > + int ret = 0; Another useless initialization. > + > + for (i = 0; i < zsda_num_used_qps; i++) {