From: Stephen Hemminger <stephen@networkplumber.org>
To: Hanxiao Li <li.hanxiao@zte.com.cn>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/4] [v1,1/4] zsda: Introduce zsda device drivers
Date: Thu, 8 Aug 2024 08:23:45 -0700 [thread overview]
Message-ID: <20240808082345.2d03dd73@hermes.local> (raw)
In-Reply-To: <20240808085030.1685755-1-li.hanxiao@zte.com.cn>
On Thu, 8 Aug 2024 16:50:11 +0800
Hanxiao Li <li.hanxiao@zte.com.cn> wrote:
> +static uint8_t
> +zsda_crc8(uint8_t *message, int length)
> +{
> + uint8_t crc = 0;
> + int i;
> +
> + for (i = 0; i < length; i++)
> + crc = crc8_table[crc ^ message[i]];
> + return crc;
> +}
The code in this driver could start using const many places
to clarify what is input and what is result.
prev parent reply other threads:[~2024-08-08 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 8:50 Hanxiao Li
2024-08-08 8:50 ` [PATCH 2/4] [v1,2/4] zsda: add support for zsdadev operations Hanxiao Li
2024-08-08 8:50 ` [PATCH 3/4] [v1,3/4] zsda: add support for queue operation Hanxiao Li
2024-08-08 15:18 ` Stephen Hemminger
2024-08-08 15:19 ` Stephen Hemminger
2024-08-08 8:50 ` [PATCH 4/4] [v1,4/4] zsda: add compressdev driver and interface Hanxiao Li
2024-08-08 15:22 ` [PATCH 1/4] [v1,1/4] zsda: Introduce zsda device drivers Stephen Hemminger
2024-08-15 1:50 ` li.hanxiao
2024-08-08 15:23 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808082345.2d03dd73@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=li.hanxiao@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).