From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59CBD4576E; Thu, 8 Aug 2024 20:52:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2789E4278D; Thu, 8 Aug 2024 20:52:30 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 97E704066F for ; Thu, 8 Aug 2024 20:52:29 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7106e2d0ec1so1147204b3a.2 for ; Thu, 08 Aug 2024 11:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1723143148; x=1723747948; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=43FtneV2vAWevqfY+SMC7mHPsoS2oawxkdj0vLRv2wI=; b=GOsVWAC5yP7o8lm5cdS52/L2Bj+Mei4wfnz4T0PoVy3YCdS5e7U7T+lwkmIKTp/G0u uo6eQ9KH6xXwB3dDIAOk7Ax1CjyXKTS4bfjmlhbLwnFRcffma3K4uf/a87mju+GS9/s8 N2B05DU565gnRkexjREAfGz4mDS9XkV5IFzy+iksUeSWjJSwT4iWhxBkLgqNP+1LmeXL g1PnuikIzIijuDX+g1l70HHwCTN5J8zLy0j+bMaw5PkP3AIUlok+LMeLcF9iShf0Wp24 0MX9nQThdth2SGzxzyA20Kqjg5LG5kf+2AgEfZfJU7XpAZFbyO30/O63pc2Yyzfd+X1c sEEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723143148; x=1723747948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=43FtneV2vAWevqfY+SMC7mHPsoS2oawxkdj0vLRv2wI=; b=XpSAwJiW3Jxk/1IEfwoGsxe9QTdbJZb46gNntaoN6LY9EoX4zuFYrQGnvuknJPyhwB WGDe7Tm/9EMf95j7EdNbWEc9E/xVYGBvt6cJVtMAkLYmLH6NLviRI7nyGnR8hlhkr+GV TuaeshL4aTD1OFxJbJhfKcUeFG18yLu6XQ+Dh+D/6NdXjCK9MM7GgeCf7Cx9SoXD6fck l/FdTpQa0BORsxv0gcdH2v/xs7WovI+S9M9zTatx9RCMZb6EnXmEJ0F5s9PVnkdH9NZe KtVZOLlVwHj0VHyJWWpMroxoJVMALkfUUHGzuFSDw0l8gMYo+Jm4yQvyFe2LLaML9BOt GR8Q== X-Gm-Message-State: AOJu0YxYJ9ByoT2YKedxB08Cf20+KCgsoKwWXqf3UtRT/1XtE+lAooP4 0gT8esinw5jLXmW5IFmg8MQ6gqNbDpP68RlEVBb4ctowNg2ANtfHWfNodY7hAU8= X-Google-Smtp-Source: AGHT+IEyX+x/DlVleskdudCaFly6iFt/VyKXeOQPCS4zEbRdUOI7BUq5xzdpYUVJ5vO09WE+8iOD0w== X-Received: by 2002:a05:6a00:3e20:b0:70d:281d:ee78 with SMTP id d2e1a72fcca58-710cad6b960mr3347707b3a.10.1723143148513; Thu, 08 Aug 2024 11:52:28 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710cb2d352esm1424978b3a.123.2024.08.08.11.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 11:52:28 -0700 (PDT) Date: Thu, 8 Aug 2024 11:52:23 -0700 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, Tyler Retzlaff , Aaron Conole Subject: Re: [PATCH 1/4] test: update alarm test Message-ID: <20240808115223.6d5ac846@hermes.local> In-Reply-To: References: <20240718191049.84865-1-stephen@networkplumber.org> <20240718191049.84865-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 6 Aug 2024 14:45:45 +0200 David Marchand wrote: > On Thu, Jul 18, 2024 at 9:11=E2=80=AFPM Stephen Hemminger > wrote: > > > > This test should be using the TEST_ASSERT macros, and can be > > run as part of the fast test suite now. > > > > Signed-off-by: Stephen Hemminger =20 >=20 > [...] >=20 > > + ret =3D rte_eal_alarm_cancel(test_alarm_callback, NULL); > > + /* return is the number of the alarm set (or 0 if none or -1 if= error) */ > > + TEST_ASSERT(ret > 0, "could not cancel an alarm: %d", ret); > > > > return 0; > > } > > > > -REGISTER_TEST_COMMAND(alarm_autotest, test_alarm); > > +REGISTER_FAST_TEST(alarm_autotest, true, true, test_alarm); =20 >=20 > This test was removed from the fast-tests list as it was triggering > false failures in some CI. > ee00af60170b ("test: remove strict timing requirements some tests") I can see why that test failed (too short an alarm), but the whole test has= lots of other issues. Starting new series to address.