From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DCFC45777; Fri, 9 Aug 2024 11:14:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 523D542E89; Fri, 9 Aug 2024 11:14:22 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2066.outbound.protection.outlook.com [40.107.22.66]) by mails.dpdk.org (Postfix) with ESMTP id 4C0F440274 for ; Fri, 9 Aug 2024 11:14:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ovy62gbcRcgx1cLJhP5Vq9a9FfSH8QzOepyd2lWzyEqbt84ThvDMN7sPR+c3HTxPOlx/uLcxt2+3INI9PrfTaUmmL4g0WLcdFnWmwWjD/pVAjR4mtU3mBQsSl8K+zwj5URptXgHw3Qcd8I4H7M6s8qQFawRWtZeX3eooixiIt6UFwV6l1zEQIPwTqMKaMHsBy23/C3Cuth9tzuJqyuIf4RJU7fTqtW99Z3Tx04YKa5QZc37A3BjdBi9aYlcMAC5RoN3fGBaaZyEH5MrUagepecFuh8PeAW80F3j1WTmB6EbfvVPE+5M66ytg1ymzf+ZHp4UlPN0UngSpsbhdXtnWQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqGcpwfHVC/DYFyNL8+lquUhAol/PLB+PTIxYV+C6HY=; b=qp5AxhGPum1UluR6mdnVtkVrn+HprEr0rUQW6mLMnFgB4Da7ZO1BjTLJJaGKE3fsrfXXgf/eA84qSaENrp56MYY/N/XLcHNd1Wzjxop2BzvTYN3hphr5D75rVyllb80d+CXGAZ5hFIufUMSug6ek0P/MAwd0Os6PHygSzYXkGjL0m0es5bTJIT+Wn7XsVPQZVSVpqZZx4qBfOazMv/ZDyZ+Qwr3SmbNp2JWasmA9u5NzvSUTJVRIOvAz+j8bIBRkvJ/u2Dn63UwkWvhLPJtmeCA/FVexIYpuALo2sRrGkmx7i44a0gw3h12taZrSoJ9QZkWN+nkFcsZLMd3CsSicOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=arm.com smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jqGcpwfHVC/DYFyNL8+lquUhAol/PLB+PTIxYV+C6HY=; b=hIxWrlQmBH89IsAGDhsoD1maq+cL/R3dRSL2uthEEWLnA2yQztDNwTTWTSPFKsiCZd9Ue12OwfuM4tcBi2k6ek1XKa0uFQPszEPEPR7EdesY9ifI+OiBFFKogf+/OPEWJQIuiBO+bsSL7cCicTrj7v2dfnoRND0MMLd0Aqtj3wr8ucvqs+jsTtZTTzATK9xARnPQhdSFYPdiNERs0nYk3atCb2WA24JJkv9pMFhbJFG8xVSRDopPrw1KO6It1HFYdAQCt95CvZvZt39gsOe8cHHIQD9Pi1TnbgHQovx2LGs8+UJDRVi9ncXQjGWXeL38pQm7D+r/VrFDm3vXz/BWNw== Received: from DU2PR04CA0048.eurprd04.prod.outlook.com (2603:10a6:10:234::23) by AM9PR07MB7874.eurprd07.prod.outlook.com (2603:10a6:20b:2fc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.15; Fri, 9 Aug 2024 09:14:16 +0000 Received: from DB1PEPF000509FC.eurprd03.prod.outlook.com (2603:10a6:10:234:cafe::68) by DU2PR04CA0048.outlook.office365.com (2603:10a6:10:234::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.15 via Frontend Transport; Fri, 9 Aug 2024 09:14:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DB1PEPF000509FC.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Fri, 9 Aug 2024 09:14:16 +0000 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.60) with Microsoft SMTP Server id 15.2.1544.11; Fri, 9 Aug 2024 11:14:15 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id ADE1D1C0073; Fri, 9 Aug 2024 11:14:15 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Joyce Kong , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [PATCH 4/5] eal: add unit tests for atomic bit access functions Date: Fri, 9 Aug 2024 11:04:38 +0200 Message-ID: <20240809090439.589295-5-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240809090439.589295-1-mattias.ronnblom@ericsson.com> References: <20240505083737.118649-2-mattias.ronnblom@ericsson.com> <20240809090439.589295-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509FC:EE_|AM9PR07MB7874:EE_ X-MS-Office365-Filtering-Correlation-Id: abeb5db1-45a7-40f2-bbc6-08dcb853a4a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dmU1M3FsK2pJUjFWUnNzT21ybWIwQ2c0amlzSUxzWWtnNmNlMzhIS0RoWDBm?= =?utf-8?B?bERqSkxIKytCQXhuWjJnbDJMQXNsYXRaQ1ZxdWxXb05yeTJDOFMwZ1BiYk8z?= =?utf-8?B?VGJnUWtnR3gyT1g5QlI3NXJFQkpaQWsvcktldS81NmpMNHJKclZzL0tIVGRL?= =?utf-8?B?REZ2N055TUUzTktwWHZjSVBmVVIwYTlrYzFFdTVKM0xhMnIrUXVYdG40N1Mw?= =?utf-8?B?amZNb0d0c3MwZWdvNzlXZnlJRWV4RnJhQThYSjFiVlNlRTBVUGR6WlhJalJS?= =?utf-8?B?ZHRVcS9MaVBWOWdwaC9QWFhUYkdIblo2SDl5K3Z6eC8rOEJ4dGVoUW5QRkpk?= =?utf-8?B?SnRVMWdyckpTWERIc0R4VGQ2T2lNWjZIWlk2Y0U2Q2w4VXNSelpuMExvOVJu?= =?utf-8?B?czlYM1MvSTBJaVlUWFBCdHJPTDhZUXp0VTR4VEpMT2IzYW5uV2diam5hcDJi?= =?utf-8?B?K05HMjBTZGlrM0drMElhaEZkNUVIOEQ5bURaejl5YTg2Y09nOTllS3RnUmtj?= =?utf-8?B?Q2pZYW42Z1U1MEcrS1FQVFR5MFcrbDdWd3daVVZjVGpzN2ZNUGR3Wlo2U0U2?= =?utf-8?B?TVphWHRmV1A5YTRLTUsxVXlVRzgzeDV5cEFqMjFKNDVQOS9ZYllMOTQ4ZTEx?= =?utf-8?B?aFJDbDVGb0R4N1NqbHlZWEpmWFRyWGhlMGh5aWhFekVhYVVFRUlVamZsUzFp?= =?utf-8?B?OGkzQjRHRGl1dS91SHhuLzlLWk1reWdNZStUS2F2cVU0d0JrR2xoOFNVZzVK?= =?utf-8?B?VkNpdkJVb3RzZVdRcXlJUDBlbWVtTFcwN1pqc3VBQlNLK1FPUkp2TmJJNTlT?= =?utf-8?B?Zi9rMFVIakFPVFI5Z1ZZRi9sL1k1TnNYYjVLNTI4bDl6OHp0R3RFVFcrMldR?= =?utf-8?B?SlVIM2lOeVQ5alErcSt3VGNzTGRXeXBZTzJ5bE1XdDNYVm5OdVZkcEJQRkp5?= =?utf-8?B?RHRvL1gwM0tjZ243T3ZGckg3VGliV0o5Rjh1elFzN3BZSVkxTkcxWFArYlY2?= =?utf-8?B?NmkzV1hKVC9nbno5T1drZDlQbzRrWjRVU2VUblQ2eWwwaG5xMGlUQVBMbDlh?= =?utf-8?B?ZGRXQmt4U3A2Tk91QVM5WGFNVUswVy9lZy82WTR5QmtRUlIxZTM1Sk9QVUk1?= =?utf-8?B?ZVhyS3FnMDhQeVRXSlZJTW9CTWxiSjFOOC9CaGpPL0FKSEZ2QW4wVHNHZURN?= =?utf-8?B?d1ozS0VxRUFPRDluRzdDcU8ranRRZE5hNmR6Z01iM0U2VWt6K1Y3UkNNaVZ2?= =?utf-8?B?K3BkbVkxbWEzSlpLenhYL0JmYzg2UDFjdGgvaFo2Yi9PcnRtWlZRT2lrRnE2?= =?utf-8?B?YmcrclJmNVNWVTZVK3FzREFWU3FrbkpFUENnbyt2RVZDWFBabVB0RG9OeEVo?= =?utf-8?B?N2E2WGVZT2RxY1RjeUp5UEVWUkZpOUlWZVRKNEJ2RmNIbGVzZFRwYnhZR25o?= =?utf-8?B?elBXUGVpSmFMUVppeFN2NnRGZWVOYkpMSTc2R1hVNzlIYkphaTdGY09DZ1J4?= =?utf-8?B?WXRoT2hlcUtKTnJOR2owTFgzbGpQdWRkTnFXTndIQXdXUHEyYXVSTE9ncEFs?= =?utf-8?B?ZlY2ZU9TbTFHNEVBMWdSLzJjWmtvOC9UOWl1RXpFNW9yYmZxN3VuQzFkV0hS?= =?utf-8?B?bU5vNGpGbG5SRVl0eDNmcFNxTlZsZEZJTDhIUStWclhjQ1JNbm56Z1BGVFB1?= =?utf-8?B?enJkbk5kTCtQY2h6b3AwazAzdDZXN2dtMG4zVTNnejMrV2tvcmxXV3p3YWxz?= =?utf-8?B?dCtPQ1JTWmF0MHpHdkJpWkp0Z01Ic0JabmhXODNJcDB5dWdyRGhjcUFVRUdG?= =?utf-8?B?WG5LNmlZcTNpY05oSTdqd0N3eGYwNEJvWU5INzZuL0VKb0RLTUtnaExCa011?= =?utf-8?B?c2tPQk5HbTBSejlPajFEd0NUZkdsWnJOSjNKMVdBQXR6OXc9PQ==?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2024 09:14:16.2780 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: abeb5db1-45a7-40f2-bbc6-08dcb853a4a0 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509FC.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR07MB7874 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extend bitops tests to cover the rte_bit_atomic_*() family of functions. RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff --- app/test/test_bitops.c | 313 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 312 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index 322f58c066..b80216a0a1 100644 --- a/app/test/test_bitops.c +++ b/app/test/test_bitops.c @@ -3,10 +3,13 @@ * Copyright(c) 2024 Ericsson AB */ +#include #include -#include #include +#include +#include +#include #include #include "test.h" @@ -61,6 +64,304 @@ GEN_TEST_BIT_ACCESS(test_bit_access32, rte_bit_set, rte_bit_clear, GEN_TEST_BIT_ACCESS(test_bit_access64, rte_bit_set, rte_bit_clear, rte_bit_assign, rte_bit_flip, rte_bit_test, 64) +#define bit_atomic_set(addr, nr) \ + rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_clear(addr, nr) \ + rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_assign(addr, nr, value) \ + rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed) + +#define bit_atomic_flip(addr, nr) \ + rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_test(addr, nr) \ + rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 32) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 64) + +#define PARALLEL_TEST_RUNTIME 0.25 + +#define GEN_TEST_BIT_PARALLEL_ASSIGN(size) \ + \ + struct parallel_access_lcore ## size \ + { \ + unsigned int bit; \ + uint ## size ##_t *word; \ + bool failed; \ + }; \ + \ + static int \ + run_parallel_assign ## size(void *arg) \ + { \ + struct parallel_access_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + bool value = false; \ + \ + do { \ + bool new_value = rte_rand() & 1; \ + bool use_test_and_modify = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (rte_bit_atomic_test(lcore->word, lcore->bit, \ + rte_memory_order_relaxed) != value) { \ + lcore->failed = true; \ + break; \ + } \ + \ + if (use_test_and_modify) { \ + bool old_value; \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else { \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + if (old_value != value) { \ + lcore->failed = true; \ + break; \ + } \ + } else { \ + if (use_assign) \ + rte_bit_atomic_assign(lcore->word, lcore->bit, \ + new_value, \ + rte_memory_order_relaxed); \ + else { \ + if (new_value) \ + rte_bit_atomic_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + else \ + rte_bit_atomic_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + } \ + \ + value = new_value; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_assign ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + struct parallel_access_lcore ## size lmain = { \ + .word = &word \ + }; \ + struct parallel_access_lcore ## size lworker = { \ + .word = &word \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + lmain.bit = rte_rand_max(size); \ + do { \ + lworker.bit = rte_rand_max(size); \ + } while (lworker.bit == lmain.bit); \ + \ + int rc = rte_eal_remote_launch(run_parallel_assign ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_assign ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \ + TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \ + "failed"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_ASSIGN(32) +GEN_TEST_BIT_PARALLEL_ASSIGN(64) + +#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size) \ + \ + struct parallel_test_and_set_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_test_and_modify ## size(void *arg) \ + { \ + struct parallel_test_and_set_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + bool old_value; \ + bool new_value = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + if (old_value != new_value) \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_test_and_modify ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_test_and_set_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_test_and_set_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_test_and_modify ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32) +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64) + +#define GEN_TEST_BIT_PARALLEL_FLIP(size) \ + \ + struct parallel_flip_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_flip ## size(void *arg) \ + { \ + struct parallel_flip_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + rte_bit_atomic_flip(lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_flip ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_flip_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_flip_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_flip ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_flip ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_FLIP(32) +GEN_TEST_BIT_PARALLEL_FLIP(64) + static uint32_t val32; static uint64_t val64; @@ -177,6 +478,16 @@ static struct unit_test_suite test_suite = { .unit_test_cases = { TEST_CASE(test_bit_access32), TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_access32), + TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_atomic_access32), + TEST_CASE(test_bit_atomic_access64), + TEST_CASE(test_bit_atomic_parallel_assign32), + TEST_CASE(test_bit_atomic_parallel_assign64), + TEST_CASE(test_bit_atomic_parallel_test_and_modify32), + TEST_CASE(test_bit_atomic_parallel_test_and_modify64), + TEST_CASE(test_bit_atomic_parallel_flip32), + TEST_CASE(test_bit_atomic_parallel_flip64), TEST_CASE(test_bit_relaxed_set), TEST_CASE(test_bit_relaxed_clear), TEST_CASE(test_bit_relaxed_test_set_clear), -- 2.34.1