From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74CC045778; Fri, 9 Aug 2024 12:08:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4684C42EEB; Fri, 9 Aug 2024 12:08:10 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64]) by mails.dpdk.org (Postfix) with ESMTP id 5062142EB8 for ; Fri, 9 Aug 2024 12:08:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tEo0OqYRSOZSQqh0KPDxRjdbg/HKWk0TS8Dy81m6ivf8HOSOW9lMRCzU7tIi3pG07awWyaaabhn2G+3CQ8T2xCl4ML83lPzD75/yyeINhtsITIb4fz+yvBgMFFYkwRy/DA6wCIUlcupez8SvlzgxMvuxWbh+CssCzkim/nI9e3RirMaTFmlYuYihRNCgb3gRF3An1mae9H/XS+rgNcbbRbaKqmIzEBMjdfT1V4MpN+yFTBtHrGqIHO547o2WL2lUUlcDHe+Lr2opBfJ4j3s3Zhu+AQ8xHNMX5AW1wlPI8hAN6U6l8gEx9UIOuuxXvFvxut/YkkYkXXxcz4xL/x/ZDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a5WMo7gTsm2Qr9ZTxjtFLLnl+2HwDjGCyFIPlASvPhI=; b=Kd3zEHhaF+ZcrgD48Kap4V6gpyY3xxAImHraK5iDkO5eY1PGt9ilLQcWhvwqeWDOjm1ftbyWWiupkbIItPNUq8jmpgintX3j49q44YyEC1QOa9ho5uhuiPddqcs0z9WkzRjybYKscHVUGDNFY/FD3A19JP7FhVlZ7FHdmVUFyj+KIbFaVOR+fuhHnFDs2MA3UCGC+xj7Ej6agFrq28r3Cx28X/UoX99EVm1n8AhR5QMci0HDT315XpPeHLgFFnLdbLq8Xaig/dqqPQbf37v85Wmo8lEMXradl1JMVZIggRUwzBE/duAmjYcE/UmHGHqz4T+nKgY4dg1GxxzjY/xZLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=arm.com smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a5WMo7gTsm2Qr9ZTxjtFLLnl+2HwDjGCyFIPlASvPhI=; b=ukXbFbn0cJb8LYKpqrgWZi1keMQ1HSJfm4qpL3QYoI8gq9vafUNL8vMOVgLHwVEGACt1vZRxUgujYxM8DA8P39JMJBEtMxAlamlS2fdaUkzdvmfvnEzw0Qa4dg2DxECNGvHWsMRXAYj3wJvc3hzT9KNvi9OuGAuXjoTb7qGvdhDJ+IZfOwCVqtNuxuYIx1SIv4nfmUg/noxHdcBWne3PTbtXd/1LW8ia0o4BOVZjUfVua03C4DElW3GDD7AV+aYuJIGjgvmBgHeZxsYPzdH8Y9V8/uQPs1ZqpjWeA4MIk1ZkRufsOKATzB7ULp2AmGmgfzzb3TVBisFkSDbqW0EXMQ== Received: from DUZPR01CA0087.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::18) by PR3PR07MB7052.eurprd07.prod.outlook.com (2603:10a6:102:7d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.13; Fri, 9 Aug 2024 10:08:04 +0000 Received: from DU6PEPF0000A7E2.eurprd02.prod.outlook.com (2603:10a6:10:46a:cafe::8f) by DUZPR01CA0087.outlook.office365.com (2603:10a6:10:46a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.14 via Frontend Transport; Fri, 9 Aug 2024 10:08:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DU6PEPF0000A7E2.mail.protection.outlook.com (10.167.8.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Fri, 9 Aug 2024 10:08:04 +0000 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.63) with Microsoft SMTP Server id 15.2.1544.11; Fri, 9 Aug 2024 12:08:03 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id C18821C006A; Fri, 9 Aug 2024 12:08:03 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Joyce Kong , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [PATCH v2 4/5] eal: add unit tests for atomic bit access functions Date: Fri, 9 Aug 2024 11:58:28 +0200 Message-ID: <20240809095829.589396-5-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240809095829.589396-1-mattias.ronnblom@ericsson.com> References: <20240809090439.589295-2-mattias.ronnblom@ericsson.com> <20240809095829.589396-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU6PEPF0000A7E2:EE_|PR3PR07MB7052:EE_ X-MS-Office365-Filtering-Correlation-Id: a73abc31-b097-4068-90bc-08dcb85b28b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Q3dsZFhZTHlYZkdhellHczlXQ2thcEpwWWxIOE9POFF4WUpuT0I4WkhWblRt?= =?utf-8?B?UU5YL3JMYU9iZjQwcTgyZ2lRMTV2ZW1acklkQnlEZkdCN2lwQ3lkUHZpdkRW?= =?utf-8?B?VWZGMVZrWU1LRzl4RlZJRWpwS1VIWk13Zy8xVE9GNmJDWGxDL2ZyN2N6UGVC?= =?utf-8?B?M0VLbDcxR3kvcmIvMGJlaG8wSUZXSDc1eWNqV0JPY2taemYwVDQ2UnFpRGFI?= =?utf-8?B?Z3BURnVjRlJXdWhkWnZlS1RNaDFjeStIaWo0UHVIOXo4U2FyMmNLZlJKeTAr?= =?utf-8?B?Q3JMRHdwaVlzTjMwZitPVVBQLzFuT216VFVMT3IrRWx2b0dRQy9aZ1JLVkFQ?= =?utf-8?B?Uk51U0RUZm43eDlRUWFtQndZNGxhS3R6UmdudS9ldTJHUkhUa0syZXdHMzV2?= =?utf-8?B?QVR1TTMvYUNFRDMyd2xVUHU5VHU1aTdsN2prL29Kelk5ZVhkR0RjR25weU5B?= =?utf-8?B?L2FRK3puZDJuZUUxeWYrREo2TmtYbHZjTTdoazB2ZDRKTWpnWFpCcjlkcFlK?= =?utf-8?B?bEZ4blhvS1g3V0FHM0czYkVqa1BkTlpkQ3RVOU1UYkRTN0RLTVVkSjY4L29Y?= =?utf-8?B?Q2FJOU02WUkwd1FTMER3QnhDbW1jUlZUVjlUQjJxd3NtNzdocHhDRlF1WTU1?= =?utf-8?B?UzZUN2ZYVkVwaTNsMGt3cHN0bVFIaEEwVWFvYVVBM25pN2drdTE1dlprZXhq?= =?utf-8?B?dVl4S2wyVFlTU1hXSGJlVTUyYURCeG9OUDR0SHhOYWhFVFA3MUFQSEFObDhs?= =?utf-8?B?VmIvWnVlb1U2SG14NnZGYmYyTEo2QWhDemVTclVyVDdRdllBSENURHYvakZL?= =?utf-8?B?Z25ITHY0azlNbTA4Tzd5akY5QTFHbVNFbWdXcm1YMzZwbWFSVVg1b0d1ckxq?= =?utf-8?B?UmpvbkpBUFk3YlFNaEszQkYvVnRLdm5DOVk4bEQxeXhqVGlsV2IwSllhay9y?= =?utf-8?B?Q0NHRHNaSmFsdVlXdG5zVWRWNThneit0QmNERSt5NTFlU1VFME9MblJyRGF6?= =?utf-8?B?ekQwd21Zd1FDcU50ZktvS1ZQN1RlampYWnk1U2VQZjlkOXphbGhHdG1iOGlm?= =?utf-8?B?N2szZE5hNkxEcmsxUGVXMkdzd25nVEdiY2Vzc2xnK0tYdmJuVTEzYktlVitW?= =?utf-8?B?MlU0TXBBNytTM24yRGJ0ejZEejJ0Q0ZzMWlJWE0wVVF5ZjFxOUFxTDFEWnl2?= =?utf-8?B?eHIyZnJ3aGFoZDgvaXhMNVR4SUJUTHAxZ2JxdFNycnlvNTNZb0F4cmRXOHpE?= =?utf-8?B?WVVtckxvZFdPb0VJWUZwSGZIRzAxTm4zcEZDaTNGaE9BSS9WYk1EbEc0cGRn?= =?utf-8?B?UFhPdXZ5RnFKZ1dkMVpGU0ZYN1dCeXp3Z29vOTZZZWUwU0g0dnJmcXVhdmpX?= =?utf-8?B?KzhHVTVSOEpNMmNLYzl0Mm1LK2kvNUNCazcwUXczYTNldGZQTW4vWktLWGV0?= =?utf-8?B?bXk2NE1qWTFIaWY5aExNMU9ONDcxUkl1bU9nNS9sT0M3UU92dmU5N1daU1J1?= =?utf-8?B?TVpJU2pnMk1VQTZuYmRqMnkwdWVaak9KdXN0NklydHlQYkliOXJqL0gvT3Nj?= =?utf-8?B?bWxqZ0RKZmJ6dDF3aHpZUllsaGRTQkQvUmlIU3FNeGtDOHpGNTNUcG5zcWZi?= =?utf-8?B?QTdFaEU5am1kVkVjYkRLVC9TRjZ2ODJiUk9qdm02RHpRNy9lemt5TEtrbFR0?= =?utf-8?B?dGxDU04zdjJGZUpnKzNTUFNPSVNIMHFWa0xENVhhK3lQQndGdU15QUIwN0pY?= =?utf-8?B?S1l5T0dMd3NaQTl5bnp5SkVjRHBydWs0TGpVZFdzSzhmcGVKMmMzb3ZZQjE3?= =?utf-8?B?MmNXcHNaYjhqODN2dXpydkgxMlhLdDhkYnlxY1V0MmgwMVN1cWFmYk1ycHlz?= =?utf-8?B?ZFZMcm5obG5KQ3N4OHVGZUJKb3EvU2pPR1p0NFBPZjJjMUQ3c3B4VEhzY0dl?= =?utf-8?Q?2BJnJVMKgtqU95JhkKVncKrODa1gbUKX?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2024 10:08:04.3508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a73abc31-b097-4068-90bc-08dcb85b28b5 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF0000A7E2.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR07MB7052 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --- app/test/test_bitops.c | 313 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 312 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index 322f58c066..b80216a0a1 100644 --- a/app/test/test_bitops.c +++ b/app/test/test_bitops.c @@ -3,10 +3,13 @@ * Copyright(c) 2024 Ericsson AB */ +#include #include -#include #include +#include +#include +#include #include #include "test.h" @@ -61,6 +64,304 @@ GEN_TEST_BIT_ACCESS(test_bit_access32, rte_bit_set, rte_bit_clear, GEN_TEST_BIT_ACCESS(test_bit_access64, rte_bit_set, rte_bit_clear, rte_bit_assign, rte_bit_flip, rte_bit_test, 64) +#define bit_atomic_set(addr, nr) \ + rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_clear(addr, nr) \ + rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_assign(addr, nr, value) \ + rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed) + +#define bit_atomic_flip(addr, nr) \ + rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_test(addr, nr) \ + rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 32) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 64) + +#define PARALLEL_TEST_RUNTIME 0.25 + +#define GEN_TEST_BIT_PARALLEL_ASSIGN(size) \ + \ + struct parallel_access_lcore ## size \ + { \ + unsigned int bit; \ + uint ## size ##_t *word; \ + bool failed; \ + }; \ + \ + static int \ + run_parallel_assign ## size(void *arg) \ + { \ + struct parallel_access_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + bool value = false; \ + \ + do { \ + bool new_value = rte_rand() & 1; \ + bool use_test_and_modify = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (rte_bit_atomic_test(lcore->word, lcore->bit, \ + rte_memory_order_relaxed) != value) { \ + lcore->failed = true; \ + break; \ + } \ + \ + if (use_test_and_modify) { \ + bool old_value; \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else { \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + if (old_value != value) { \ + lcore->failed = true; \ + break; \ + } \ + } else { \ + if (use_assign) \ + rte_bit_atomic_assign(lcore->word, lcore->bit, \ + new_value, \ + rte_memory_order_relaxed); \ + else { \ + if (new_value) \ + rte_bit_atomic_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + else \ + rte_bit_atomic_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + } \ + \ + value = new_value; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_assign ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + struct parallel_access_lcore ## size lmain = { \ + .word = &word \ + }; \ + struct parallel_access_lcore ## size lworker = { \ + .word = &word \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + lmain.bit = rte_rand_max(size); \ + do { \ + lworker.bit = rte_rand_max(size); \ + } while (lworker.bit == lmain.bit); \ + \ + int rc = rte_eal_remote_launch(run_parallel_assign ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_assign ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \ + TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \ + "failed"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_ASSIGN(32) +GEN_TEST_BIT_PARALLEL_ASSIGN(64) + +#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size) \ + \ + struct parallel_test_and_set_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_test_and_modify ## size(void *arg) \ + { \ + struct parallel_test_and_set_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + bool old_value; \ + bool new_value = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + if (old_value != new_value) \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_test_and_modify ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_test_and_set_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_test_and_set_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_test_and_modify ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32) +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64) + +#define GEN_TEST_BIT_PARALLEL_FLIP(size) \ + \ + struct parallel_flip_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_flip ## size(void *arg) \ + { \ + struct parallel_flip_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + rte_bit_atomic_flip(lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_flip ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_flip_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_flip_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_flip ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_flip ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_FLIP(32) +GEN_TEST_BIT_PARALLEL_FLIP(64) + static uint32_t val32; static uint64_t val64; @@ -177,6 +478,16 @@ static struct unit_test_suite test_suite = { .unit_test_cases = { TEST_CASE(test_bit_access32), TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_access32), + TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_atomic_access32), + TEST_CASE(test_bit_atomic_access64), + TEST_CASE(test_bit_atomic_parallel_assign32), + TEST_CASE(test_bit_atomic_parallel_assign64), + TEST_CASE(test_bit_atomic_parallel_test_and_modify32), + TEST_CASE(test_bit_atomic_parallel_test_and_modify64), + TEST_CASE(test_bit_atomic_parallel_flip32), + TEST_CASE(test_bit_atomic_parallel_flip64), TEST_CASE(test_bit_relaxed_set), TEST_CASE(test_bit_relaxed_clear), TEST_CASE(test_bit_relaxed_test_set_clear), -- 2.34.1