From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1313545775; Fri, 9 Aug 2024 09:23:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E50D8402A5; Fri, 9 Aug 2024 09:23:28 +0200 (CEST) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mails.dpdk.org (Postfix) with ESMTP id 8F48040279 for ; Fri, 9 Aug 2024 09:23:27 +0200 (CEST) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52f042c15e3so1500006e87.0 for ; Fri, 09 Aug 2024 00:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723188207; x=1723793007; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=bEmQG4R2I1HzAtA16VuPB3HIjQO0PWZhMcXr09w/n74=; b=bpbMrA50rFFRaUITM2Ww6NuQN1CRiPKBwppCZSg9s9sibnMONyTDuHV+T+rJKhPoD9 1nRnfwZ6KQSkBbUclXlsf/lI4AsLOORxZ0qSBIAvNKNYa07iCgA5YzPZxp4VZ46KXBYw C7b1VDZEqf5AYtBRZwWgJu+McSc+69XU3MApDEk0SejR0UQ7puENX3ewNDwU+2Isw9HV k1Vs96GegBx07xPoHC182vecX9eEftlysvzJv5oYK2x3FGBQTzXgtGSh7vYlfYKjGhCO uwaFeIBSz0xwUurvVEN+htK1tct8Co8Q3Swhrm777AARIj6tKW5ou4P3y29hzu1g8d+2 uNXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723188207; x=1723793007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bEmQG4R2I1HzAtA16VuPB3HIjQO0PWZhMcXr09w/n74=; b=JQB+6n02MV/OfNCyacvBEoslvX/R9TitLOGj3EnNjwDUQuvzGz0Hf2f0ozMA2JFNYg I4opaO8pI6eSQdNCqZ2wVe5npvu8nuKSxdxeGlTlbs3/Hkn3z3mRrtckWOSW1aSpvPE9 fJrK4nRby2/psZfcFwoG7GpTHyeJJOP8zyDv+XVaV7myeL0pc/Y5X6ZFTyhe0MlB8H/5 HWc2XZS5a/hhKGWH8h0eB3FwlJM34++thKYQ+wnY+4M4yL/7UwWJD6MJyZuP2w4ViY+0 OW8insLvakSHqmIV06PMXFzSvVIJZJLJyydpMOAbwrzgcpMPD8z9lMLvb1+iwfP5vkE0 wmrw== X-Gm-Message-State: AOJu0YzgwfKcXlhSXIdS7FiLRntS2SmX9pJp5CvOs6ad3g3oM7FfRDXP 0kZYQY72aVlqqxkPmjTE7N3vN72efevZWSFel7jjdaUuWbMDkQ5b X-Google-Smtp-Source: AGHT+IEsfTcfDLDk7ynGvwlwyaayNATw5AByYKhbPr/XMAl/jOcHwVNeCXKGNB7XeDDOEKPC3c88sw== X-Received: by 2002:a05:6512:39c4:b0:52e:fd50:fe5a with SMTP id 2adb3069b0e04-530e5dc6570mr1346053e87.24.1723188206283; Fri, 09 Aug 2024 00:23:26 -0700 (PDT) Received: from sovereign (broadband-109-173-110-33.ip.moscow.rt.ru. [109.173.110.33]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-530ea9c01f4sm211040e87.188.2024.08.09.00.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 00:23:25 -0700 (PDT) Date: Fri, 9 Aug 2024 10:23:24 +0300 From: Dmitry Kozlyuk To: Stephen Hemminger Cc: dev@dpdk.org, Tyler Retzlaff Subject: Re: [PATCH 2/5] Revert "test/alarm: disable bad time cases on Windows" Message-ID: <20240809102324.154920fc@sovereign> In-Reply-To: <20240808194756.167664-3-stephen@networkplumber.org> References: <20240808194756.167664-1-stephen@networkplumber.org> <20240808194756.167664-3-stephen@networkplumber.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2024-08-08 12:46 (UTC-0700), Stephen Hemminger: > This reverts commit a089d320338d708f5b7126dab5fd6861c82e6347. > > Windows EAL should have been fixed rather than papering over > the bug. Linux and FreeBSD alarm implementations use the same approach that limits possible timeout range in API. Test cases in question check that these values are rejected. Windows EAL can accept any values. I think the proper fix would be documenting Unix limitations at API level (it never worked the other way, so no real breakage), then adding the same checks to Windows EAL only for consistency.