From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF78E45775; Fri, 9 Aug 2024 09:33:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF587402A5; Fri, 9 Aug 2024 09:33:46 +0200 (CEST) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by mails.dpdk.org (Postfix) with ESMTP id 16EB140274 for ; Fri, 9 Aug 2024 09:33:46 +0200 (CEST) Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-52efa16aad9so2314054e87.0 for ; Fri, 09 Aug 2024 00:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723188825; x=1723793625; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xv/igysbH9XD6w6F49WpxKmw0dLZ/fxvhqtZuHWQZ9I=; b=bMXuYRay4Yb4cxYPF0kpzwbdRME9IUiI7L0wNouQI6LZiUfulcjzf80BT976NACYe5 jnbCJD8WjGhdfBycggI2xzB55QdaLONc3yolslWka6LiE9K4s3q7lXfdWWq0z7KPzA9j B7TTsbvBIu7fjLXlUTPDlo2HL8zop2vwmwhx5+0ZKw7Gc/7egpbrwan/F5I4v1208hZ+ bcKHrfIRqElIaxwu8fvA9JhNtMmbaE1RHMPgJnjsSVv1Rq4/ZmUZXJnrXVcfzQiuyOpC o0vMtcnHznGmDmESPlukmyGDuBnCe5LsK40pr9Q/5y644u5xkjOL2e58bIYIV+4WVA96 ydgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723188825; x=1723793625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xv/igysbH9XD6w6F49WpxKmw0dLZ/fxvhqtZuHWQZ9I=; b=n+nv/lyXT8c96ujsO92VzE0fEMTbhBSHqeNd9e3KOpbdxOpYhMHw1aBjrWXoN5/lM0 gxf2R3a0jPfqCOSTQa5LzsSIs+lTad0UElAX8NSZW1MB43DKmCq34RExbIkv74TqmLFR tUhvMJlrxiPIizE56Gt2B/7T63HjW/tExJq5BuDqi0os3N6t0zZqeyHwifPW7gLzuxt8 0wA/iGI/6TmtMZFtBz6kp0dc6hEWZKtNqF+Pvz3l2hDvW3hKGIxSGg0nEaPkT6lo+LUE IQxDKj/58WAqUUadVKDTnYLa3NoexvEYK3gzkb3OJ3DuaqM5syVeXrqpNIlNvgcFWI8n z44Q== X-Gm-Message-State: AOJu0YzohBEtfDTu/U1alaEK+N97pNrz7LAZGlohMjU6Q28v0x30PZeJ +N7gfoUIUYfJz3oEeNpuratvL7EBwbGlrN9LDHgeMthvy9guvmYc X-Google-Smtp-Source: AGHT+IFAyBSxQdQLkeJiqCC3ACqDEyCwUGekzE9GoztuDoxN2FN3CrRRBImyU4LmT2frkefJ4r2dRg== X-Received: by 2002:a05:6512:10c6:b0:52c:e07d:229c with SMTP id 2adb3069b0e04-530ee9843c7mr491367e87.22.1723188824906; Fri, 09 Aug 2024 00:33:44 -0700 (PDT) Received: from sovereign (broadband-109-173-110-33.ip.moscow.rt.ru. [109.173.110.33]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-530de4668c6sm890588e87.219.2024.08.09.00.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 00:33:44 -0700 (PDT) Date: Fri, 9 Aug 2024 10:33:43 +0300 From: Dmitry Kozlyuk To: Stephen Hemminger Cc: dev@dpdk.org, Tyler Retzlaff Subject: Re: [PATCH 2/5] Revert "test/alarm: disable bad time cases on Windows" Message-ID: <20240809103343.161734db@sovereign> In-Reply-To: <20240809102324.154920fc@sovereign> References: <20240808194756.167664-1-stephen@networkplumber.org> <20240808194756.167664-3-stephen@networkplumber.org> <20240809102324.154920fc@sovereign> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2024-08-09 10:23 (UTC+0300), Dmitry Kozlyuk: > 2024-08-08 12:46 (UTC-0700), Stephen Hemminger: > > This reverts commit a089d320338d708f5b7126dab5fd6861c82e6347. > > > > Windows EAL should have been fixed rather than papering over > > the bug. > > Linux and FreeBSD alarm implementations use the same approach > that limits possible timeout range in API. > Test cases in question check that these values are rejected. > Windows EAL can accept any values. > I think the proper fix would be documenting Unix limitations > at API level (it never worked the other way, so no real breakage), > then adding the same checks to Windows EAL only for consistency. Oops, I got patch 1/5 in email later somehow. It is doing just that. Sorry for the noise.