From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F7BD457A1; Mon, 12 Aug 2024 14:59:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB71B40698; Mon, 12 Aug 2024 14:59:14 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2084.outbound.protection.outlook.com [40.107.104.84]) by mails.dpdk.org (Postfix) with ESMTP id C214840695 for ; Mon, 12 Aug 2024 14:59:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P1nRFG3Uf88sPcf/WkaNH84tf4pDw18m1UlCxQg7RrpP1Z2MLv5jbE3NV2LJyYCdOwdAuWXHjQiwHKaVWkknzzWpCXZWMZuRYXnuVl50G7kYNL/NFzhRccLZu92H/meve63V5ZBsSScQGNXg9qj1fAD7Rn/WXIy1s9ZnSnq1qGWg0HAy9+EH8HDAPDHt3tCQ+fJLJ3/W6rigkE9ZhpGFpFPBet6n/I2OfRTL1Ge0EKWCKHQQ36v6fcgxwSVXcz7DIE9N0jWnR0ASXRJtg8hKnHlwfG3EHs2au+RaGAatCHPvdqDctnxQpmEVfm3fRMV47svZAfhPBr0r7ANwCJKZmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a5WMo7gTsm2Qr9ZTxjtFLLnl+2HwDjGCyFIPlASvPhI=; b=F2Lczouat2I08c9sbfL4Wom7Xe2O3M4islFyIm44vYDBOb58FqVPJjm2Ujh8dEtwvfdT8JJixrawpM9pded9lE54MrpgMWcY+x6UpEhvh3MG+M/xg5YA0KClTPlMuvYt6EZKKTkjwBpJrYqexXWC6O7jU3kSQ5ENE95o+gTlXcjX6AZgh7VxQS6AiTwoNFYN8rRbLaN/h1WkTzcB55+GT3QQ0uBvUErhFr9Sxp97lxVybcnjm629vnjvVpt0tZvTmFnNDJ788x9XpEyqtP8VuYcw7EazR2AAjzq2fpc82pfDK9+wC92V7pLLA9U1v+1ThXbe8Qks7Jh0eGOqsL47YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a5WMo7gTsm2Qr9ZTxjtFLLnl+2HwDjGCyFIPlASvPhI=; b=KiRtyBZZ/eNbea9zOAnrjAmQSiAk7M58E3EpGswLf3E2PJDEZzZB/FqPs9oZsmbhVzt4bja6EI8ysjc3h5LUf+Axx+1MVf283Na2ORmi1VpsiKEcHm1StTYFDlKgS+OKTI1Vm5GOpSsPFUAM7TR0rF2CrHgNFv22oLPp+XhxE4ep4DrwEHTMDBuyPnXm7ZrU20pnVz8SffdVsvqTMKzShasIVSc4zB/TnyZtDQLyJ/+/9EZVPjXosAekMGhxzSeJ2o9WNiIoFFkgV6Dumk2NYCYmobpQ9LsTpyAaLzf+KBQc3vzOUdTm3b5EGEB5RDNImloB2QArLpLqQ7Gy5ph1XA== Received: from AS4P189CA0015.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5d7::19) by PA4PR07MB7293.eurprd07.prod.outlook.com (2603:10a6:102:f6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 12:59:05 +0000 Received: from AM3PEPF0000A796.eurprd04.prod.outlook.com (2603:10a6:20b:5d7:cafe::6) by AS4P189CA0015.outlook.office365.com (2603:10a6:20b:5d7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20 via Frontend Transport; Mon, 12 Aug 2024 12:59:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AM3PEPF0000A796.mail.protection.outlook.com (10.167.16.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Mon, 12 Aug 2024 12:59:05 +0000 Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.62) with Microsoft SMTP Server id 15.2.1544.11; Mon, 12 Aug 2024 14:59:03 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id 26F9338007D; Mon, 12 Aug 2024 14:59:03 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Jack Bond-Preston , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [PATCH v3 4/5] eal: add unit tests for atomic bit access functions Date: Mon, 12 Aug 2024 14:49:29 +0200 Message-ID: <20240812124930.604796-5-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812124930.604796-1-mattias.ronnblom@ericsson.com> References: <20240809095829.589396-2-mattias.ronnblom@ericsson.com> <20240812124930.604796-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF0000A796:EE_|PA4PR07MB7293:EE_ X-MS-Office365-Filtering-Correlation-Id: 60315ba9-8964-422b-134a-08dcbace8bd8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a3huV0E4SVgrUDJibmlDZVNnd0ptU0hvdG0rRHRaQXN5REU2blBTSGkvTHRZ?= =?utf-8?B?dVRuMStCeE4rc3BJYWw3UjJUMG9wVkRvbHlKS3FhM2UxV09GRkJabGFuSnlj?= =?utf-8?B?d1NITFQxME1lcTRWRXZOL1N0cURHRDlwZmJJK1J5bHBlbDdiUGVKU21hK05S?= =?utf-8?B?Uml2dmcvd3pQdks2ZzN6WTNzdXU1YS90VDJKTDNuT2k1dTk1QXhjTzRtNTFW?= =?utf-8?B?Mkx6KzJzQ0grbjVlQ2FwbzRvUW1lQ25yNlRnN2FVbWwydVdrQUlKSmZhSW4x?= =?utf-8?B?TWRRMmFudFFFeFBEZUVlYmliTFViaXkxK003eDZoN3JEOVpEUjlHMnY5MThk?= =?utf-8?B?dVVXazhuSkVuVzA2VExBVnZaYzVqTnFIWmFORVVVcmxpNjZuNi82TkRmQTlZ?= =?utf-8?B?YnlmT3VjQ2pIclR0TkFmWUNucUZVTVV2aWFxTEFHcFg1OUFuS0ZIaFNKcVRR?= =?utf-8?B?eXRRVEs1djFWWUdjcWs2UkJJd3ZWcnBVVkxiNyt5cjVoNnE1VWtRTWlrQ0RD?= =?utf-8?B?OXZFdkR4WGMycU1PejlJR3FTOXJzWUJVZWQxQnNuVlNiU2t3T3V2VDlFSTBQ?= =?utf-8?B?YnZrb0YyVWl6aUNIaEJ5MitJWWx4bHNJRE1OV0JoUnZGOHdJL2FhYWg4YWd6?= =?utf-8?B?Z29WQ3pqb1d4bUNPLytEYWZNYjM4YmVJNU1Pbk8ybTdNdGJkRk1TTElLK0RL?= =?utf-8?B?QXlNS0ZoVk9udGx5VHU3bTdIa2JBRnRrTGdPRUhzRnN2dHRaUVFPZ2w4U2p3?= =?utf-8?B?aHNMV2Z3N0JtQ3BmLzBsM0Y1eFhGQ1ozVmFhU3BpcXdxVUV5eHB5d0lFLzBx?= =?utf-8?B?SDVVT3F3alZXY1Q4aUFsTzhrNU9TakRpTFhVcG9wWVlPQWtQVCsvUHNOanRi?= =?utf-8?B?VWgrTXJpN2xob08wdWZVcWE2Rlpob20veUd3VnlUdE9nanVsSUF0ZXpDcU1s?= =?utf-8?B?emRQOU1WSURSVmt1RnRZMHhZTExhYWNyRjB2SkF2MjRkUjNuMlAxUlJ1cDhB?= =?utf-8?B?aG1IRDRmb1dvNHFnMU9ES0tzNHdiVHZ6RkdGRS9TMEU1VkttMkczOFpldkF5?= =?utf-8?B?MlZCTXZBWUk1NXB2NzdOYkFtL3pyTmpYMm1GMlBObmRtdXFaL0tRWkViZ2h0?= =?utf-8?B?NHZ3SDg2UkE0YUlqenFBdVJ4WkVnUm9lRDZOajRncjVlY0NCM1FKQ1l3Nk1T?= =?utf-8?B?TWNPdHpTNVBaT25BdmlXcTRaaFdMQXVyOXVocXRDOUhzTHRMbFBkWTR0TSt5?= =?utf-8?B?b3l6OWpzdnppdlhzaVQ0WDJtWCtBaE5YTzk1clVGcXZteDE5R1JhUk45cjR3?= =?utf-8?B?QmEwQVlZUWpnNll4d3paZTVRRGlNanVVdmRoUGdidDNUQVlFVlBacHVWaFZn?= =?utf-8?B?cWtPU3hWZjVCeEdUbElHNk5jQVlDSnYxYzBVSU8vQml3ZUt3SDJKK3h3WGFL?= =?utf-8?B?RTJJNWxwN2xFcVV2czgrdVVRWG9YNXVYTFBVQTkzeUwvNHVnS0hheWdNY0p4?= =?utf-8?B?bGtSdVp4K0xUcVg1K0QvNUxPamEvb1QxYnc3dUJqWTV3eGpEQTZKcXNybVQy?= =?utf-8?B?VUkrc0lFc3dpRk5MdEg4SE9TTTU3NmRoNXZXdmVNUmI0ZFI2eGZ2eHdZVmFw?= =?utf-8?B?SDJ6R0ZBbStFTVJZZzVGVC8weThkSUxTQmVENnJwT2tzek9SbEJuYzBRdGs2?= =?utf-8?B?TitnWmJCMUxZeVRvQWt4MUtFK1IzcFpROW16R1ltek9nRk4ybHBsU2FSd1k3?= =?utf-8?B?QXdsb2MwRlo3aWxxbU0yRmhRM0JvSUhSM0twVU1Dbkh4b0dzNzMya0NOZ0xW?= =?utf-8?B?cXhEd0FQa2ptVVdZRVpITENYQ1RxNnA4ZDRyYmhtZ1JRQzNjSGhlZzlJWStW?= =?utf-8?B?SXlJY29IalVkbElKTEVibVh2VnpQWE1SN3hEdTc3S2NKV2c9PQ==?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:59:05.1522 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 60315ba9-8964-422b-134a-08dcbace8bd8 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A796.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR07MB7293 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --- app/test/test_bitops.c | 313 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 312 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index 322f58c066..b80216a0a1 100644 --- a/app/test/test_bitops.c +++ b/app/test/test_bitops.c @@ -3,10 +3,13 @@ * Copyright(c) 2024 Ericsson AB */ +#include #include -#include #include +#include +#include +#include #include #include "test.h" @@ -61,6 +64,304 @@ GEN_TEST_BIT_ACCESS(test_bit_access32, rte_bit_set, rte_bit_clear, GEN_TEST_BIT_ACCESS(test_bit_access64, rte_bit_set, rte_bit_clear, rte_bit_assign, rte_bit_flip, rte_bit_test, 64) +#define bit_atomic_set(addr, nr) \ + rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_clear(addr, nr) \ + rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_assign(addr, nr, value) \ + rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed) + +#define bit_atomic_flip(addr, nr) \ + rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_test(addr, nr) \ + rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 32) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 64) + +#define PARALLEL_TEST_RUNTIME 0.25 + +#define GEN_TEST_BIT_PARALLEL_ASSIGN(size) \ + \ + struct parallel_access_lcore ## size \ + { \ + unsigned int bit; \ + uint ## size ##_t *word; \ + bool failed; \ + }; \ + \ + static int \ + run_parallel_assign ## size(void *arg) \ + { \ + struct parallel_access_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + bool value = false; \ + \ + do { \ + bool new_value = rte_rand() & 1; \ + bool use_test_and_modify = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (rte_bit_atomic_test(lcore->word, lcore->bit, \ + rte_memory_order_relaxed) != value) { \ + lcore->failed = true; \ + break; \ + } \ + \ + if (use_test_and_modify) { \ + bool old_value; \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else { \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + if (old_value != value) { \ + lcore->failed = true; \ + break; \ + } \ + } else { \ + if (use_assign) \ + rte_bit_atomic_assign(lcore->word, lcore->bit, \ + new_value, \ + rte_memory_order_relaxed); \ + else { \ + if (new_value) \ + rte_bit_atomic_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + else \ + rte_bit_atomic_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + } \ + \ + value = new_value; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_assign ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + struct parallel_access_lcore ## size lmain = { \ + .word = &word \ + }; \ + struct parallel_access_lcore ## size lworker = { \ + .word = &word \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + lmain.bit = rte_rand_max(size); \ + do { \ + lworker.bit = rte_rand_max(size); \ + } while (lworker.bit == lmain.bit); \ + \ + int rc = rte_eal_remote_launch(run_parallel_assign ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_assign ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \ + TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \ + "failed"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_ASSIGN(32) +GEN_TEST_BIT_PARALLEL_ASSIGN(64) + +#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size) \ + \ + struct parallel_test_and_set_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_test_and_modify ## size(void *arg) \ + { \ + struct parallel_test_and_set_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + bool old_value; \ + bool new_value = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + if (old_value != new_value) \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_test_and_modify ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_test_and_set_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_test_and_set_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_test_and_modify ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32) +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64) + +#define GEN_TEST_BIT_PARALLEL_FLIP(size) \ + \ + struct parallel_flip_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_flip ## size(void *arg) \ + { \ + struct parallel_flip_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + rte_bit_atomic_flip(lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_flip ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_flip_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_flip_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_flip ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_flip ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_FLIP(32) +GEN_TEST_BIT_PARALLEL_FLIP(64) + static uint32_t val32; static uint64_t val64; @@ -177,6 +478,16 @@ static struct unit_test_suite test_suite = { .unit_test_cases = { TEST_CASE(test_bit_access32), TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_access32), + TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_atomic_access32), + TEST_CASE(test_bit_atomic_access64), + TEST_CASE(test_bit_atomic_parallel_assign32), + TEST_CASE(test_bit_atomic_parallel_assign64), + TEST_CASE(test_bit_atomic_parallel_test_and_modify32), + TEST_CASE(test_bit_atomic_parallel_test_and_modify64), + TEST_CASE(test_bit_atomic_parallel_flip32), + TEST_CASE(test_bit_atomic_parallel_flip64), TEST_CASE(test_bit_relaxed_set), TEST_CASE(test_bit_relaxed_clear), TEST_CASE(test_bit_relaxed_test_set_clear), -- 2.34.1