Re: [v1,1/5] raw/zxdh: introduce zxdh raw device driver

[<zhang.yong25@zte.com.cn>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1507 bytes --]

>> +struct zxdh_gdma_buff_desc {>> +    uint SrcAddr_L;>> +    uint DstAddr_L;>> +    uint Xpara;>> +    uint ZY_para;>> +    uint ZY_SrcStep;>> +    uint ZY_DstStep;>> +    uint ExtAddr;>> +    uint LLI_Addr_L;>> +    uint LLI_Addr_H;>> +    uint ChCont;>> +    uint LLI_User;>> +    uint ErrAddr;>> +    uint Control;>> +    uint SrcAddr_H;>> +    uint DstAddr_H;>> +    uint Reserved;>> +};>> +>Why is this driver using uint type?>It should be using datatypes with explicit size (like uint32_t) to>make sure it can be used on both 32 and 64 bit builds.

This was an oversight, I will fix it as suggested. 
Thanks


Original


From: StephenHemminger <stephen@networkplumber.org>
To: 张勇10313449;
Cc: dev@dpdk.org <dev@dpdk.org>;
Date: 2024年08月05日 23:46
Subject: Re: [v1,1/5] raw/zxdh: introduce zxdh raw device driver

On Mon,  5 Aug 2024 21:34:53 +0800
Yong Zhang <zhang.yong25@zte.com.cn> wrote:
 
> +struct zxdh_gdma_buff_desc {
> +    uint SrcAddr_L;
> +    uint DstAddr_L;
> +    uint Xpara;
> +    uint ZY_para;
> +    uint ZY_SrcStep;
> +    uint ZY_DstStep;
> +    uint ExtAddr;
> +    uint LLI_Addr_L;
> +    uint LLI_Addr_H;
> +    uint ChCont;
> +    uint LLI_User;
> +    uint ErrAddr;
> +    uint Control;
> +    uint SrcAddr_H;
> +    uint DstAddr_H;
> +    uint Reserved;
> +};
> +
 
Why is this driver using uint type?
It should be using datatypes with explicit size (like uint32_t) to
make sure it can be used on both 32 and 64 bit builds.

[-- Attachment #1.1.2: Type: text/html , Size: 11010 bytes --]