From: jspewock@iol.unh.edu
To: probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com,
npratte@iol.unh.edu, juraj.linkes@pantheon.tech,
wathsala.vithanage@arm.com, yoan.picchi@foss.arm.com,
thomas@monjalon.net, paul.szczepanek@arm.com,
Luca.Vizzarro@arm.com, alex.chapman@arm.com
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>
Subject: [PATCH v1 1/1] dts: add admin privileges to hugepage mounting
Date: Mon, 12 Aug 2024 11:04:21 -0400 [thread overview]
Message-ID: <20240812150421.31226-2-jspewock@iol.unh.edu> (raw)
In-Reply-To: <20240812150421.31226-1-jspewock@iol.unh.edu>
From: Jeremy Spewock <jspewock@iol.unh.edu>
There were two different commands in the hugepage mounting process that
were not using super-user privileges; one for unmounting hugepages and
another for re-mounting them. This patch adds the flag that enables
enhanced permissions for both of these actions.
Bugzilla ID: 1439
Fixes: b8bdc4c58f57 ("dts: replace pexpect with fabric")
Cc: juraj.linkes@pantheon.tech
Signed-off-by: Jeremy Spewock <jspewock@iol.unh.edu>
---
dts/framework/testbed_model/linux_session.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dts/framework/testbed_model/linux_session.py b/dts/framework/testbed_model/linux_session.py
index 99abc21353..544a665b83 100644
--- a/dts/framework/testbed_model/linux_session.py
+++ b/dts/framework/testbed_model/linux_session.py
@@ -123,12 +123,12 @@ def _get_numa_nodes(self) -> list[int]:
def _mount_huge_pages(self) -> None:
self._logger.info("Re-mounting Hugepages.")
hugapge_fs_cmd = "awk '/hugetlbfs/ { print $2 }' /proc/mounts"
- self.send_command(f"umount $({hugapge_fs_cmd})")
+ self.send_command(f"umount $({hugapge_fs_cmd})", privileged=True)
result = self.send_command(hugapge_fs_cmd)
if result.stdout == "":
remote_mount_path = "/mnt/huge"
- self.send_command(f"mkdir -p {remote_mount_path}")
- self.send_command(f"mount -t hugetlbfs nodev {remote_mount_path}")
+ self.send_command(f"mkdir -p {remote_mount_path}", privileged=True)
+ self.send_command(f"mount -t hugetlbfs nodev {remote_mount_path}", privileged=True)
def _supports_numa(self) -> bool:
# the system supports numa if self._numa_nodes is non-empty and there are more
--
2.45.2
next prev parent reply other threads:[~2024-08-12 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 15:04 [PATCH v1 0/1] dts: fix " jspewock
2024-08-12 15:04 ` jspewock [this message]
2024-08-12 15:17 ` [PATCH v1 1/1] dts: add admin privileges to " Nicholas Pratte
2024-09-09 15:44 ` Luca Vizzarro
2024-09-09 15:48 ` Juraj Linkeš
2024-09-09 8:23 ` [PATCH v1 0/1] dts: fix " Juraj Linkeš
2024-09-09 15:52 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812150421.31226-2-jspewock@iol.unh.edu \
--to=jspewock@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Luca.Vizzarro@arm.com \
--cc=alex.chapman@arm.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).