From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6A5545823; Tue, 20 Aug 2024 17:52:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BF6E406B7; Tue, 20 Aug 2024 17:52:10 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 7FA344025F for ; Tue, 20 Aug 2024 17:52:09 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7141b04e7b5so291561b3a.2 for ; Tue, 20 Aug 2024 08:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1724169128; x=1724773928; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=90Jf1ffY0Tj9CXEcTIQCBI/k/s6x+xC9uL+HNlo22xE=; b=25TtQr8pZ48EX07OYsndpF63LppyTQj+KA0Paoh0iFlkkAjMrbDT9ipVnAFkiI3yKm cdYEUGOyPJoP9Kzgkkr/Au0XrVo7XcLWngOJKoY4FDrZMpkB9O3nBTADNkwe+YXuBBZ9 g7ZuCRDpflg2jmuOEmCDemV4cNsrDT5By9wl9Bm7eQqzWN+R+VtZp+/oxv008xN3dy1S ElvSbn9CYlcQY5pyx3fubKGWbxWaqIIuaf27uyEQigSS01+d5F5upB+hX0wO5mPWW4+o N7g0Oegpc6UedXqAZmoJ6p5FZ8u032PufDTP4xosY+u/V/NDhgPaJemIwnFMIbhBt9Ya /LBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724169128; x=1724773928; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=90Jf1ffY0Tj9CXEcTIQCBI/k/s6x+xC9uL+HNlo22xE=; b=vJzuAYlk+DHR/zq7ZTb5s7+eY/0BSZAQz1vHWueraJ2hgQ1x0+EVpyLtvQkUHyQBMa llBRF8FQaMuFu+qCHgr5k1ZyNJIFRSloYXa0FnHPKDJGUf9Uo7utCNsGftk8VWTpK3Yd q86cv+s4pKIa6ZDYi9a9LrNSf2EQGo2COenrKftHY2VHEfFw8aEiWIc/0SNGv9vY5ea1 NgokYm+F07icu6NsXDWZFreqeSmDLr0yK2c8ufXtWd225pvFpN10i1M+hodOAxNrHieP XN2yeC9qnTlkBCP/y8IKk9we5WCtTiTCdVMcc3/t0hMZ8O/savEGmwg4um5wKZWTWMkK xkyw== X-Gm-Message-State: AOJu0YxJyzAhopDFENxNUeptSGUiCXp+14w8iizaW1/6Sw35uGDTCwOC 25f1BKf5ih5WNZXd1/Y8Djabg89pVHtSJyi0WsENkyNQemiT1CiKuHCzoc7U79U= X-Google-Smtp-Source: AGHT+IF+3swfUBY8E5FlXrkS1i9fNPIMr108ftXERZgUjyNTFlN7yerqQ5wUUD8uqAS26eAjwO4UXA== X-Received: by 2002:a05:6a21:3401:b0:1c9:a2ad:15a0 with SMTP id adf61e73a8af0-1cac8e186cdmr2785238637.4.1724169128198; Tue, 20 Aug 2024 08:52:08 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7127addea8asm8661190b3a.11.2024.08.20.08.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2024 08:52:07 -0700 (PDT) Date: Tue, 20 Aug 2024 08:52:05 -0700 From: Stephen Hemminger To: Anatoly Burakov Cc: dev@dpdk.org, Robin Jarry , bruce.richardson@intel.com Subject: Re: [PATCH v3 3/4] usertools/dpdk-hugepages.py: update coding style Message-ID: <20240820085205.37d25751@hermes.local> In-Reply-To: <1c9f589c434cfb91c53dae7528cfc165c976b0c6.1724168117.git.anatoly.burakov@intel.com> References: <1c9f589c434cfb91c53dae7528cfc165c976b0c6.1724168117.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 20 Aug 2024 16:35:16 +0100 Anatoly Burakov wrote: > Update coding style: > > - Make the code PEP-484 compliant > - Add more comments, improve readability, use f-strings everywhere > - Use quotes consistently > - Address all Python static analysis (e.g. mypy, pylint) warnings > - Improve error handling > - Refactor printing and sysfs/procfs access functions > - Sort output by NUMA node > > Signed-off-by: Anatoly Burakov Looks good, but not sure if always using single quote is really necessary. Many python programs seem to use either one indiscriminately. Acked-by: Stephen Hemminger