From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93AD545833; Wed, 21 Aug 2024 17:03:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A327D42707; Wed, 21 Aug 2024 17:03:00 +0200 (CEST) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mails.dpdk.org (Postfix) with ESMTP id 1D323410FA for ; Wed, 21 Aug 2024 17:02:58 +0200 (CEST) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5320d8155b4so8837329e87.3 for ; Wed, 21 Aug 2024 08:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1724252577; x=1724857377; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ycuNqxnvUPRpNUZkPZQzFAi4fZ2/m7dOlW6IELJsgt4=; b=fkkw5h9ZzAhklaxpvKKgzTFGKLH/znEWzPM0lS2QvnRsYwu0LE+n83Swa+S9eGhRmb WD4147cE9h1a3C45byZjsCSP1lTkRdQuCYZ8ddYabsxJBBWa7EgqmIQERnos9mjujg+v v+bjc6h2a2Xc9/6AFLxclTVHxkYS0LLuLkXt0uSV9cAF6uCMAso9eM4oXAfJRg4yy/UJ +4yje1HVzB+N4ov6wVRIN+x7nFUccwV/rGzUJ8ie5Z9W9jwl7kY10G5Vg2MEqs0fVc3X b/vDjWUMWIbWsLLKH9ILgDjRuB9GX9sKUW+HP4aBzoE+4d/YNimTZci7knhoXGDXrW4A sYsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724252577; x=1724857377; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ycuNqxnvUPRpNUZkPZQzFAi4fZ2/m7dOlW6IELJsgt4=; b=lvQaKYokmtU794jsZQBPqmR5igBWGSAhJtDHkxNOMQx8MJx5z37bEbCcYLmIViRpn2 MSnhWNt8phnOIJSN64Y6SXnLcSbcG/EPpEAXRNh0NyUMTxldphgl0oiSdGzrR2CR0jHT MyqF18enqHL3AwM0+Gd/W0B0+MmYXItaQJ/bTLzIDZmbpYF6BR86CyfRObEMyhgroFqz ITC2S4lCiJ2iAv/ubnPeljpKm+2CVrfYEdUfgjXivIHlhJ+wVpv/H2wjdaduMciW8aoY EIyzwwz09UlpzJSp5Sdfx0XSCKfMIoE7JxfAkkagbHnZ9YlEDZOPrSXLqzuYIyEcDNhH vpog== X-Gm-Message-State: AOJu0YwlTdEliI3MEMYK6J+aOHNNv4Yx6UhIRkx0mSrqHupYKR2rbFfg iI9YDAFe6yIjAeuyWJTljyOl6Ky381r1D397n9wn4Ay46f6Y7rCjAVjuaqnFGMY= X-Google-Smtp-Source: AGHT+IH6ZrorfXYkitTlAo4+6fb6SQHqjfUJSIp+nb3HJrj6OVUy5KdQ+lD+dIPWpifEIvm313QO0Q== X-Received: by 2002:a05:6512:1103:b0:52e:9c0a:3522 with SMTP id 2adb3069b0e04-533485988d0mr1827301e87.44.1724252577012; Wed, 21 Aug 2024 08:02:57 -0700 (PDT) Received: from localhost.localdomain ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a83838cef1esm914030766b.48.2024.08.21.08.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2024 08:02:56 -0700 (PDT) From: =?UTF-8?q?Juraj=20Linke=C5=A1?= To: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, dmarx@iol.unh.edu, alex.chapman@arm.com Cc: dev@dpdk.org, =?UTF-8?q?Juraj=20Linke=C5=A1?= , luca.vizzarro@arm.com Subject: [PATCH v19 1/5] dts: update params and parser docstrings Date: Wed, 21 Aug 2024 17:02:50 +0200 Message-Id: <20240821150254.158912-2-juraj.linkes@pantheon.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240821150254.158912-1-juraj.linkes@pantheon.tech> References: <20231115133606.42081-1-juraj.linkes@pantheon.tech> <20240821150254.158912-1-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Address a few errors reported by Sphinx when generating documentation: framework/params/__init__.py:docstring of framework.params.modify_str:3: WARNING: Inline interpreted text or phrase reference start-string without end-string. framework/params/eal.py:docstring of framework.params.eal.EalParams:35: WARNING: Definition list ends without a blank line; unexpected unindent. framework/params/types.py:docstring of framework.params.types:8: WARNING: Inline strong start-string without end-string. framework/params/types.py:docstring of framework.params.types:9: WARNING: Inline strong start-string without end-string. framework/parser.py:docstring of framework.parser.TextParser:33: ERROR: Unexpected indentation. framework/parser.py:docstring of framework.parser.TextParser:43: ERROR: Unexpected indentation. framework/parser.py:docstring of framework.parser.TextParser:49: ERROR: Unexpected indentation. framework/parser.py:docstring of framework.parser.TextParser.wrap:8: ERROR: Unexpected indentation. framework/parser.py:docstring of framework.parser.TextParser.wrap:9: WARNING: Block quote ends without a blank line; unexpected unindent. Fixes: 87ba4cdc0dbb ("dts: use Unpack for type checking and hinting") Fixes: d70159cb62f5 ("dts: add params manipulation module") Fixes: 967fc62b0a43 ("dts: refactor EAL parameters class") Fixes: 818fe14e3422 ("dts: add parsing utility module") Cc: luca.vizzarro@arm.com Signed-off-by: Juraj Linkeš Reviewed-by: Luca Vizzarro Reviewed-by: Jeremy Spewock --- dts/framework/params/__init__.py | 4 ++-- dts/framework/params/eal.py | 7 +++++-- dts/framework/params/types.py | 3 ++- dts/framework/parser.py | 4 ++-- 4 files changed, 11 insertions(+), 7 deletions(-) diff --git a/dts/framework/params/__init__.py b/dts/framework/params/__init__.py index 5a6fd93053..1ae227d7b4 100644 --- a/dts/framework/params/__init__.py +++ b/dts/framework/params/__init__.py @@ -53,9 +53,9 @@ def reduced_fn(value): def modify_str(*funcs: FnPtr) -> Callable[[T], T]: - """Class decorator modifying the ``__str__`` method with a function created from its arguments. + r"""Class decorator modifying the ``__str__`` method with a function created from its arguments. - The :attr:`FnPtr`s fed to the decorator are executed from left to right in the arguments list + The :attr:`FnPtr`\s fed to the decorator are executed from left to right in the arguments list order. Args: diff --git a/dts/framework/params/eal.py b/dts/framework/params/eal.py index 8d7766fefc..cf1594353a 100644 --- a/dts/framework/params/eal.py +++ b/dts/framework/params/eal.py @@ -26,13 +26,16 @@ class EalParams(Params): prefix: Set the file prefix string with which to start DPDK, e.g.: ``prefix="vf"``. no_pci: Switch to disable PCI bus, e.g.: ``no_pci=True``. vdevs: Virtual devices, e.g.:: + vdevs=[ VirtualDevice('net_ring0'), VirtualDevice('net_ring1') ] + ports: The list of ports to allow. - other_eal_param: user defined DPDK EAL parameters, e.g.: - ``other_eal_param='--single-file-segments'`` + other_eal_param: user defined DPDK EAL parameters, e.g.:: + + ``other_eal_param='--single-file-segments'`` """ lcore_list: LogicalCoreList | None = field(default=None, metadata=Params.short("l")) diff --git a/dts/framework/params/types.py b/dts/framework/params/types.py index e668f658d8..d77c4625fb 100644 --- a/dts/framework/params/types.py +++ b/dts/framework/params/types.py @@ -6,7 +6,8 @@ TypedDicts can be used in conjunction with Unpack and kwargs for type hinting on function calls. Example: - ..code:: python + .. code:: python + def create_testpmd(**kwargs: Unpack[TestPmdParamsDict]): params = TestPmdParams(**kwargs) """ diff --git a/dts/framework/parser.py b/dts/framework/parser.py index 741dfff821..7254c75b71 100644 --- a/dts/framework/parser.py +++ b/dts/framework/parser.py @@ -46,7 +46,7 @@ class TextParser(ABC): Example: The following example makes use of and demonstrates every parser function available: - ..code:: python + .. code:: python from dataclasses import dataclass, field from enum import Enum @@ -90,7 +90,7 @@ def wrap(parser_fn: ParserFn, wrapper_fn: Callable) -> ParserFn: """Makes a wrapped parser function. `parser_fn` is called and if a non-None value is returned, `wrapper_function` is called with - it. Otherwise the function returns early with None. In pseudo-code: + it. Otherwise the function returns early with None. In pseudo-code:: intermediate_value := parser_fn(input) if intermediary_value is None then -- 2.34.1