From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF4CC45834; Wed, 21 Aug 2024 18:25:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CBA6427A1; Wed, 21 Aug 2024 18:25:35 +0200 (CEST) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by mails.dpdk.org (Postfix) with ESMTP id 3D98042796 for ; Wed, 21 Aug 2024 18:25:33 +0200 (CEST) Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-44ff7cc5432so52228621cf.3 for ; Wed, 21 Aug 2024 09:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1724257532; x=1724862332; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uISKbo2u9+QxhFcT57uOrThwW9sIgFM4v/D7ACRmG14=; b=L3Na/3PQyjYNgdlXMNcoSte8+DCVd4NgK+gZJoCDTk2PntXCR2KCSgYnL1UY4RCWcF mryu3GbUtR33jYGazWx7naI07B5UZ3DvEukg+nXy+MJ2qEeK+xVy9v8zuC11gU9mILLC r4HIni2xhoi8zHahQtInpTsuxxUVzjvMratcY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724257532; x=1724862332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uISKbo2u9+QxhFcT57uOrThwW9sIgFM4v/D7ACRmG14=; b=jANnK3hpoh8SXz1E7lS2rzGYRxZzIcuS5WdIlVmTkRRlTJPAhU0U/4fk2HuaJXXN52 ooeAnI2rJLOO5ay29Z1P3/qVxzAAUclDQ9oPymBrrZ5mzO+cU13H9yw8IrlkU0PAol2e CnG3y3fwNTZIgc8S5mfxEwJX0RWtAzwQa8xAvH1GYUAxQX/1XPxliIOmGS7rWmXH2Ry1 pEpfmEK29IWq5H/QemaNLFI/xVh4WODTR6JZX1bA1yipzQW0KCoS89w1LsdkVQCVsnw6 /x9CO7pQHMjByWbmh6rHRQvnGEAqRBjfNNTeC3aSHJUh97AYFCPJko5cDxHjdYJhYa8U mr0A== X-Gm-Message-State: AOJu0YwiSNgiM4cKfkhlBLfxq3znlVvFbsbOF2OFMAcTf1eJ7q6wrGql tgAnQNfP1KLkbVx4saOomhp6b7ryXamS0mCoI+vEMa79GxJIVofiz6iviGfZT4E= X-Google-Smtp-Source: AGHT+IEU2wNvml1KuPla6hIvsEaQPCjLircB2iyk/Zq+pfRlZCjmi9q/2vB4lPiON+bYlD+QI3vx1g== X-Received: by 2002:a05:6214:588f:b0:6b5:65ab:e860 with SMTP id 6a1803df08f44-6c155d5eec3mr29673736d6.20.1724257532238; Wed, 21 Aug 2024 09:25:32 -0700 (PDT) Received: from dean-laptop.iol.unh.edu ([2606:4100:3880:1271:f9bd:24da:464d:6294]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bf6fef223csm63014796d6.122.2024.08.21.09.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2024 09:25:31 -0700 (PDT) From: Dean Marx To: probb@iol.unh.edu, npratte@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech Cc: dev@dpdk.org, Dean Marx Subject: [PATCH v2 1/2] dts: add csum HW offload to testpmd shell Date: Wed, 21 Aug 2024 12:25:49 -0400 Message-ID: <20240821162550.1163-2-dmarx@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240821162550.1163-1-dmarx@iol.unh.edu> References: <20240816142031.15150-1-dmarx@iol.unh.edu> <20240821162550.1163-1-dmarx@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org add csum_set_hw method to testpmd shell class. Port over set_verbose and port start/stop from queue start/stop suite. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 124 ++++++++++++++++++ 1 file changed, 124 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index 43e9f56517..be7cd16b96 100644 --- a/dts/framework/remote_session/testpmd_shell.py +++ b/dts/framework/remote_session/testpmd_shell.py @@ -334,6 +334,32 @@ def make_parser(cls) -> ParserFn: ) +class ChecksumOffloadOptions(Flag): + """Flag representing checksum hardware offload layer options.""" + + #: + ip = auto() + #: + udp = auto() + #: + tcp = auto() + #: + sctp = auto() + #: + outerip = auto() + #: + outerudp = auto() + + def __str__(self): + """String method for use in csum_set_hw.""" + if self == ChecksumOffloadOptions.outerip: + return "outer-ip" + elif self == ChecksumOffloadOptions.outerudp: + return "outer-udp" + else: + return f"{self.name}" + + class DeviceErrorHandlingMode(StrEnum): """Enum representing the device error handling mode.""" @@ -806,6 +832,104 @@ def show_port_stats(self, port_id: int) -> TestPmdPortStats: return TestPmdPortStats.parse(output) + def port_stop(self, port: int, verify: bool = True): + """Stop specified port. + + Args: + port: Specifies the port number to use, must be between 0-32. + verify: If :data:`True`, the output of the command is scanned + to ensure specified port is stopped. If not, it is considered + an error. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and the port + is not stopped. + """ + port_output = self.send_command(f"port stop {port}") + if verify: + if "Done" not in port_output: + self._logger.debug(f"Failed to stop port {port}: \n{port_output}") + raise InteractiveCommandExecutionError(f"Testpmd failed to stop port {port}.") + + def port_start(self, port: int, verify: bool = True): + """Start specified port. + + Args: + port: Specifies the port number to use, must be between 0-32. + verify: If :data:`True`, the output of the command is scanned + to ensure specified port is started. If not, it is considered + an error. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and the port + is not started. + """ + port_output = self.send_command(f"port start {port}") + if verify: + if "Done" not in port_output: + self._logger.debug(f"Failed to start port {port}: \n{port_output}") + raise InteractiveCommandExecutionError(f"Testpmd failed to start port {port}.") + + def csum_set_hw(self, layer: ChecksumOffloadOptions, port_id: int, verify: bool = True) -> None: + """Enables hardware checksum offloading on the specified layer. + + Args: + layer: The layer that checksum offloading should be enabled on. + options: tcp, ip, udp, sctp, outer-ip, outer-udp. + port_id: The port number to enable checksum offloading on, should be within 0-32. + verify: If :data:`True` the output of the command will be scanned in an attempt to + verify that checksum offloading was enabled on the port. + + Raises: + InteractiveCommandExecutionError: If checksum offload is not enabled successfully. + """ + csum_output = self.send_command(f"csum set {str(layer)} hw {port_id}") + if verify: + if "Bad arguments" in csum_output or f"Please stop port {port_id} first" in csum_output: + self._logger.debug(f"Failed to set csum hw mode on port {port_id}:\n{csum_output}") + raise InteractiveCommandExecutionError( + f"Failed to set csum hw mode on port {port_id}" + ) + if verify and f"checksum offload is not supported by port {port_id}" in csum_output: + self._logger.debug(f"Checksum {layer} offload is not supported:\n{csum_output}") + + success = False + if layer == ChecksumOffloadOptions.outerip: + if "Outer-Ip checksum offload is hw" in csum_output: + success = True + elif layer == ChecksumOffloadOptions.outerudp: + if "Outer-Udp checksum offload is hw" in csum_output: + success = True + else: + if f"{str(layer).upper} checksum offload is hw" in csum_output: + success = True + if not success and verify: + self._logger.debug(f"Failed to set csum hw mode on port {port_id}:\n{csum_output}") + + def set_verbose(self, level: int, verify: bool = True) -> None: + """Set debug verbosity level. + + Args: + level: + 0: silent except for error. + 1: fully verbose except for Tx packets. + 2: fully verbose except for Rx packets. + >2: fully verbose. + verify: if :data:`True` an additional command will be sent to verify that verbose level + is properly set. Defaults to :data:`True`. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and verbose level + is not correctly set. + """ + verbose_output = self.send_command(f"set verbose {level}") + if verify: + if "Change verbose level" not in verbose_output: + self._logger.debug(f"Failed to set verbose level to {level}: \n{verbose_output}") + raise InteractiveCommandExecutionError( + f"Testpmd failed to set verbose level to {level}." + ) + def _close(self) -> None: """Overrides :meth:`~.interactive_shell.close`.""" self.stop() -- 2.44.0