From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98CE545838; Wed, 21 Aug 2024 23:31:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10F9542E4C; Wed, 21 Aug 2024 23:31:13 +0200 (CEST) Received: from mail-io1-f99.google.com (mail-io1-f99.google.com [209.85.166.99]) by mails.dpdk.org (Postfix) with ESMTP id 1799542E47 for ; Wed, 21 Aug 2024 23:31:11 +0200 (CEST) Received: by mail-io1-f99.google.com with SMTP id ca18e2360f4ac-81f86fd93acso5906639f.1 for ; Wed, 21 Aug 2024 14:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1724275870; x=1724880670; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uJx0m/kGeb+KOPJAwB0kPUBYvSVqmOend5CoDhP1jOc=; b=Ls200T5St3JsPxyY9NQRp7uC9nsW+Km2xaw8I40h7j4vOaP8417AMLeOOcCJ+/YOLT jfOAJ/CWf7fzLLX8xBL1W86iST/8T7PigLCTBgW+LEcpXwWwEi+8rT7PKekv/eeWFQs6 SLIQXPlsK+skdUJ2wmYBkyUkB/2t0msG9+VTs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724275870; x=1724880670; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uJx0m/kGeb+KOPJAwB0kPUBYvSVqmOend5CoDhP1jOc=; b=LqcZglnw6msy0lTN4Qo61hIqGn55QYWqB72mh3n3z7XEBFTCYxFPvNNQEUXlR8CgAK RpgvTyNTj3IadkmTMXBzKXgsS6+y+XpXy9Gr3AUmrDBpwPVbyLwkSl5TA0fczUqA1CQT J4fGWfHoKT0hNiEJLP0SnhRQbXWm14IDlVNLfnieOa6S7LWN+9YFovbAr8yt9kKhssVU azDjlrAJVb+x3yMgoJjTFSn0z/MpbEr8TyulwZgCYr7s705up48+FPteaEztURbEEaUH BalQkIXMJCsVMznaKEdWpMGh5SBNl/Aedp5tL+F0ygHGv0abzNM0wBTcjhspjpYDiqha 2BVg== X-Gm-Message-State: AOJu0Yxl0CBoeMiILf0eByCZybQ+Je5L6i0KN32M8ZnJPh/iKwz6VwfH c1ASHnp9Bk0GgvrQw0Qi/JzHBdSg1fabGa2lBUZIs2AYPlvaxw1IoeBZFesEuTwG/CZ++RWFY2d ONS4vifFnubOAaakANwrN5zROjdOKLomYGBqNzlL69HK6/QWa X-Google-Smtp-Source: AGHT+IHzmMqWGH8rLDd3ZS1pSHJl5Eye5a97NK4GP4BHnCSvYLDN5H4erEK7r/l4+kvqnPX93ndOhGh5FHNV X-Received: by 2002:a05:6e02:2186:b0:399:4778:ccf1 with SMTP id e9e14a558f8ab-39d728cfc1amr6600945ab.13.1724275870424; Wed, 21 Aug 2024 14:31:10 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id 8926c6da1cb9f-4ce710d6e5bsm10404173.81.2024.08.21.14.31.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Aug 2024 14:31:10 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1257::1083]) by postal.iol.unh.edu (Postfix) with ESMTP id 3F51A605C351; Wed, 21 Aug 2024 17:31:09 -0400 (EDT) From: jspewock@iol.unh.edu To: Luca.Vizzarro@arm.com, thomas@monjalon.net, paul.szczepanek@arm.com, wathsala.vithanage@arm.com, probb@iol.unh.edu, yoan.picchi@foss.arm.com, juraj.linkes@pantheon.tech, Honnappa.Nagarahalli@arm.com, npratte@iol.unh.edu, alex.chapman@arm.com Cc: dev@dpdk.org, Jeremy Spewock Subject: [RFC PATCH v3 4/5] dts: add OS abstractions for creating virtual functions Date: Wed, 21 Aug 2024 17:30:41 -0400 Message-ID: <20240821213042.24814-5-jspewock@iol.unh.edu> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240821213042.24814-1-jspewock@iol.unh.edu> References: <20240821191557.18744-1-jspewock@iol.unh.edu> <20240821213042.24814-1-jspewock@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jeremy Spewock Virtual functions in the framework are created using SR-IOV. The process for doing this can vary depending on the operating system, so the commands to create VFs have to be abstracted into different classes based on the operating system. This patch adds the stubs for methods that create VFs and get the PCI addresses of all VFs on a port to the abstract class as well as a linux implementation for the methods. Bugzilla ID: 1500 Signed-off-by: Jeremy Spewock --- dts/framework/testbed_model/linux_session.py | 40 +++++++++++++++++++- dts/framework/testbed_model/os_session.py | 40 ++++++++++++++++++++ 2 files changed, 79 insertions(+), 1 deletion(-) diff --git a/dts/framework/testbed_model/linux_session.py b/dts/framework/testbed_model/linux_session.py index 99abc21353..738ddd7600 100644 --- a/dts/framework/testbed_model/linux_session.py +++ b/dts/framework/testbed_model/linux_session.py @@ -15,7 +15,11 @@ from typing_extensions import NotRequired -from framework.exception import ConfigurationError, RemoteCommandExecutionError +from framework.exception import ( + ConfigurationError, + InternalError, + RemoteCommandExecutionError, +) from framework.utils import expand_range from .cpu import LogicalCore @@ -210,3 +214,37 @@ def configure_ipv4_forwarding(self, enable: bool) -> None: """Overrides :meth:`~.os_session.OSSession.configure_ipv4_forwarding`.""" state = 1 if enable else 0 self.send_command(f"sysctl -w net.ipv4.ip_forward={state}", privileged=True) + + def set_num_virtual_functions(self, num: int, pf_port: Port) -> bool: + """Overrides :meth:`~.os_session.OSSession.set_num_virtual_functions`.""" + sys_bus_path = f"/sys/bus/pci/devices/{pf_port.pci}/sriov_numvfs".replace(":", "\\:") + curr_num_vfs = int(self.send_command(f"cat {sys_bus_path}").stdout) + if num > 0 and curr_num_vfs >= num: + self._logger.info( + f"{curr_num_vfs} VFs already configured on port {pf_port.identifier.pci} on node " + f"{pf_port.identifier.node}." + ) + return False + elif num > 0 and curr_num_vfs > 0: + self._logger.error( + f"Not enough VFs configured on port {pf_port.identifier.pci} on node " + f"{pf_port.identifier.node}. Need {num} but only {curr_num_vfs} are configured. " + "DTS is unable to modify number of preexisting VFs." + ) + raise InternalError("Failed to create VFs on port.") + self.send_command(f"echo {num} > {sys_bus_path}", privileged=True, verify=True) + return True + + def get_pci_addr_of_vfs(self, pf_port: Port) -> list[str]: + """Overrides :meth:`~.os_session.OSSession.get_pci_addr_of_vfs`.""" + sys_bus_path = f"/sys/bus/pci/devices/{pf_port.pci}".replace(":", "\\:") + curr_num_vfs = int(self.send_command(f"cat {sys_bus_path}/sriov_numvfs").stdout) + if curr_num_vfs > 0: + pci_addrs = self.send_command( + 'awk -F "PCI_SLOT_NAME=" "/PCI_SLOT_NAME=/ {print \\$2}" ' + + f"{sys_bus_path}/virtfn*/uevent", + privileged=True, + ) + return pci_addrs.stdout.splitlines() + else: + return [] diff --git a/dts/framework/testbed_model/os_session.py b/dts/framework/testbed_model/os_session.py index 79f56b289b..191fc3c0c8 100644 --- a/dts/framework/testbed_model/os_session.py +++ b/dts/framework/testbed_model/os_session.py @@ -395,3 +395,43 @@ def configure_ipv4_forwarding(self, enable: bool) -> None: Args: enable: If :data:`True`, enable the forwarding, otherwise disable it. """ + + @abstractmethod + def set_num_virtual_functions(self, num: int, pf_port: Port) -> bool: + """Update the number of virtual functions (VFs) on a port. + + It should be noted that, due to the nature of VFs, if there are already VFs that exist on + the physical function (PF) prior to calling this function, additional ones cannot be added. + The only way to add more VFs is to remove the existing and then set the desired amount. For + this reason, this method will handle creation in the following order: + + 1. Use existing VFs on the PF if the number of existing VFs is greater than or equal to + `num` + 2. Throw an exception noting that VFs cannot be created if the PF has some VFs already set + on it, but the total VFs that it has are less then `num`. + 3. Create `num` VFs on the PF if there are none on it already + + Args: + num: The number of VFs to set on the port. + pf_port: The port to add the VFs to. + + Raises: + InternalError: If `pf_port` has less than `num` VFs configured on it + already. + + Returns: + :data:`True` if this method successfully created VFs, :data:`False` if existing VFs + were used instead. + """ + + @abstractmethod + def get_pci_addr_of_vfs(self, pf_port: Port) -> list[str]: + """Find the PCI addresses of all virtual functions (VFs) on the port `pf_port`. + + Args: + pf_port: The port to find the VFs on. + + Returns: + A list containing all of the PCI addresses of the VFs on the port. If the port has no + VFs then the list will be empty. + """ -- 2.46.0