From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 596E04586D; Mon, 26 Aug 2024 17:26:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3EBB4060C; Mon, 26 Aug 2024 17:26:27 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id CBC504003C for ; Mon, 26 Aug 2024 17:26:25 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2025031eb60so37947285ad.3 for ; Mon, 26 Aug 2024 08:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1724685985; x=1725290785; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OPVW7x55jUxtCeHC1wOywILgob4WEs1wcu42XRECVm0=; b=nX9jYL6Bi7VVlocnLsJ8qBTI0TjAej12y2VKD00pM1oU4kcn3CzmCr/XQSJMhcDhSI oZoqdCHHHQ8O1Bm3BLKiX12rztSSGgKSCBk/m04+T6S6GhEAty6aUKNwiHQfIW/0Tquc KIptkPI3yPXwI5YtWilYuiY8p+mdaD2PcxcZD0sCsywniEzLrokAum7AfifPn1ByP6pB re77BOt/5h3kw5eZGxH0vNNvyMIjM0gsNT1Rur5Jy7NsSJqWceJpLhspx5HnXghSd5Gj TMmUD9wUQAJIl3OkaXZ09sjgREQ5nCicB3NtP28ewTicooz+WS95KTeB1l0PveSu1jOd AjaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724685985; x=1725290785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OPVW7x55jUxtCeHC1wOywILgob4WEs1wcu42XRECVm0=; b=FFjIcHxxxekmYMB6zdq48r9P3IfbvzeiyBR/jABKPYVNn+hpdT3IX20OEGMWghSmWh GHq8YM3Q88oOJGGUoJgj30filZdDbMfXt8YPoPo7UDox5vngqNXDu/M56StFbZVfrh0q kuG+i/pdVR+m7GdI305SGzuVFlYWSw/Aea4xF2IwrEQOoReLFAwIDJktNSI7Krb6+Ha2 oTl3GaUE4WREeNU+4WEwV9D5ES1lmuZLH0ulLq4OLYkL5pwt32JsUVnY2azt9ISbo5l0 ttb+Qv8Ymk+UpDLLhRFWqmuCmJj4DtoheWwsjWwBEcabZivcVgs6LIUWCUrokBx0RUk1 UDIw== X-Forwarded-Encrypted: i=1; AJvYcCXJI1bYm4C30HnkArmaT8IUas9qyDAETizVeXOnqkC+UbRKsyOPggyJbWKCnHsNmWUHDgQ=@dpdk.org X-Gm-Message-State: AOJu0YzQf76vtqPDSKoAlyO+AXI7LHsbOJkLpE1SSKxJCkkMiAH7s+RO g7riyNOHswtQld04YfPmyLoh2exB7tVyyl76CV+/O+NXEvb8PRs0QexubKSm0D4= X-Google-Smtp-Source: AGHT+IENP0UfU27taqt75Si8pXxYpRf3eQP9caXrZYHr57/57V9oFgwiAYPPKegvbQmUlUsIzAHOnQ== X-Received: by 2002:a17:902:e551:b0:1fb:8245:fdeb with SMTP id d9443c01a7336-2039e545164mr90744865ad.64.1724685984796; Mon, 26 Aug 2024 08:26:24 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-203859eecafsm68918095ad.238.2024.08.26.08.26.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 08:26:24 -0700 (PDT) Date: Mon, 26 Aug 2024 08:26:22 -0700 From: Stephen Hemminger To: Sivaprasad Tummala Cc: , , , , , , , , Subject: Re: [PATCH v2 1/4] power: refactor core power management library Message-ID: <20240826082622.643538f8@hermes.local> In-Reply-To: <20240826130650.320130-2-sivaprasad.tummala@amd.com> References: <20240720165030.246294-1-sivaprasad.tummala@amd.com> <20240826130650.320130-1-sivaprasad.tummala@amd.com> <20240826130650.320130-2-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 26 Aug 2024 13:06:46 +0000 Sivaprasad Tummala wrote: > +static struct rte_power_core_ops acpi_ops = { > + .name = "acpi", > + .init = power_acpi_cpufreq_init, > + .exit = power_acpi_cpufreq_exit, > + .check_env_support = power_acpi_cpufreq_check_supported, > + .get_avail_freqs = power_acpi_cpufreq_freqs, > + .get_freq = power_acpi_cpufreq_get_freq, > + .set_freq = power_acpi_cpufreq_set_freq, > + .freq_down = power_acpi_cpufreq_freq_down, > + .freq_up = power_acpi_cpufreq_freq_up, > + .freq_max = power_acpi_cpufreq_freq_max, > + .freq_min = power_acpi_cpufreq_freq_min, > + .turbo_status = power_acpi_turbo_status, > + .enable_turbo = power_acpi_enable_turbo, > + .disable_turbo = power_acpi_disable_turbo, > + .get_caps = power_acpi_get_capabilities > +}; > + Can this be made const? It is good for security and overall safety to have structures with function pointers marked const.