From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>
Subject: [PATCH v3] bus/fslmc/dpaa2: replace system("echo ...") with file i/o
Date: Mon, 26 Aug 2024 09:11:13 -0700 [thread overview]
Message-ID: <20240826161216.10135-1-stephen@networkplumber.org> (raw)
In-Reply-To: <20220602214957.150071-1-stephen@networkplumber.org>
Using system() is a bad idea in driver code because it introduces
a number of potential security issues. The codeql analysis tool
flags this a potential security issue.
Instead just use normal stdio to do the same thing.
Compile test only, do not have this hardware and therefore can
not test this.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
---
v3 - remove unneccessary pre-allocation of the line buffer
drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 32 +++++++++++++++---------
1 file changed, 20 insertions(+), 12 deletions(-)
diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
index 4aec7b2cd8..d8a98326d9 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
@@ -125,12 +125,12 @@ static void
dpaa2_affine_dpio_intr_to_respective_core(int32_t dpio_id, int cpu_id)
{
#define STRING_LEN 28
-#define COMMAND_LEN 50
+#define AFFINITY_LEN 128
uint32_t cpu_mask = 1;
- int ret;
size_t len = 0;
char *temp = NULL, *token = NULL;
- char string[STRING_LEN], command[COMMAND_LEN];
+ char string[STRING_LEN];
+ char smp_affinity[AFFINITY_LEN];
FILE *file;
snprintf(string, STRING_LEN, "dpio.%d", dpio_id);
@@ -155,17 +155,25 @@ dpaa2_affine_dpio_intr_to_respective_core(int32_t dpio_id, int cpu_id)
}
cpu_mask = cpu_mask << cpu_id;
- snprintf(command, COMMAND_LEN, "echo %X > /proc/irq/%s/smp_affinity",
- cpu_mask, token);
- ret = system(command);
- if (ret < 0)
- DPAA2_BUS_DEBUG(
- "Failed to affine interrupts on respective core");
- else
- DPAA2_BUS_DEBUG(" %s command is executed", command);
-
+ snprintf(smp_affinity, AFFINITY_LEN, "/proc/irq/%s/smp_affinity", token);
free(temp);
fclose(file);
+
+ file = fopen(smp_affinity, "w");
+ if (file == NULL) {
+ DPAA2_BUS_WARN("Failed to open %s", smp_affinity);
+ return;
+ }
+ fprintf(file, "%X\n", cpu_mask);
+ fflush(file);
+
+ if (ferror(file)) {
+ fclose(file);
+ DPAA2_BUS_WARN("Failed to write to %s", smp_affinity);
+ return;
+ }
+
+ fclose(file);
}
static int dpaa2_dpio_intr_init(struct dpaa2_dpio_dev *dpio_dev)
--
2.43.0
next prev parent reply other threads:[~2024-08-26 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 21:49 [RFC] dpaa2: " Stephen Hemminger
2023-05-02 9:54 ` [v2] " Sachin Saxena (OSS)
2023-05-04 7:36 ` Mattias Rönnblom
2024-08-26 16:11 ` Stephen Hemminger [this message]
2024-10-17 16:15 ` [PATCH v3] bus/fslmc/dpaa2: " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826161216.10135-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=sachin.saxena@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).