[PATCH v2 0/1] bbdev: removing unnecessaray symbols

[PATCH v2 0/1] bbdev: removing unnecessaray symbols

[Nicolas Chautru]

v2: Actually several functions can be removed from bbdev version map
since they are inline and hence ABI versionning is not relevant.
I checked with other lib (cryptodev/ethdev) and the same guideline
is followed, with inline functions not part of version.map. Similarly
the script as part of CICD do no enforce versionning for inline
functions either. Discussed a bitwith Maxime off list. 
Any thoughts? Good to clean it up now. 

v1: A few functions were somehow missing for the last few years
in the version map file.


Nicolas Chautru (1):
  bbdev: removing unnecessaray symbols from version map

 lib/bbdev/rte_bbdev.h    |  1 -
 lib/bbdev/rte_bbdev_op.h |  2 --
 lib/bbdev/version.map    | 24 +-----------------------
 3 files changed, 1 insertion(+), 26 deletions(-)

-- 
2.34.1

[PATCH v2 1/1] bbdev: removing unnecessaray symbols from version map

[Nicolas Chautru]

A number of inline functions should not be in the
version map since ABI versionning would be irrelevant.

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 lib/bbdev/rte_bbdev.h    |  1 -
 lib/bbdev/rte_bbdev_op.h |  2 --
 lib/bbdev/version.map    | 24 +-----------------------
 3 files changed, 1 insertion(+), 26 deletions(-)

diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h
index 25514c58ac..bd49a0a304 100644
--- a/lib/bbdev/rte_bbdev.h
+++ b/lib/bbdev/rte_bbdev.h
@@ -897,7 +897,6 @@ rte_bbdev_dequeue_fft_ops(uint16_t dev_id, uint16_t queue_id,
  *   The number of operations actually dequeued (this is the number of entries
  *   copied into the @p ops array).
  */
-__rte_experimental
 static inline uint16_t
 rte_bbdev_dequeue_mldts_ops(uint16_t dev_id, uint16_t queue_id,
 		struct rte_bbdev_mldts_op **ops, uint16_t num_ops)
diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
index 459631d0d0..5b862c13a6 100644
--- a/lib/bbdev/rte_bbdev_op.h
+++ b/lib/bbdev/rte_bbdev_op.h
@@ -1159,7 +1159,6 @@ rte_bbdev_fft_op_alloc_bulk(struct rte_mempool *mempool,
  *   - 0 on success.
  *   - EINVAL if invalid mempool is provided.
  */
-__rte_experimental
 static inline int
 rte_bbdev_mldts_op_alloc_bulk(struct rte_mempool *mempool,
 		struct rte_bbdev_mldts_op **ops, uint16_t num_ops)
@@ -1236,7 +1235,6 @@ rte_bbdev_fft_op_free_bulk(struct rte_bbdev_fft_op **ops, unsigned int num_ops)
  * @param num_ops
  *   Number of structures
  */
-__rte_experimental
 static inline void
 rte_bbdev_mldts_op_free_bulk(struct rte_bbdev_mldts_op **ops, unsigned int num_ops)
 {
diff --git a/lib/bbdev/version.map b/lib/bbdev/version.map
index e0d82ff752..2a5baacd90 100644
--- a/lib/bbdev/version.map
+++ b/lib/bbdev/version.map
@@ -6,21 +6,9 @@ DPDK_25 {
 	rte_bbdev_callback_unregister;
 	rte_bbdev_close;
 	rte_bbdev_count;
-	rte_bbdev_dec_op_alloc_bulk;
-	rte_bbdev_dec_op_free_bulk;
-	rte_bbdev_dequeue_dec_ops;
-	rte_bbdev_dequeue_enc_ops;
-	rte_bbdev_dequeue_fft_ops;
 	rte_bbdev_device_status_str;
 	rte_bbdev_devices;
-	rte_bbdev_enc_op_alloc_bulk;
-	rte_bbdev_enc_op_free_bulk;
-	rte_bbdev_enqueue_dec_ops;
-	rte_bbdev_enqueue_enc_ops;
-	rte_bbdev_enqueue_fft_ops;
 	rte_bbdev_enqueue_status_str;
-	rte_bbdev_fft_op_alloc_bulk;
-	rte_bbdev_fft_op_free_bulk;
 	rte_bbdev_find_next;
 	rte_bbdev_get_named_dev;
 	rte_bbdev_info_get;
@@ -44,14 +32,4 @@ DPDK_25 {
 	rte_bbdev_stop;
 
 	local: *;
-};
-
-EXPERIMENTAL {
-	global:
-
-	# added in 23.11
-	rte_bbdev_dequeue_mldts_ops;
-	rte_bbdev_enqueue_mldts_ops;
-	rte_bbdev_mldts_op_alloc_bulk;
-	rte_bbdev_mldts_op_free_bulk;
-};
+};
\ No newline at end of file
-- 
2.34.1

Re: [PATCH v2 1/1] bbdev: removing unnecessaray symbols from version map

[Maxime Coquelin]

On 8/28/24 01:03, Nicolas Chautru wrote:
> A number of inline functions should not be in the
> version map since ABI versionning would be irrelevant.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   lib/bbdev/rte_bbdev.h    |  1 -
>   lib/bbdev/rte_bbdev_op.h |  2 --
>   lib/bbdev/version.map    | 24 +-----------------------
>   3 files changed, 1 insertion(+), 26 deletions(-)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime