From: Stephen Hemminger <stephen@networkplumber.org>
To: Stefan Laesser <stefan.laesser@omicronenergy.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"John W. Linville" <linville@tuxdriver.com>, <dev@dpdk.org>
Subject: Re: [PATCH] net/af_packet: add timestamp offloading support
Date: Tue, 3 Sep 2024 09:21:38 -0700 [thread overview]
Message-ID: <20240903092138.0e071924@hermes.local> (raw)
In-Reply-To: <20240903114306.2336633-1-stefan.laesser@omicronenergy.com>
On Tue, 3 Sep 2024 13:43:06 +0200
Stefan Laesser <stefan.laesser@omicronenergy.com> wrote:
> Add the packet timestamp from TPACKET_V2 to the mbuf
> dynamic rx timestamp register if offload RTE_ETH_RX_OFFLOAD_TIMESTAMP
> is enabled.
>
> TPACKET_V2 provides the timestamp with nanosecond resolution.
>
> Signed-off-by: Stefan Laesser <stefan.laesser@omicronenergy.com>
> ---
> .mailmap | 1 +
> doc/guides/nics/af_packet.rst | 8 ++++--
> drivers/net/af_packet/rte_eth_af_packet.c | 34 +++++++++++++++++++++--
> 3 files changed, 38 insertions(+), 5 deletions(-)
Adding timestamp is good, but it would be better if the timestamp
field was generic. The pcap PMD also has a timestamp, and pdump API
could/should use timestamp as well.
What makes sense is for there to be a standard dynamic field for
nanosecond resolution timestamp, and add a make sure that all drivers
use the same base 1/1/1970 same as Linux/Unix. Also, having
standard helpers in ethdev for the conversion from TSC to NS would
help.
next prev parent reply other threads:[~2024-09-03 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 11:43 Stefan Laesser
2024-09-03 16:21 ` Stephen Hemminger [this message]
2024-09-03 21:11 ` Morten Brørup
2024-09-06 6:22 ` Stefan Lässer
2024-09-06 8:13 ` Morten Brørup
2024-09-11 5:44 ` Stefan Lässer
2024-09-11 6:59 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903092138.0e071924@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
--cc=stefan.laesser@omicronenergy.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).