From: Stefan Laesser <stefan.laesser@omicronenergy.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"John W. Linville" <linville@tuxdriver.com>
Cc: <dev@dpdk.org>, Stefan Laesser <stefan.laesser@omicronenergy.com>
Subject: [PATCH] net/af_packet: add timestamp offloading support
Date: Tue, 3 Sep 2024 13:43:06 +0200 [thread overview]
Message-ID: <20240903114306.2336633-1-stefan.laesser@omicronenergy.com> (raw)
Add the packet timestamp from TPACKET_V2 to the mbuf
dynamic rx timestamp register if offload RTE_ETH_RX_OFFLOAD_TIMESTAMP
is enabled.
TPACKET_V2 provides the timestamp with nanosecond resolution.
Signed-off-by: Stefan Laesser <stefan.laesser@omicronenergy.com>
---
.mailmap | 1 +
doc/guides/nics/af_packet.rst | 8 ++++--
drivers/net/af_packet/rte_eth_af_packet.c | 34 +++++++++++++++++++++--
3 files changed, 38 insertions(+), 5 deletions(-)
diff --git a/.mailmap b/.mailmap
index 4a508bafad..69314e34a0 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1414,6 +1414,7 @@ Steeven Lee <steeven@gmail.com>
Steeven Li <steeven.li@broadcom.com>
Stefan Baranoff <sbaranoff@gmail.com>
Stefan Hajnoczi <stefanha@redhat.com>
+Stefan Laesser <stefan.laesser@omicronenergy.com>
Stefan Puiu <stefan.puiu@gmail.com>
Stefan Wegrzyn <stefan.wegrzyn@intel.com>
Stepan Sojka <stepan.sojka@adaptivemobile.com>
diff --git a/doc/guides/nics/af_packet.rst b/doc/guides/nics/af_packet.rst
index 66b977e1a2..e5da625e09 100644
--- a/doc/guides/nics/af_packet.rst
+++ b/doc/guides/nics/af_packet.rst
@@ -69,6 +69,8 @@ framecnt=512):
Features and Limitations
------------------------
-The PMD will re-insert the VLAN tag transparently to the packet if the kernel
-strips it, as long as the ``RTE_ETH_RX_OFFLOAD_VLAN_STRIP`` is not enabled by the
-application.
+* The PMD will re-insert the VLAN tag transparently to the packet if the kernel
+ strips it, as long as the ``RTE_ETH_RX_OFFLOAD_VLAN_STRIP`` is not enabled by the
+ application.
+* The PMD will add the kernel packet timestamp with nanoseconds resolution if
+ ``RTE_ETH_RX_OFFLOAD_TIMESTAMP`` is enabled.
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
index 6b7b16f348..6a7d5d0ffb 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -40,6 +40,9 @@
#define DFLT_FRAME_SIZE (1 << 11)
#define DFLT_FRAME_COUNT (1 << 9)
+uint64_t af_packet_timestamp_dynflag;
+int af_packet_timestamp_dynfield_offset = -1;
+
struct __rte_cache_aligned pkt_rx_queue {
int sockfd;
@@ -51,6 +54,7 @@ struct __rte_cache_aligned pkt_rx_queue {
struct rte_mempool *mb_pool;
uint16_t in_port;
uint8_t vlan_strip;
+ uint8_t timestamp_offloading;
volatile unsigned long rx_pkts;
volatile unsigned long rx_bytes;
@@ -82,6 +86,7 @@ struct pmd_internals {
struct pkt_rx_queue *rx_queue;
struct pkt_tx_queue *tx_queue;
uint8_t vlan_strip;
+ uint8_t timestamp_offloading;
};
static const char *valid_arguments[] = {
@@ -157,6 +162,16 @@ eth_af_packet_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
PMD_LOG(ERR, "Failed to reinsert VLAN tag");
}
+ /* add kernel provided timestamp when offloading is enabled */
+ if (pkt_q->timestamp_offloading) {
+ /* since TPACKET_V2 timestamps are provided in nanoseconds resolution */
+ *RTE_MBUF_DYNFIELD(mbuf, af_packet_timestamp_dynfield_offset,
+ rte_mbuf_timestamp_t *) =
+ (uint64_t)ppd->tp_sec * 1000000000 + ppd->tp_nsec;
+
+ mbuf->ol_flags |= af_packet_timestamp_dynflag;
+ }
+
/* release incoming frame and advance ring buffer */
ppd->tp_status = TP_STATUS_KERNEL;
if (++framenum >= framecount)
@@ -315,13 +330,25 @@ static int
eth_dev_start(struct rte_eth_dev *dev)
{
struct pmd_internals *internals = dev->data->dev_private;
- uint16_t i;
+
+ if (internals->timestamp_offloading) {
+ /* Register mbuf field and flag for Rx timestamp */
+ int rc = rte_mbuf_dyn_rx_timestamp_register(&af_packet_timestamp_dynfield_offset,
+ &af_packet_timestamp_dynflag);
+ if (rc) {
+ PMD_LOG(ERR, "Cannot register mbuf field/flag for timestamp");
+ return rc;
+ }
+ }
dev->data->dev_link.link_status = RTE_ETH_LINK_UP;
+
+ uint16_t i;
for (i = 0; i < internals->nb_queues; i++) {
dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
}
+
return 0;
}
@@ -365,6 +392,7 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
struct pmd_internals *internals = dev->data->dev_private;
internals->vlan_strip = !!(rxmode->offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP);
+ internals->timestamp_offloading = !!(rxmode->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP);
return 0;
}
@@ -381,7 +409,8 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
dev_info->min_rx_bufsize = 0;
dev_info->tx_offload_capa = RTE_ETH_TX_OFFLOAD_MULTI_SEGS |
RTE_ETH_TX_OFFLOAD_VLAN_INSERT;
- dev_info->rx_offload_capa = RTE_ETH_RX_OFFLOAD_VLAN_STRIP;
+ dev_info->rx_offload_capa = RTE_ETH_RX_OFFLOAD_VLAN_STRIP |
+ RTE_ETH_RX_OFFLOAD_TIMESTAMP;
return 0;
}
@@ -508,6 +537,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev,
dev->data->rx_queues[rx_queue_id] = pkt_q;
pkt_q->in_port = dev->data->port_id;
pkt_q->vlan_strip = internals->vlan_strip;
+ pkt_q->timestamp_offloading = internals->timestamp_offloading;
return 0;
}
--
2.34.1
next reply other threads:[~2024-09-03 11:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 11:43 Stefan Laesser [this message]
2024-09-03 16:21 ` Stephen Hemminger
2024-09-03 21:11 ` Morten Brørup
2024-09-06 6:22 ` Stefan Lässer
2024-09-06 8:13 ` Morten Brørup
2024-09-11 5:44 ` Stefan Lässer
2024-09-11 6:59 ` Morten Brørup
2024-09-20 6:48 ` Stefan Lässer
2024-09-20 6:44 ` [PATCH v2] " Stefan Laesser
2024-09-20 7:14 ` [PATCH v3] " Stefan Laesser
2024-09-20 14:29 ` Stephen Hemminger
2024-09-20 16:09 ` Morten Brørup
2024-09-22 3:06 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903114306.2336633-1-stefan.laesser@omicronenergy.com \
--to=stefan.laesser@omicronenergy.com \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).