From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C73204590E; Thu, 5 Sep 2024 17:07:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0980942EA0; Thu, 5 Sep 2024 17:07:32 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 6F399427E7 for ; Thu, 5 Sep 2024 17:07:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725548850; x=1757084850; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=nXPvhQE+jnlaIc7HRNT9Vd7+Wjf9T2VKVaNXY9xjamw=; b=HbTqLonvvhD6ox/z9QyLl9GKunJMnhUDIlrBmOgKJn4L5YAI6VtC/5XV kYe5zNy01WIHJ0N2CS9eB0HFtNHYMnW8OSOnsDpkAq9QDD4zCn24Qh4mI ZQC7hvxCABjA6GuCTlXrLSv8mVNSVpABRvp5idMku1W3og8oDpSkmhhkB siwu+SwJkUuSKgEc+3gdYh0dvJBQvQA4pib10fN8KPW0FcYafamc2r2rq 3KOaxefTWyumPRsJzZl1oraOowOTtOT3A4K3ja+Jqus9vpOjCDeMgATsw yai1kd5OkKhz8MlG+CacgK5b2pwgG6KpHk4eGeHsu+bx7vADR0QR51fU3 g==; X-CSE-ConnectionGUID: 9a9OIjlpT1Ke2+aldo8HdA== X-CSE-MsgGUID: HjXbm66vQAeNSS57/RK8hw== X-IronPort-AV: E=McAfee;i="6700,10204,11186"; a="27200008" X-IronPort-AV: E=Sophos;i="6.10,205,1719903600"; d="scan'208";a="27200008" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 08:07:30 -0700 X-CSE-ConnectionGUID: ur+9YZV7Rje7XW9zc9yHgw== X-CSE-MsgGUID: 8ik3dvpdTQ2tP19jV6HSMA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,205,1719903600"; d="scan'208";a="65311459" Received: from silpixa00400308.ir.intel.com ([10.237.214.154]) by fmviesa006.fm.intel.com with ESMTP; 05 Sep 2024 08:07:29 -0700 From: Arkadiusz Kusztal To: dev@dpdk.org Cc: kai.ji@intel.com, brian.dooley@intel.com, Arkadiusz Kusztal Subject: [PATCH 2/2] crypto/qat: fix thread-safety issue in the crc Date: Thu, 5 Sep 2024 16:07:22 +0100 Message-Id: <20240905150722.27789-2-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240905150722.27789-1-arkadiuszx.kusztal@intel.com> References: <20240905150722.27789-1-arkadiuszx.kusztal@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch fixes CRC thread-safety issue in the QAT PMD. Signed-off-by: Arkadiusz Kusztal --- drivers/crypto/qat/qat_sym.h | 3 +-- drivers/crypto/qat/qat_sym_session.c | 3 +++ drivers/crypto/qat/qat_sym_session.h | 2 ++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/qat_sym.h b/drivers/crypto/qat/qat_sym.h index eedf5de755..8db6044390 100644 --- a/drivers/crypto/qat/qat_sym.h +++ b/drivers/crypto/qat/qat_sym.h @@ -291,8 +291,7 @@ qat_crc_generate(struct qat_sym_session *ctx, crc_data = rte_pktmbuf_mtod_offset(sym_op->m_src, uint8_t *, sym_op->auth.data.offset); crc = (uint32_t *)(crc_data + crc_data_len); - *crc = rte_net_crc_calc(crc_data, crc_data_len, - RTE_NET_CRC32_ETH); + *crc = rte_net_crc(&ctx->crc, crc_data, crc_data_len); } } diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index eb267db424..828466edea 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -3176,6 +3176,9 @@ qat_sec_session_set_docsis_parameters(struct rte_cryptodev *dev, ret = qat_sym_session_configure_crc(dev, xform, session); if (ret < 0) return ret; + } else { + /* Initialize crc algorithm */ + session->crc = rte_net_crc_set(RTE_NET_CRC32_ETH, RTE_NET_CRC_AVX512); } qat_sym_session_finalize(session); diff --git a/drivers/crypto/qat/qat_sym_session.h b/drivers/crypto/qat/qat_sym_session.h index f2634774ec..680ac9126c 100644 --- a/drivers/crypto/qat/qat_sym_session.h +++ b/drivers/crypto/qat/qat_sym_session.h @@ -7,6 +7,7 @@ #include #include #include +#include #include "qat_common.h" #include "icp_qat_hw.h" @@ -150,6 +151,7 @@ struct qat_sym_session { uint8_t is_wireless; uint32_t slice_types; enum qat_sym_proto_flag qat_proto_flag; + struct rte_net_crc crc; qat_sym_build_request_t build_request[2]; #ifndef RTE_QAT_OPENSSL IMB_MGR *mb_mgr; -- 2.13.6