From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DEF34591D; Fri, 6 Sep 2024 12:22:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A79C742EE1; Fri, 6 Sep 2024 12:22:29 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2053.outbound.protection.outlook.com [40.107.96.53]) by mails.dpdk.org (Postfix) with ESMTP id C89A042EE1 for ; Fri, 6 Sep 2024 12:22:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VbIRnfvjZhr2amaQho/jDHTLnhTGi/m/F75/o5JzHvka93aun9k+B93OY8rqSX4E6M1ecVyBY/CTtdGTEDliUrg3C1ZmQ9b2NwfbtV5qj11gAQvEtYtXqGZH8SoZCCFo5uv5S7VDLebUM1HlSD8XgiXf3QTft6zxrLXbwbVbVQ677Dbh+NuVWDIeid3IooddEUZcc4pGbpOM+nK/wvRxjLGnXFMi+3LUdqU9iDzv098ap1d99uSVqTp/aaya+CAIjbjJ30QWsc75WcB4aha8gmYU927fIaWxzc2brlaxzIWvOk0+UJq/UeUWUxFHjs2ClVuoNtYdllaYWl2l678jiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Ds6GB8U3oA2nxPR6j332HuRHAHgh9+OUuxzXVGroHU=; b=HvTaIpZ+ItbfHl7653qNVTn6i6m7OhJbqLzDjjHl3bFOC069qciYvJEmavuSeUf3lZUhh7q+xfKLXL8EQCBIMBk2rTl6hfQP6FCwNYNn+O7D47OqBxBVELGSnLv5y2SC07nF++8Y2Wqifng/18VQv/gSzfhBCh8pbcVsI+s0lR6kq+QJ37jV6jwyqNI5OAuYfeezdG8n5AVC4fC/2ZchMuGoJPo0670ebb+I7iB2r3B2MlJk0gGVCqSm0t0HI8/1VJQflEKotiRocYnnnag2CWKDAg+875F+vZNJjc42jduPR5vUsbvalhkmjR3pAPKoOBsOSLvEqELJh0Yji+Bq7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Ds6GB8U3oA2nxPR6j332HuRHAHgh9+OUuxzXVGroHU=; b=PtHJ1ZtzZIXVZZPnj367fPIrQuNVHci1ZfHfCuO/Nq3TlXD+jctQrGV0qu7DgKifu3R5lF0TxgJK7nLkI6VT60GLk0xhEWrRWTLbJgeqmWPTOxjuJg2OxNFhPYWkwjuCtziwa7LSVuU3bDwiJ0JmIHcFyh71994B9mzKNV1NvXSSRj9mpS8vEmgpl3odcM+A0HrAPmNTVRq7VQKjvWIMZTmulCyJvnN7eMhQ68lsxDCp+/68ci22a+xU5c8mBUzPGrXogHcL1CY/NWn1nq7pBn3VXwhMxzv1jGqyJuaQSa5RXrTfUwOfBwixf/Cg/xkO99CdA8hTwsaRZx/hDcuYNQ== Received: from BY3PR10CA0022.namprd10.prod.outlook.com (2603:10b6:a03:255::27) by CY5PR12MB6105.namprd12.prod.outlook.com (2603:10b6:930:2a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.28; Fri, 6 Sep 2024 10:22:22 +0000 Received: from SJ5PEPF000001F0.namprd05.prod.outlook.com (2603:10b6:a03:255:cafe::95) by BY3PR10CA0022.outlook.office365.com (2603:10b6:a03:255::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.17 via Frontend Transport; Fri, 6 Sep 2024 10:22:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF000001F0.mail.protection.outlook.com (10.167.242.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Fri, 6 Sep 2024 10:22:21 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 6 Sep 2024 03:22:15 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 6 Sep 2024 03:22:11 -0700 From: Gavin Li To: , , , , Dariusz Sosnowski , Bing Zhao , Suanming Mou CC: , , "Minggang Li (Gavin)" , Alex Vesker Subject: [PATCH 2/3] net/mlx5/hws: add log for failing to create rule in HWS Date: Fri, 6 Sep 2024 13:21:50 +0300 Message-ID: <20240906102151.171965-3-gavinl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240906102151.171965-1-gavinl@nvidia.com> References: <20240906102151.171965-1-gavinl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F0:EE_|CY5PR12MB6105:EE_ X-MS-Office365-Filtering-Correlation-Id: 2907f55a-12e8-4bfc-d347-08dcce5dcb56 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?y0O76WIG/psgHaX2XSue402M+xVlRbe9OSlVZ9y9DitFSWStO5GS7xgYcPo4?= =?us-ascii?Q?RUkZ/bz/aJ0k/TOwqRIDkDbca//jTBBKkZnohhLdqO/fRn0yNiKHgwP0RDAX?= =?us-ascii?Q?7/wb4nLCL6wPrvdhsrltZ7PssOxV7XziA8OsSrCYlV52R0xbDdamKa0kOnNt?= =?us-ascii?Q?oETFvHvbA31pQ5esc6vXZkgcCcTl7KLcxVUndfkeoiinRYJs2jKjbXljK7ao?= =?us-ascii?Q?/DoX9J7pZXZ/lb/C70K/n0bcrLN+XdHgO1MjP2WrPxchVy3Eh7uySyZiZp2O?= =?us-ascii?Q?2R0Wu7hks+9YBg2CNTLg9sLZNTnqHbtJnG816qyVIeeeQ70l1lW1MFF3XIEZ?= =?us-ascii?Q?vVqydJkX6YrpkPCzBImiG5E4m+afI/OlmFj3YV3saRqeaaEsIOxstM2K4foS?= =?us-ascii?Q?zPI2HfHBoQzsu6ohtx/aCDeneDL9BX33NyQue4s6fqZHNviLWfwaMwWHOYln?= =?us-ascii?Q?yzYcjuDHAQ55hMMk1m53QRenL/oV/jrjn4lEqk+0R8qUCeyiyk1CTTV8uLLI?= =?us-ascii?Q?kPMFr+FhoAeqJ5Zh1Zqe6tbVUS4YIm0OLyVXozVqTfrr3oO/dVt6ArwUjLM9?= =?us-ascii?Q?w4IzpqszmFzEb3oEHKII7iE55OUDSFwjOhjLVUsFBW/7GQ0ebRqUzpkQXvMc?= =?us-ascii?Q?L1RU21J+uhokCVsC/73AUgZblkddKoDjVqb5ZXlYI4Fty+bAUePt//5T45z/?= =?us-ascii?Q?UOO8ppKeZ+25+8EbMv3HmpOzTMzJLA3Ko43gX2/F1H24k3PyVvlKL0OnUqDu?= =?us-ascii?Q?4v6m8yQraDIheuUvFcJxSB1YizSsuujo4aw5FfyudzTnf16DOqLRxZ7xz3CT?= =?us-ascii?Q?O5jYHqCK3UVS1uU2jtddmZM4xVdtnYjk1DhVRwbip1+Ap/thvhCx6uzdA5Yk?= =?us-ascii?Q?e/kc1K+ODoZgLZ0+vB/H71Ns94rjZ7BHVq1TSTVUhLSa0tf4PWV8FZfD55tg?= =?us-ascii?Q?pppMM/KcYnsqIqEP5gSGBm5h/dJnWHJ3CQGx4Zx7v4G89Tj+plZXo8XKUnZ4?= =?us-ascii?Q?bj8edz2o0KDmz8ma5SjNoYJyr06U5nZC7Af//x+fZvNDhIfnqHBiEsmKlwlF?= =?us-ascii?Q?VhXxvWvg14h6HgUQc+dW9Zt10Ad6b41kkrQV9do9DRvWPEHHS0RvC0TTKbu3?= =?us-ascii?Q?2SfBiUbJKQNeTTJsyI2/J9apVgWs3W6LVg+DnHzrL2T9kXqXC5IuTcij4er7?= =?us-ascii?Q?sx8FiKg/MYDSBfDZkfbIfKCSSzk4Y8IoJb+HudXudhldhuVZ+XK0x7jW+nzJ?= =?us-ascii?Q?Pzwf1pD33xxyFxb7nhfuNmIO/m9HPY1brJA+dbYvh2KhHwqY9hkEXSrGuv17?= =?us-ascii?Q?UB+Q6Y51HDhbfZqAVgMMdsVTInLSHiWmCY7nY9TxzG/cb3YiCzAKivPiAnR3?= =?us-ascii?Q?UXOzEYebvHXXQVmpTcoo08/qOfGZ0f4aXOZfUBDCEu7sxL5MNiqkKp4Z9W59?= =?us-ascii?Q?QQaybz58y7HHRNvT+lQMdlpymsP1pAF4?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2024 10:22:21.8200 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2907f55a-12e8-4bfc-d347-08dcce5dcb56 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6105 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: "Minggang Li (Gavin)" Signed-off-by: Gavin Li Acked-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_rule.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index 1edb7eac74..5d66d81ea5 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -638,6 +638,7 @@ static int mlx5dr_rule_destroy_hws(struct mlx5dr_rule *rule, /* Rule is not completed yet */ if (rule->status == MLX5DR_RULE_STATUS_CREATING) { + DR_LOG(NOTICE, "Cannot destroy, rule creation still in progress"); rte_errno = EBUSY; return rte_errno; } @@ -806,12 +807,14 @@ static int mlx5dr_rule_enqueue_precheck(struct mlx5dr_rule *rule, struct mlx5dr_context *ctx = rule->matcher->tbl->ctx; if (unlikely(!attr->user_data)) { + DR_LOG(DEBUG, "User data must be provided for rule operations"); rte_errno = EINVAL; return rte_errno; } /* Check if there is room in queue */ if (unlikely(mlx5dr_send_engine_full(&ctx->send_queue[attr->queue_id]))) { + DR_LOG(NOTICE, "No room in queue[%d]", attr->queue_id); rte_errno = EBUSY; return rte_errno; } @@ -823,6 +826,7 @@ static int mlx5dr_rule_enqueue_precheck_move(struct mlx5dr_rule *rule, struct mlx5dr_rule_attr *attr) { if (unlikely(rule->status != MLX5DR_RULE_STATUS_CREATED)) { + DR_LOG(DEBUG, "Cannot move, rule status is invalid"); rte_errno = EINVAL; return rte_errno; } @@ -835,6 +839,7 @@ static int mlx5dr_rule_enqueue_precheck_create(struct mlx5dr_rule *rule, { if (unlikely(mlx5dr_matcher_is_in_resize(rule->matcher))) { /* Matcher in resize - new rules are not allowed */ + DR_LOG(NOTICE, "Resizing in progress, cannot create rule"); rte_errno = EAGAIN; return rte_errno; } @@ -1068,6 +1073,7 @@ int mlx5dr_rule_hash_calculate(struct mlx5dr_matcher *matcher, mlx5dr_table_is_root(matcher->tbl) || matcher->tbl->ctx->caps->access_index_mode == MLX5DR_MATCHER_INSERT_BY_HASH || matcher->tbl->ctx->caps->flow_table_hash_type != MLX5_FLOW_TABLE_HASH_TYPE_CRC32) { + DR_LOG(DEBUG, "Matcher is not supported"); rte_errno = ENOTSUP; return -rte_errno; } -- 2.34.1