From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA5614557F; Fri, 6 Sep 2024 15:28:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC67142F49; Fri, 6 Sep 2024 15:28:05 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 680B142EFA; Fri, 6 Sep 2024 15:28:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725629284; x=1757165284; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=oOc2G4s7xBUwHf3I/4u+qTCNAKjkVBDXSNQvNOdulbg=; b=i1a5RzIaAYc+xzT37hhb63+acwXjbHMKkc74xkv3lmxrTqm0kBWrgmOF 5GYF54cBBU6vtFBhc7Cb3HXUwXpJgTcu7d7KgTEjj7H53NwTkQ363Tadq niKFoNnJwCXGgPt+Tky4DKA2E3DhhSCrOipw542rScmt6xAScmJPqWx50 YPU3nm7nppwj8gLcH7MH2rig9EDUIKInSfXiW0Ly3l7T8UcVj+lme/4Ft vPvCKmaEy/S+I68BFNxL3O7cdg1c8tPQvruiNhmaybQHHugLL2+S9OBSo iQbJKA8tdgGKwpTPyhx6zZA3BWgvcnFWEUWvZb75Ahx4V97fFdA6EMyPy w==; X-CSE-ConnectionGUID: xPpCxz6VSge+M6haZ2kVsA== X-CSE-MsgGUID: YOxnO+dXSZeGbBYRsV++Og== X-IronPort-AV: E=McAfee;i="6700,10204,11187"; a="23893070" X-IronPort-AV: E=Sophos;i="6.10,207,1719903600"; d="scan'208";a="23893070" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2024 06:28:03 -0700 X-CSE-ConnectionGUID: R2yNvVcFTNSDI9i+KDwyEQ== X-CSE-MsgGUID: xr4bTCLmT/GBfW6s5yZo4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,207,1719903600"; d="scan'208";a="65993510" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.39]) by fmviesa008.fm.intel.com with ESMTP; 06 Sep 2024 06:28:02 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , radu.nicolau@intel.com, stable@dpdk.org Subject: [PATCH] eal/x86: fix 32-bit write-combined stores Date: Fri, 6 Sep 2024 14:27:57 +0100 Message-ID: <20240906132757.457921-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The "movdiri" instruction is given as a series of bytes in rte_io.h so that it works on compilers/assemblers which are unaware of the instruction. The REX prefix (0x40) on this instruction is invalid for 32-bit code, causing issues. Thankfully, the prefix is unnecessary in 64-bit code, since the data size used is 32-bits. Fixes: 8a00dfc738fe ("eal: add write combining store") Cc: radu.nicolau@intel.com Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/eal/x86/include/rte_io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/x86/include/rte_io.h b/lib/eal/x86/include/rte_io.h index 0e1fefdee1..5366e09c47 100644 --- a/lib/eal/x86/include/rte_io.h +++ b/lib/eal/x86/include/rte_io.h @@ -24,7 +24,7 @@ __rte_x86_movdiri(uint32_t value, volatile void *addr) { asm volatile( /* MOVDIRI */ - ".byte 0x40, 0x0f, 0x38, 0xf9, 0x02" + ".byte 0x0f, 0x38, 0xf9, 0x02" : : "a" (value), "d" (addr)); } -- 2.43.0