Re: [RFC 1/3] uapi: introduce kernel uAPI headers importation

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri,  6 Sep 2024 00:15:26 +0200
Maxime Coquelin <maxime.coquelin@redhat.com> wrote:

> This patch introduces uAPI headers importation into the
> DPDK repository. This import is possible thanks to Linux
> Kernel licence exception for syscalls:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/exceptions/Linux-syscall-note
> 
> Header files are have to be explicitly imported, and
> libraries and drivers have to explicitly enable their
> inclusion.
> 
> Guidelines are provided in the documentation, and a helper
> script is also provided to ensure proper importation of the
> header (unmodified content from a released Kernel version).
> 
> Next version will introduce a script to check headers are
> valids.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  devtools/import-linux-uapi.sh          | 48 ++++++++++++++++++++
>  doc/guides/contributing/index.rst      |  1 +
>  doc/guides/contributing/linux_uapi.rst | 63 ++++++++++++++++++++++++++
>  meson.build                            |  4 ++
>  4 files changed, 116 insertions(+)
>  create mode 100755 devtools/import-linux-uapi.sh
>  create mode 100644 doc/guides/contributing/linux_uapi.rst
> 
> diff --git a/devtools/import-linux-uapi.sh b/devtools/import-linux-uapi.sh
> new file mode 100755
> index 0000000000..efeffdd332
> --- /dev/null
> +++ b/devtools/import-linux-uapi.sh
> @@ -0,0 +1,48 @@
> +#!/bin/sh -e
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright (c) 2024 Red Hat, Inc.
> +
> +#
> +# Import Linux Kernel uAPI header file
> +#
> +
> +base_url="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/include/uapi/"
> +base_path="linux-headers/uapi/"

Sorry, not a fan of this.

This must be optional. Most other projects don't do this and it risks
incompatibilities with the C library.



Did you make sure the headers are exactly the same as the distro uses (for the same kernel version).
Worried that this is not the exact same process that "make headers_install" might use.

Also, ideally the tool would be selective.