From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A91F45941; Mon, 9 Sep 2024 02:02:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3EED402A8; Mon, 9 Sep 2024 02:02:51 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 94F93402A8 for ; Mon, 9 Sep 2024 02:02:49 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-20551e2f1f8so36428525ad.2 for ; Sun, 08 Sep 2024 17:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1725840169; x=1726444969; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5YlwvS14mql1QCexlWMmNpYaWphxCyUJUK3I+VFU9AI=; b=123tbBWnMHa04ZNH0le2laXBuK4ts2e+ptQbpiam84/GevEykNviaLJn08Qsug/moo 9Kl2SRWQnq0drHxLURRwsQT4tDMmKnK/vHwHnvzrd5PdHrPfGG3cmlgVpHA4t8WEadnT SQoyeK+Emh6tbky47S4wXF/ZHM2NtYSJaCIsxPBojw9bBKrAQ7niBgj5nCTPs4MGuUCR /CwcCytRk39LHSQMtMdG1f+v6mbtcWXYniYAoa+JdDfHExvOSSVTImxsuXz+dbSiU0Np b2UJBhEFukMeZxgHaCZRJvQyHxE78dLfg9T4kHvjRte3ivZLkxQ6S02N6Mx8Licz7PkR HcLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725840169; x=1726444969; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5YlwvS14mql1QCexlWMmNpYaWphxCyUJUK3I+VFU9AI=; b=kl8BQCPkRlD71d1JMTBUgaHR9pyqHN9ia6h/A1+xFlOmPIHB0QB7sYTXcBDTW4+tVq stPQTOx1SUYKHR81HjxuBBwRljLhKXqZeKbeCI5bicXjxeIrm5JwA8qOWHrmnVkjLSPs RbKrrkRJhl4NwfwEZYfOVvYMTHesntJjcR/12ilktZz78em+fQ9aJJ3+/ojY/aK05HEe F/S7olCBZZbDiNie36//+YC4wo4xM3DvPSlMPZ+mW7WGJgZYOiUolKLWf1uhIFDYYX3e mEnUKCP5pTGzMDik1VLUzS3JtohSACeIwHu23Jo3Ki9Us0syFQW+Pi3GO6haDenLOkGV bFOA== X-Gm-Message-State: AOJu0YwJFN1K256ZQY29xf34C5nZifZsmbb9QJyRTp6p9nJDcFONkuaH ko7zkxkW0n6mAn8tNO53dyjMGGj6YNkod0kDdoIBQ1NN3Qw1XOCb4ZZAI4N3w6I= X-Google-Smtp-Source: AGHT+IFxky/z4WD9zemNrhSIBr2gRDofYb2WaJ2pHKdUi0y8BgKxf5qHB3YnTrFJqn9UGWdOgC2AJQ== X-Received: by 2002:a17:902:f68b:b0:1fb:62e8:ae98 with SMTP id d9443c01a7336-206f04a10dbmr127062645ad.3.1725840168540; Sun, 08 Sep 2024 17:02:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e324d6sm24008905ad.88.2024.09.08.17.02.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 17:02:48 -0700 (PDT) Date: Sun, 8 Sep 2024 17:02:46 -0700 From: Stephen Hemminger To: Maxime Coquelin Cc: dev@dpdk.org, techboard@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net Subject: Re: [RFC 1/3] uapi: introduce kernel uAPI headers importation Message-ID: <20240908170246.7606c092@hermes.local> In-Reply-To: <20240905221528.1861323-2-maxime.coquelin@redhat.com> References: <20240905221528.1861323-1-maxime.coquelin@redhat.com> <20240905221528.1861323-2-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 6 Sep 2024 00:15:26 +0200 Maxime Coquelin wrote: > This patch introduces uAPI headers importation into the > DPDK repository. This import is possible thanks to Linux > Kernel licence exception for syscalls: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/exceptions/Linux-syscall-note > > Header files are have to be explicitly imported, and > libraries and drivers have to explicitly enable their > inclusion. > > Guidelines are provided in the documentation, and a helper > script is also provided to ensure proper importation of the > header (unmodified content from a released Kernel version). > > Next version will introduce a script to check headers are > valids. > > Signed-off-by: Maxime Coquelin > --- > devtools/import-linux-uapi.sh | 48 ++++++++++++++++++++ > doc/guides/contributing/index.rst | 1 + > doc/guides/contributing/linux_uapi.rst | 63 ++++++++++++++++++++++++++ > meson.build | 4 ++ > 4 files changed, 116 insertions(+) > create mode 100755 devtools/import-linux-uapi.sh > create mode 100644 doc/guides/contributing/linux_uapi.rst > > diff --git a/devtools/import-linux-uapi.sh b/devtools/import-linux-uapi.sh > new file mode 100755 > index 0000000000..efeffdd332 > --- /dev/null > +++ b/devtools/import-linux-uapi.sh > @@ -0,0 +1,48 @@ > +#!/bin/sh -e > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright (c) 2024 Red Hat, Inc. > + > +# > +# Import Linux Kernel uAPI header file > +# > + > +base_url="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/include/uapi/" > +base_path="linux-headers/uapi/" Sorry, not a fan of this. This must be optional. Most other projects don't do this and it risks incompatibilities with the C library. Did you make sure the headers are exactly the same as the distro uses (for the same kernel version). Worried that this is not the exact same process that "make headers_install" might use. Also, ideally the tool would be selective.