From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 851EC4594A; Mon, 9 Sep 2024 19:12:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CCC840ED8; Mon, 9 Sep 2024 19:12:41 +0200 (CEST) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id 0E12B40ED0 for ; Mon, 9 Sep 2024 19:12:39 +0200 (CEST) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7179802b91fso2814137b3a.3 for ; Mon, 09 Sep 2024 10:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1725901959; x=1726506759; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WW2EzNBD+3lF0U53k6P646BwtAaYF3J0yptQPgQipSc=; b=f1M3fLHojACNW2wHjL6gzSygm6sgU6zHn5fpUNfE/W/Iv7odsry89zOKPwH4nUqGD7 pSG0wmZLnr0Rb/3s3luYsydrJmQqer/VyB70thZ0cElNxRuGF5+sRUlOzccUcDSaP4M8 aQfR7zlfQYnxEcBBZICVmzB92/MV++eQVg75btzrsUFlRmU/YKq2GpcoIFbx4ULaAL3C 79ZXIgf7oWB0Bg4g3VtDTX92shkmbl03EpVMl2qbsi/kgL0gS2IpPcIeqKIubmcbsa8F /9PPLy9UdzhgwahHq/XRXQOkqA3vZWXeStQiPJufy6OVQR1f2++lqIVyCGxyr6S65ukk JLHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725901959; x=1726506759; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WW2EzNBD+3lF0U53k6P646BwtAaYF3J0yptQPgQipSc=; b=UjhUeVAdVHN6gWeh7kIbX7HuYEOjmzBWGbP1lmwSEMjfRmu8QXjxrH9quif6SrS7Sc rGiCjFl8JsYxoosu2lHdLQTeFy/bSjStfa60OQTED5PQz0OTpvd9AT7lWuegC3iD3Pqg vTj5pO4K1ei55l4N3WntilVs9Ub23A76WIafKE0le294qzb+dcNZnUg35Wzwl3ZlS8q5 WCYCNZzo2yKtJNYvnccSuNjJt92DQHIJUMNOu8k3YgWq9Q/+ViBpHX/+aHBB4slJ9RKI mHKwz92abADCol8M9OgC3rvmnZjx2fL6tGzPHU3Un86ROJSJPJtqjkNO3NS13Df89B+9 3Yew== X-Forwarded-Encrypted: i=1; AJvYcCXnTpf8n1Bl/BomjF48Eqa+MffirKPYQROzcntWF0r5zOm6BZ7TEZEEkaWmR4BQ9QPRQ30=@dpdk.org X-Gm-Message-State: AOJu0YzowlMKCvV/Q6IXxWefSkVzzsNKyNEox5n2E6GTsvIr0UE3NZGv JZUMiJnAyVG8yeEpKQVlcFMSKroJtdSimB5vYwfpQxWFyj1P+QphcUA0dQABZac= X-Google-Smtp-Source: AGHT+IFTY/wW98WdN0J60+VNqk/CftboqamB7hqXRiw5Fx6Fukzcp1MTubVJErIj7ZII3PN4ykv5GQ== X-Received: by 2002:a05:6a21:39b:b0:1cf:4ba0:c0b9 with SMTP id adf61e73a8af0-1cf4ba0c2f3mr1736434637.44.1725901959023; Mon, 09 Sep 2024 10:12:39 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-718e58bd227sm3757076b3a.64.2024.09.09.10.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Sep 2024 10:12:38 -0700 (PDT) Date: Mon, 9 Sep 2024 10:12:37 -0700 From: Stephen Hemminger To: Yong Liang <1269690261@qq.com> Cc: kai.ji@intel.com, dev@dpdk.org Subject: Re: [PATCH] Coverity issue: Failure to enqueue packets for cryptodev-scheduler_multicore can lead to program crashes Bugzilla ID: 1537 Fixes: replace `pending_deq_ops` with `pending_enq_ops` Cc: stable@dpdk.org Message-ID: <20240909101237.09c4caaa@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 10 Sep 2024 00:48:22 +0800 Yong Liang <1269690261@qq.com> wrote: > Signed-off-by: Yong Liang <1269690261@qq.com> This is not the correct way to put the covertity and bugzilla information into the patch. The infrastruture expects: 1. Put the short description in the Subject line of the email. 2. Add a longer description of what the problem is in the git commit log (body of the email) 3. Put the Coverity Issue in as a line before the Signed-off-by in the commit log. 4. Put the Bugzilla ID in as line before the Signed-off-by 5. Put the Fixes line in before the Signed-off-by Example: commit 429219adab185909a8127e680d19f7628af62fb2 Author: Anatoly Burakov Date: Fri Jul 12 12:41:35 2024 +0100 malloc: fix multi-process wait condition handling From coverity's point of view, it is theoretically possible to have an infinite wait on a wait condition because while we do check for timeout, we do not check for whether the event we are waiting for has already occurred by the time we get to the first cond_wait call (in this case, it's state of memory request list entry's state being set to COMPLETE). This can't really happen as the only time a wait condition is triggered is when we are receiving a memory event (so the entry we are waiting on cannot change before wait condition is triggered because it's protected by a mutex), so either we receive an event and modify entry state, or we exit wait on a timeout and do not care about request state. However, it's better to keep coverity happy. Coverity issue: 425709 Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug") Cc: stable@dpdk.org Signed-off-by: Anatoly Burakov