From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C67945945; Mon, 9 Sep 2024 17:07:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B421940E54; Mon, 9 Sep 2024 17:07:12 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69]) by mails.dpdk.org (Postfix) with ESMTP id C129B40E4F for ; Mon, 9 Sep 2024 17:07:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xNpwv2u9TGaXK1dOALNKZu3B902dAQIXXi3+cQ3Z+W8utv16KlQ9HLG8K6ctrU5/dZG/8clF66PxbFzE8hENBoBhB75JqkMHxt/RA9IW9AQBAZR8ZAyaC+xB3ay7lEirqmYCkAgchMxoi94qHI4X8IQjyXC2PuKEwK+WKT/SOF1djQeGxmAR9JsHNRP+9/IKOGosUQlaXHIfjgC63LFmMzCznApd8l+DiRPIKsywmphHJ5Iz5HoH1lPw0GdkApXNohhhrN0VUw+awCaJCn5Pwk8R2wTphkjpF5A0n5/p3InxO/w308/w6lzmLgHDjsfOER1XEkB3z2dG7G1ty/s3HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FORcAcTImC3VO+jULR5YD9MPGU81/5BIeguEUjIfy6I=; b=jgz7mROfCXW4hCC7kHYUQBVBZDmhqumYRcDhr34F1xTvk3ENhfRi8EgNP0oSVp0yVfqVyna3KxCbfXAwiDaIL1hyk6fIBLSwfJvyxnnIvEO9Ye47hUqAXV+g/UlXkUWKXWhw1fGyeCLLsQQQ5K7EUHVbHRTYxDmfHM9dFwB/fq6+zruUlbRg8aRdf83PoDAKTPdGBgM6ylHySFnFRayylfPYIl42YTbdLyHSK7w3kmZ8Rkm6wmf6FXryux83mC4ISlA/+I04Za0WCAFuwbdbGe7zUVgT6OPjQZuRERlj3MflPwSkjEkbuoGPylFUR7MyrOBmyD/XTfXjFNXF3YIePw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FORcAcTImC3VO+jULR5YD9MPGU81/5BIeguEUjIfy6I=; b=hqnQTs94zRQhkRBFWtr1//TsrsT7UEDM1I+OnJxfN2ZIsJN3jeG6qlidpQU0ddHH/escdUGMVFnMDw+PPgoUuuUxl05UXjloT/TfX/6x9U8M06KVGEl0VQmkwdnvyMdLkEmh0Owz11ZCPpJixOI4DwmQENhksp4+8SJ0/VgAHrfvglKBYjnQdAAyAvNohIszv6sEpNmuZBk8pExOOXwtPsWQm9+gM21cBkr3Ma37dIL+6sXyNf1XGCf78TfzJyrTVCRPBeqIcFA7f3iK7BvtZHCAPdQVuEO340V9OkMGIUr7iHBM0Bqn3SOI/aZj7KPGGhiZBrLnK5SIhWr1uJQj0g== Received: from DU2PR04CA0213.eurprd04.prod.outlook.com (2603:10a6:10:2b1::8) by AS5PR07MB10031.eurprd07.prod.outlook.com (2603:10a6:20b:655::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.24; Mon, 9 Sep 2024 15:07:06 +0000 Received: from DU6PEPF00009525.eurprd02.prod.outlook.com (2603:10a6:10:2b1:cafe::c2) by DU2PR04CA0213.outlook.office365.com (2603:10a6:10:2b1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.23 via Frontend Transport; Mon, 9 Sep 2024 15:07:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DU6PEPF00009525.mail.protection.outlook.com (10.167.8.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Mon, 9 Sep 2024 15:07:05 +0000 Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.62) with Microsoft SMTP Server id 15.2.1544.11; Mon, 9 Sep 2024 17:07:05 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id 3AA9A380061; Mon, 9 Sep 2024 17:07:05 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Jack Bond-Preston , David Marchand , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [PATCH v4 5/6] eal: add unit tests for atomic bit access functions Date: Mon, 9 Sep 2024 16:57:42 +0200 Message-ID: <20240909145743.697342-6-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240909145743.697342-1-mattias.ronnblom@ericsson.com> References: <20240812124930.604796-2-mattias.ronnblom@ericsson.com> <20240909145743.697342-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU6PEPF00009525:EE_|AS5PR07MB10031:EE_ X-MS-Office365-Filtering-Correlation-Id: 89093ca9-31c6-485b-f780-08dcd0e11178 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Zk9Pc3pyS1pEL1dCTldnOWJNaGpVNWRyZzZ3Z1NJYXErdUJhQXFFb3B6OEg5?= =?utf-8?B?RzVLZy9mcVRJdzh3V0trZnNwZFMyYVAxNWg3TkkzL3YrU1ZMYUFSZW9ndy9p?= =?utf-8?B?MXQvck5ac2U1aVFSOWFycXE2WStSdGhVOG1qdk9lQ3FRYTl4cU9HSFlOQkUz?= =?utf-8?B?emJ0M3pYZjk3bGdmVURJSmt1TWZvWCtxSWJsL2NyNkZDMHBEdHFySXBpNWZt?= =?utf-8?B?Rm5kVC9DYTdhZDFaUHR5UTFyR0J6V0pDbnIzVmVPRGZRdFNPWnV3dWtoNWVF?= =?utf-8?B?SVdCVDFHcUhGMDBCVGtWZXpTdkRnc29QK0FaaUpLVzBUV2JLclVDTlN6eHJt?= =?utf-8?B?aWwzMzFpYVg3NnNLbm9HbmNwaW9BTVArWTJaTTB3TWFpRzVFZGtwdHlla1pO?= =?utf-8?B?Q1gzK2hNcGhVV1RsYm9wdVQwZTRzSGhlRU12NXNkWkg1UTJqN0lPVExWQnVD?= =?utf-8?B?Zk1sYmFGblpzelFwN0Q1R2ZEQmgzUDFTL3dQMzlkTTY2aFdROHljbGxoNFBl?= =?utf-8?B?dEcwZjBRQ2IzeEd2Vzk5K3Rmbkd2YzBlNHE3N2hQcmNVWFJrVU41VC9pT2Mv?= =?utf-8?B?U2tiK3I2RG85Ym1RdlRiYWhLc3RFM1kzOFNDVE1HSVVmNEs5aU1XZXBsS2FO?= =?utf-8?B?MFhLQVlHS2I1ZW9ReVhUTmV6Q1cybzVSMFBjMjBsaVB6eXYxVjZPZ2NqVFht?= =?utf-8?B?b2tlY05NTENqVUpmMk5aSmFkSFdNYXAzdEhHcXc3MDI4NTMvWDZSNkR0Y0Fk?= =?utf-8?B?bjVhdzYxdndxVnJJeGZuK09pWjVSNEdUWVFTd2ZrWWRrY0tHLzRXTTdvc216?= =?utf-8?B?TUlBM3ZObllzWmpuL2NkZElQSW16S1VHV2thT0MrREl3YmlMbllDVW5CNVhE?= =?utf-8?B?Z2kyUDhrd0pjczB5Z0FmZ1g4bXpVY3pES2JUSmlqOTZvdnFIOGVtYVlkU1kv?= =?utf-8?B?ZTRQMEpsdW1sL3N6SmJWd0NDbEhQMDYxdmpJaHVJQ3JDa2I2cXJqekFuek9p?= =?utf-8?B?M0JrNlhyUnJWejRVSWN1N3M3akdFR3ZoWjBlOWRnc25VMmsyS01LMnF5ekVT?= =?utf-8?B?MU9rRzRDRXJWYnV0bU1iZzVBT1Fhb3pHTlJnR1NmUVFuUGluYml6ajd4SUgz?= =?utf-8?B?Y2Y0OS94OFRJdndQNE5NKzNxZVdWVlUvTU13YjNaaEs2QU1VVWFMSEN0MG9i?= =?utf-8?B?OXM4dERSbjhaM1FVSWVCQUsrWnpEdTA0dnNrdEtOVWxKeUV6emc2NFIzL3kz?= =?utf-8?B?M0tPcjcvQU5hdnBpTnNpU2NpZFY0VGovc0trbzBONG1GNVNsSE5XZklrSG9S?= =?utf-8?B?MHdFVVRFMitqdFpRcGtoajl5dGRiSEpORkRkRTFWb2s0TlFuTWdBcUtsRVd4?= =?utf-8?B?cWo4eklnMWhNY3RjenhkRi93TWkyQlJ1Q3VWOUEyQzlZaU04amQyNHZudmlO?= =?utf-8?B?aFRrTEpMU2pJVFZoTXNSU1NvQkcyUlJvakFCYktXTDh5NVZwUkp5OUsyM0Vn?= =?utf-8?B?NEFRb3ByeGYvaWpqeENpNWtrb1c0UlhodUVURmNBN2sxNWZ0OWVEYVlZWDUx?= =?utf-8?B?YXFCY1pSTDB2b1Z6Mm1VdHkxR3pkQ0gvdEd1M0lhSy9WWmNON1AzYW5WU21L?= =?utf-8?B?cHBnQVNXbzJlZVhCTW52bndUMEU0d1lGNWhHbklMUVgwMVVLckgzRnJvNTNU?= =?utf-8?B?NUFLcGNoOFRSbVM5MWJCMkE2aUJMOHVjVXlUSUlJcldIU25hbDMrK3N6MkZo?= =?utf-8?B?SlJLUXlTVWJOZXRmc1V3cytSTDQwdzZZRWN5WUYrRjBIczF1U3JRRERZdWV4?= =?utf-8?B?Y1FrUmtHWjQ1aFh2VG1McmVES0V5OEVISXp6eVkvdExoZDlTTEdXQ1EwUy9Y?= =?utf-8?B?MHcyVWVOU1dPZFdQUG5penphVG1iMmt0VkRLSlJXZ2Fudy9DcEVRbXRpSnpv?= =?utf-8?Q?W/MnWLa3a/gI2I3msjmg8Swlx/6JOxGc?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2024 15:07:05.8345 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89093ca9-31c6-485b-f780-08dcd0e11178 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF00009525.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR07MB10031 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --- app/test/test_bitops.c | 313 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 312 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index 322f58c066..b80216a0a1 100644 --- a/app/test/test_bitops.c +++ b/app/test/test_bitops.c @@ -3,10 +3,13 @@ * Copyright(c) 2024 Ericsson AB */ +#include #include -#include #include +#include +#include +#include #include #include "test.h" @@ -61,6 +64,304 @@ GEN_TEST_BIT_ACCESS(test_bit_access32, rte_bit_set, rte_bit_clear, GEN_TEST_BIT_ACCESS(test_bit_access64, rte_bit_set, rte_bit_clear, rte_bit_assign, rte_bit_flip, rte_bit_test, 64) +#define bit_atomic_set(addr, nr) \ + rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_clear(addr, nr) \ + rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_assign(addr, nr, value) \ + rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed) + +#define bit_atomic_flip(addr, nr) \ + rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_test(addr, nr) \ + rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 32) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 64) + +#define PARALLEL_TEST_RUNTIME 0.25 + +#define GEN_TEST_BIT_PARALLEL_ASSIGN(size) \ + \ + struct parallel_access_lcore ## size \ + { \ + unsigned int bit; \ + uint ## size ##_t *word; \ + bool failed; \ + }; \ + \ + static int \ + run_parallel_assign ## size(void *arg) \ + { \ + struct parallel_access_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + bool value = false; \ + \ + do { \ + bool new_value = rte_rand() & 1; \ + bool use_test_and_modify = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (rte_bit_atomic_test(lcore->word, lcore->bit, \ + rte_memory_order_relaxed) != value) { \ + lcore->failed = true; \ + break; \ + } \ + \ + if (use_test_and_modify) { \ + bool old_value; \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else { \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + if (old_value != value) { \ + lcore->failed = true; \ + break; \ + } \ + } else { \ + if (use_assign) \ + rte_bit_atomic_assign(lcore->word, lcore->bit, \ + new_value, \ + rte_memory_order_relaxed); \ + else { \ + if (new_value) \ + rte_bit_atomic_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + else \ + rte_bit_atomic_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + } \ + \ + value = new_value; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_assign ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + struct parallel_access_lcore ## size lmain = { \ + .word = &word \ + }; \ + struct parallel_access_lcore ## size lworker = { \ + .word = &word \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + lmain.bit = rte_rand_max(size); \ + do { \ + lworker.bit = rte_rand_max(size); \ + } while (lworker.bit == lmain.bit); \ + \ + int rc = rte_eal_remote_launch(run_parallel_assign ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_assign ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \ + TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \ + "failed"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_ASSIGN(32) +GEN_TEST_BIT_PARALLEL_ASSIGN(64) + +#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size) \ + \ + struct parallel_test_and_set_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_test_and_modify ## size(void *arg) \ + { \ + struct parallel_test_and_set_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + bool old_value; \ + bool new_value = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + if (old_value != new_value) \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_test_and_modify ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_test_and_set_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_test_and_set_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_test_and_modify ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32) +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64) + +#define GEN_TEST_BIT_PARALLEL_FLIP(size) \ + \ + struct parallel_flip_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_flip ## size(void *arg) \ + { \ + struct parallel_flip_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + rte_bit_atomic_flip(lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_flip ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_flip_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_flip_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_flip ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_flip ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_FLIP(32) +GEN_TEST_BIT_PARALLEL_FLIP(64) + static uint32_t val32; static uint64_t val64; @@ -177,6 +478,16 @@ static struct unit_test_suite test_suite = { .unit_test_cases = { TEST_CASE(test_bit_access32), TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_access32), + TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_atomic_access32), + TEST_CASE(test_bit_atomic_access64), + TEST_CASE(test_bit_atomic_parallel_assign32), + TEST_CASE(test_bit_atomic_parallel_assign64), + TEST_CASE(test_bit_atomic_parallel_test_and_modify32), + TEST_CASE(test_bit_atomic_parallel_test_and_modify64), + TEST_CASE(test_bit_atomic_parallel_flip32), + TEST_CASE(test_bit_atomic_parallel_flip64), TEST_CASE(test_bit_relaxed_set), TEST_CASE(test_bit_relaxed_clear), TEST_CASE(test_bit_relaxed_test_set_clear), -- 2.34.1