From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A7FF45952; Tue, 10 Sep 2024 09:13:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9075540151; Tue, 10 Sep 2024 09:13:13 +0200 (CEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2076.outbound.protection.outlook.com [40.107.105.76]) by mails.dpdk.org (Postfix) with ESMTP id 100D64278C for ; Tue, 10 Sep 2024 09:13:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tirgR3S8vwn10VNZ5qWhfTTp9AiyHEzxXmvEav8HwFPTZDGD8efY2z4bPEF/8kuRPcH+8Ogq0N6jTkqzygPIjnZN02MHHp5EpsdsdaM5oZOVQMwWrDHQKjwd2A0qYTSRv6gvEmH9Ou77FchPT7xlnWugO6dx8bbs3zwymlAawF3pKwNJgFedQ5MlWu7Ou9DEgEkkoxHxwE8fvTcsilqy5dmGhTcQDxlNzC+23saPfUkw1gM0Unux7udQEagixigaxKtBolhWYcwRK26CpD2iEQEIbpZYJLHek/qZrLe0S0xhw2Omz1w9oitQKv/cPDu5WgCY08H5x6adxSP4hie+cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=75z+lMU0W9MYrOZSbeH4OIEGHZjSiMo6/I9oUTCcslU=; b=j2iqS5KSEw2TTilCrhV/s9EIrmH0Rrd71R15smXpyHQR6vyegf+ekQ76eDw8PiIqw3cjmLRcTbyBiW5xv4TMvMd73QDY0LbUxUfoWGOrtiyITMCAqdZfNozeX5FNZ57O+vIicDHhKBrVvqpTW/5G5y+05ml6FQrAXHx4ajzSGlT/ELr2RBJmhorXPjfUH7RZlelDCjpc0/eu1vA60QH5TH3E3QbS5+ZdDAyJtmUJ9De9EMqSwc2R5RHGlPToqKOMC+MhBalEo7R0d1WlkAUlAC4JNdqbOnsksDHUQmCEjdlUHu0jKGtxGDHqGHIsvZvu8dZzBLluVaPi3W/AiW99tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=75z+lMU0W9MYrOZSbeH4OIEGHZjSiMo6/I9oUTCcslU=; b=u+5bBaZ/s3kcIu9PADyFn37g63CKiZAGnkQGtreugvM6nq4zHeViAIBSiIRJvDxlLMy39/2xiyfLc2nGHNobntqLQllRAF5wfMgg5t9BfJu9eoWXciLKzRvwpdCq86BY90OeF/lQlgJS9eU1eBUdHYigltYU/u9/GSjuHM86TdeJUYs2g9AjTJVkkrGd7hqcqKRM0S7Z7eNRQ3OP1QYZ+O0FQn71nNbZNFwv2n0ZD3Qcbb+ATUO3/8hgerplVWt2b+t/m5as4aECIiw8zdEG54oMIRMJg4yUCE4IFS2u0Ws1Sc70QAHnPp9Bn9H4KMTSg6J3vmKYQ6WGuYOhzw2mcQ== Received: from DU7PR01CA0003.eurprd01.prod.exchangelabs.com (2603:10a6:10:50f::17) by AM9PR07MB7202.eurprd07.prod.outlook.com (2603:10a6:20b:2d3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.24; Tue, 10 Sep 2024 07:13:06 +0000 Received: from DU6PEPF00009524.eurprd02.prod.outlook.com (2603:10a6:10:50f:cafe::4d) by DU7PR01CA0003.outlook.office365.com (2603:10a6:10:50f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.25 via Frontend Transport; Tue, 10 Sep 2024 07:13:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DU6PEPF00009524.mail.protection.outlook.com (10.167.8.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Tue, 10 Sep 2024 07:13:06 +0000 Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.69) with Microsoft SMTP Server id 15.2.1544.11; Tue, 10 Sep 2024 09:13:05 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id 82A0938007A; Tue, 10 Sep 2024 09:13:05 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Stephen Hemminger , Konstantin Ananyev , David Marchand , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [PATCH 2/6] eal: add lcore variable test suite Date: Tue, 10 Sep 2024 09:03:40 +0200 Message-ID: <20240910070344.699183-3-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240910070344.699183-1-mattias.ronnblom@ericsson.com> References: <20240506082721.120666-2-mattias.ronnblom@ericsson.com> <20240910070344.699183-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU6PEPF00009524:EE_|AM9PR07MB7202:EE_ X-MS-Office365-Filtering-Correlation-Id: ac94b390-9244-44b1-4d30-08dcd1680491 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eWtrQUtFUWNlOWdQVTFoWi9pTkYyWHVNajVEdW9WRnM2ek9jb3dWbkdZQ25y?= =?utf-8?B?cS9xRFhIOGZtVE1hbm11VVJnZUU1QnJsWmlQY1dsTEw1Z2xpM1dwd2xNYkQ3?= =?utf-8?B?NWd6ZWZHZ1J1UnkxdW5KN1dQNVNZQ21uR3VRdHBrZjZIRUp4U0U1OTFZck9j?= =?utf-8?B?QktYMEZGTFFyQW9xZTZvTFg3bm9yNVdCQVpFdytSd045ZW9yTHFPdWRzK0Nr?= =?utf-8?B?aEhXR1hTc1RqcWxCWFhiSHQxUmhteHZPTy9HeGp0ZmtBelRaU2g0cjFpS3RX?= =?utf-8?B?WFdHemp4Q1FvUXl1YWpKQ0VDNnNma1dzaGhSK3VCM1BBVEo5dFJ4aUR5UlI5?= =?utf-8?B?UEtiNkZrb2crekluZzVpWDNKdFp0QklCSjBubmE4M28zMnE0TnBGMFNzS2lo?= =?utf-8?B?VDV0TlJuNnphdFhwdnlWUmR1d0cvVnMwMGtRTDd4ZXRhdy9PSXljblJIR3oz?= =?utf-8?B?TzFGZm1kZmM5alpjNnI3bGd6T3M2aG9EMmFRTFFnRms4SnJjZUMyL3l5Zi9V?= =?utf-8?B?WXhSMEI0SHVDeUMxMnJOcUduTGRmMWVFM2tzUkUycVB3aEpicGN1TGc4ckN0?= =?utf-8?B?ZjAzNnlEaSswenA2bjUxL0VqcmlOOEMra1pVcG1QZGFLSWI1TGtRdTcxUXpj?= =?utf-8?B?RkZGbmZZM1FPcXJvRlpPTUJMOEVHcFlJcERpazI0dkpjN3M3Qit0WWZKZ3pi?= =?utf-8?B?Vi9IRnRlL0lSaHlQYkhHenh5a0VxUDJZSW1wNzBzSWY2QWZ0c2tnZTNxZ0hi?= =?utf-8?B?eUdVSUJ6d0VqZXh0dnlSdzhud0hTTG5GUDNOL2NySHpuT3UwUDRJdjBIRlVC?= =?utf-8?B?NGRkUVZIOVFzdGNtb2RGS1lzN2ZUaWsyRW9OcVVTTU1jTmFIRDU0akhWNTNN?= =?utf-8?B?YWNzbm1kV3BOVmlrQ2N2MlRSdHRzRWViSE1RNmlTbjlWRWMzdWRYV2dEZkhh?= =?utf-8?B?ejJmYWFJZU45OEhIMzVaMzhXbWQ0c3ErYTFzSXY4TWFseC9wSGZBWHpSeUhq?= =?utf-8?B?aFlsNmdDUkVtZkl6WC9rTEdkNXZEMW9tejVZMWY1cWFMYWduT0tDd2k4a0Qy?= =?utf-8?B?a3ZaSXVCSE5zZDZpY0ZEb1dtNFIyMldQYitYL0xJWkdnK0JNSzlIUno1RW02?= =?utf-8?B?TDh4eThqZHVHdGZoMzdxNWZuaWZEQklkZkczYlg4VWw4Z29pbks0QmN1QnhV?= =?utf-8?B?UEpweHVTeTZ2Q0NuV2hCdSsxSlBhOXdQMDNvNVlKSG9QNGtEVjB4UEcvMTB0?= =?utf-8?B?bG5aTjhOZFhjMWZVME1ocGxkWUR0Y1lxSFpmbE14S1UyOW9tdnNLVGI4WmFn?= =?utf-8?B?dGE2SFpxSU9SQWpzUjRtZDZWMldOREYrQWU3M0g2eXBwM05ldE5TYzJEbURa?= =?utf-8?B?YjVnS3B5cm5RZUZqMHdQZmJieWxnZE1oQlB3a21hU3QvUTlORURkMDBEMDZk?= =?utf-8?B?V3NIYStEZU1rL3lSc2l6d0NxcUVrWGRHdTRSMStMc1o5QXo1aHI5OUoyVTJB?= =?utf-8?B?OXRYK1dVZnlRS2N4SjgxOTNHa2thWFNSaW81Y3h6UGhoZCt6eGJkbGRxWXg0?= =?utf-8?B?QkJmY09ybWtYYXplNEVqYTVrVWhPelk1MUJLOVZxRWRCRlBSeFJYL0VwcWFv?= =?utf-8?B?T2dma2EwSVRHem5MNHNqaGVXU3hQTVhPREszSFdLUHNMd1BzOXYzYUxqa2NV?= =?utf-8?B?emw1Mk03OUZaQnNaVnZHajAzWnhsWHJRTkpjNjVlNHNJcFRwT3laZk1rZTlI?= =?utf-8?B?eFI4VllnSEwzblp5MWpPOGoyNWRFRnlXK1EweUtaNzNzOTZsVVUxUUxFSzZP?= =?utf-8?B?aUdWRHJ5TjRtb0h5WGFOMHFpZXdMK3BJMGVhMGN0SGs0dm5DNktHK2g4akZF?= =?utf-8?B?QnBTNE0ydUNiaXpBOXFFbWJvWjcva2pzL3F6d3h1KzJ1cFFLZmNhTkVSam9T?= =?utf-8?Q?HNo4GmxOox4W9r9fNWxQ7Cx7pqYh2Rmx?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(376014)(36860700013)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2024 07:13:06.2421 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ac94b390-9244-44b1-4d30-08dcd1680491 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF00009524.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR07MB7202 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add test suite to exercise the API. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup -- RFC v5: * Adapt tests to reflect the removal of the GET() and SET() macros. RFC v4: * Check all lcore id's values for all variables in the many variables test case. * Introduce test case for max-sized lcore variables. RFC v2: * Improve alignment-related test coverage. --- app/test/meson.build | 1 + app/test/test_lcore_var.c | 432 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 433 insertions(+) create mode 100644 app/test/test_lcore_var.c diff --git a/app/test/meson.build b/app/test/meson.build index e29258e6ec..48279522f0 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -103,6 +103,7 @@ source_file_deps = { 'test_ipsec_sad.c': ['ipsec'], 'test_kvargs.c': ['kvargs'], 'test_latencystats.c': ['ethdev', 'latencystats', 'metrics'] + sample_packet_forward_deps, + 'test_lcore_var.c': [], 'test_lcores.c': [], 'test_link_bonding.c': ['ethdev', 'net_bond', 'net'] + packet_burst_generator_deps + virtual_pmd_deps, diff --git a/app/test/test_lcore_var.c b/app/test/test_lcore_var.c new file mode 100644 index 0000000000..e07d13460f --- /dev/null +++ b/app/test/test_lcore_var.c @@ -0,0 +1,432 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2024 Ericsson AB + */ + +#include +#include +#include + +#include +#include +#include + +#include "test.h" + +#define MIN_LCORES 2 + +RTE_LCORE_VAR_HANDLE(int, test_int); +RTE_LCORE_VAR_HANDLE(char, test_char); +RTE_LCORE_VAR_HANDLE(long, test_long_sized); +RTE_LCORE_VAR_HANDLE(short, test_short); +RTE_LCORE_VAR_HANDLE(long, test_long_sized_aligned); + +struct int_checker_state { + int old_value; + int new_value; + bool success; +}; + +static void +rand_blk(void *blk, size_t size) +{ + size_t i; + + for (i = 0; i < size; i++) + ((unsigned char *)blk)[i] = (unsigned char)rte_rand(); +} + +static bool +is_ptr_aligned(const void *ptr, size_t align) +{ + return ptr != NULL ? (uintptr_t)ptr % align == 0 : false; +} + +static int +check_int(void *arg) +{ + struct int_checker_state *state = arg; + + int *ptr = RTE_LCORE_VAR_VALUE(test_int); + + bool naturally_aligned = is_ptr_aligned(ptr, sizeof(int)); + + bool equal = *(RTE_LCORE_VAR_VALUE(test_int)) == state->old_value; + + state->success = equal && naturally_aligned; + + *ptr = state->new_value; + + return 0; +} + +RTE_LCORE_VAR_INIT(test_int); +RTE_LCORE_VAR_INIT(test_char); +RTE_LCORE_VAR_INIT_SIZE(test_long_sized, 32); +RTE_LCORE_VAR_INIT(test_short); +RTE_LCORE_VAR_INIT_SIZE_ALIGN(test_long_sized_aligned, sizeof(long), + RTE_CACHE_LINE_SIZE); + +static int +test_int_lvar(void) +{ + unsigned int lcore_id; + + struct int_checker_state states[RTE_MAX_LCORE] = {}; + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct int_checker_state *state = &states[lcore_id]; + + state->old_value = (int)rte_rand(); + state->new_value = (int)rte_rand(); + + *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, test_int) = + state->old_value; + } + + RTE_LCORE_FOREACH_WORKER(lcore_id) + rte_eal_remote_launch(check_int, &states[lcore_id], lcore_id); + + rte_eal_mp_wait_lcore(); + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct int_checker_state *state = &states[lcore_id]; + int value; + + TEST_ASSERT(state->success, "Unexpected value " + "encountered on lcore %d", lcore_id); + + value = *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, test_int); + TEST_ASSERT_EQUAL(state->new_value, value, + "Lcore %d failed to update int", lcore_id); + } + + /* take the opportunity to test the foreach macro */ + int *v; + lcore_id = 0; + RTE_LCORE_VAR_FOREACH_VALUE(v, test_int) { + TEST_ASSERT_EQUAL(states[lcore_id].new_value, *v, + "Unexpected value on lcore %d during " + "iteration", lcore_id); + lcore_id++; + } + + return TEST_SUCCESS; +} + +static int +test_sized_alignment(void) +{ + long *v; + + RTE_LCORE_VAR_FOREACH_VALUE(v, test_long_sized) { + TEST_ASSERT(is_ptr_aligned(v, alignof(long)), + "Type-derived alignment failed"); + } + + RTE_LCORE_VAR_FOREACH_VALUE(v, test_long_sized_aligned) { + TEST_ASSERT(is_ptr_aligned(v, RTE_CACHE_LINE_SIZE), + "Explicit alignment failed"); + } + + return TEST_SUCCESS; +} + +/* private, larger, struct */ +#define TEST_STRUCT_DATA_SIZE 1234 + +struct test_struct { + uint8_t data[TEST_STRUCT_DATA_SIZE]; +}; + +static RTE_LCORE_VAR_HANDLE(char, before_struct); +static RTE_LCORE_VAR_HANDLE(struct test_struct, test_struct); +static RTE_LCORE_VAR_HANDLE(char, after_struct); + +struct struct_checker_state { + struct test_struct old_value; + struct test_struct new_value; + bool success; +}; + +static int check_struct(void *arg) +{ + struct struct_checker_state *state = arg; + + struct test_struct *lcore_struct = RTE_LCORE_VAR_VALUE(test_struct); + + bool properly_aligned = + is_ptr_aligned(test_struct, alignof(struct test_struct)); + + bool equal = memcmp(lcore_struct->data, state->old_value.data, + TEST_STRUCT_DATA_SIZE) == 0; + + state->success = equal && properly_aligned; + + memcpy(lcore_struct->data, state->new_value.data, + TEST_STRUCT_DATA_SIZE); + + return 0; +} + +static int +test_struct_lvar(void) +{ + unsigned int lcore_id; + + RTE_LCORE_VAR_ALLOC(before_struct); + RTE_LCORE_VAR_ALLOC(test_struct); + RTE_LCORE_VAR_ALLOC(after_struct); + + struct struct_checker_state states[RTE_MAX_LCORE]; + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct struct_checker_state *state = &states[lcore_id]; + + rand_blk(state->old_value.data, TEST_STRUCT_DATA_SIZE); + rand_blk(state->new_value.data, TEST_STRUCT_DATA_SIZE); + + memcpy(RTE_LCORE_VAR_LCORE_VALUE(lcore_id, test_struct)->data, + state->old_value.data, TEST_STRUCT_DATA_SIZE); + } + + RTE_LCORE_FOREACH_WORKER(lcore_id) + rte_eal_remote_launch(check_struct, &states[lcore_id], + lcore_id); + + rte_eal_mp_wait_lcore(); + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct struct_checker_state *state = &states[lcore_id]; + struct test_struct *lstruct = + RTE_LCORE_VAR_LCORE_VALUE(lcore_id, test_struct); + + TEST_ASSERT(state->success, "Unexpected value encountered on " + "lcore %d", lcore_id); + + bool equal = memcmp(lstruct->data, state->new_value.data, + TEST_STRUCT_DATA_SIZE) == 0; + + TEST_ASSERT(equal, "Lcore %d failed to update struct", + lcore_id); + } + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + char before = + *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, before_struct); + char after = + *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, after_struct); + + TEST_ASSERT_EQUAL(before, 0, "Lcore variable before test " + "struct was modified on lcore %d", lcore_id); + TEST_ASSERT_EQUAL(after, 0, "Lcore variable after test " + "struct was modified on lcore %d", lcore_id); + } + + return TEST_SUCCESS; +} + +#define TEST_ARRAY_SIZE 99 + +typedef uint16_t test_array_t[TEST_ARRAY_SIZE]; + +static void test_array_init_rand(test_array_t a) +{ + size_t i; + for (i = 0; i < TEST_ARRAY_SIZE; i++) + a[i] = (uint16_t)rte_rand(); +} + +static bool test_array_equal(test_array_t a, test_array_t b) +{ + size_t i; + for (i = 0; i < TEST_ARRAY_SIZE; i++) { + if (a[i] != b[i]) + return false; + } + return true; +} + +static void test_array_copy(test_array_t dst, const test_array_t src) +{ + size_t i; + for (i = 0; i < TEST_ARRAY_SIZE; i++) + dst[i] = src[i]; +} + +static RTE_LCORE_VAR_HANDLE(char, before_array); +static RTE_LCORE_VAR_HANDLE(test_array_t, test_array); +static RTE_LCORE_VAR_HANDLE(char, after_array); + +struct array_checker_state { + test_array_t old_value; + test_array_t new_value; + bool success; +}; + +static int check_array(void *arg) +{ + struct array_checker_state *state = arg; + + test_array_t *lcore_array = RTE_LCORE_VAR_VALUE(test_array); + + bool properly_aligned = + is_ptr_aligned(lcore_array, alignof(test_array_t)); + + bool equal = test_array_equal(*lcore_array, state->old_value); + + state->success = equal && properly_aligned; + + test_array_copy(*lcore_array, state->new_value); + + return 0; +} + +static int +test_array_lvar(void) +{ + unsigned int lcore_id; + + RTE_LCORE_VAR_ALLOC(before_array); + RTE_LCORE_VAR_ALLOC(test_array); + RTE_LCORE_VAR_ALLOC(after_array); + + struct array_checker_state states[RTE_MAX_LCORE]; + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct array_checker_state *state = &states[lcore_id]; + + test_array_init_rand(state->new_value); + test_array_init_rand(state->old_value); + + test_array_copy(*RTE_LCORE_VAR_LCORE_VALUE(lcore_id, + test_array), + state->old_value); + } + + RTE_LCORE_FOREACH_WORKER(lcore_id) + rte_eal_remote_launch(check_array, &states[lcore_id], + lcore_id); + + rte_eal_mp_wait_lcore(); + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct array_checker_state *state = &states[lcore_id]; + test_array_t *larray = + RTE_LCORE_VAR_LCORE_VALUE(lcore_id, test_array); + + TEST_ASSERT(state->success, "Unexpected value encountered on " + "lcore %d", lcore_id); + + bool equal = test_array_equal(*larray, state->new_value); + + TEST_ASSERT(equal, "Lcore %d failed to update array", + lcore_id); + } + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + char before = + *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, before_array); + char after = + *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, after_array); + + TEST_ASSERT_EQUAL(before, 0, "Lcore variable before test " + "array was modified on lcore %d", lcore_id); + TEST_ASSERT_EQUAL(after, 0, "Lcore variable after test " + "array was modified on lcore %d", lcore_id); + } + + return TEST_SUCCESS; +} + +#define MANY_LVARS (2 * RTE_MAX_LCORE_VAR / sizeof(uint32_t)) + +static int +test_many_lvars(void) +{ + uint32_t **handlers = malloc(sizeof(uint32_t *) * MANY_LVARS); + unsigned int i; + + TEST_ASSERT(handlers != NULL, "Unable to allocate memory"); + + for (i = 0; i < MANY_LVARS; i++) { + unsigned int lcore_id; + + RTE_LCORE_VAR_ALLOC(handlers[i]); + + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { + uint32_t *v = + RTE_LCORE_VAR_LCORE_VALUE(lcore_id, handlers[i]); + *v = (uint32_t)(i * lcore_id); + } + } + + for (i = 0; i < MANY_LVARS; i++) { + unsigned int lcore_id; + + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { + uint32_t v = *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, + handlers[i]); + TEST_ASSERT_EQUAL((uint32_t)(i * lcore_id), v, + "Unexpected lcore variable value on " + "lcore %d", lcore_id); + } + } + + free(handlers); + + return TEST_SUCCESS; +} + +static int +test_large_lvar(void) +{ + RTE_LCORE_VAR_HANDLE(unsigned char, large); + unsigned int lcore_id; + + RTE_LCORE_VAR_ALLOC_SIZE(large, RTE_MAX_LCORE_VAR); + + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { + unsigned char *ptr = RTE_LCORE_VAR_LCORE_VALUE(lcore_id, large); + + memset(ptr, (unsigned char)lcore_id, RTE_MAX_LCORE_VAR); + } + + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { + unsigned char *ptr = RTE_LCORE_VAR_LCORE_VALUE(lcore_id, large); + size_t i; + + for (i = 0; i < RTE_MAX_LCORE_VAR; i++) + TEST_ASSERT_EQUAL(ptr[i], (unsigned char)lcore_id, + "Large lcore variable value is " + "corrupted on lcore %d.", + lcore_id); + } + + return TEST_SUCCESS; +} + +static struct unit_test_suite lcore_var_testsuite = { + .suite_name = "lcore variable autotest", + .unit_test_cases = { + TEST_CASE(test_int_lvar), + TEST_CASE(test_sized_alignment), + TEST_CASE(test_struct_lvar), + TEST_CASE(test_array_lvar), + TEST_CASE(test_many_lvars), + TEST_CASE(test_large_lvar), + TEST_CASES_END() + }, +}; + +static int test_lcore_var(void) +{ + if (rte_lcore_count() < MIN_LCORES) { + printf("Not enough cores for lcore_var_autotest; expecting at " + "least %d.\n", MIN_LCORES); + return TEST_SKIPPED; + } + + return unit_test_suite_runner(&lcore_var_testsuite); +} + +REGISTER_FAST_TEST(lcore_var_autotest, true, false, test_lcore_var); -- 2.34.1