From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C315F45954; Tue, 10 Sep 2024 10:41:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32DF3427BA; Tue, 10 Sep 2024 10:41:15 +0200 (CEST) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2044.outbound.protection.outlook.com [40.107.241.44]) by mails.dpdk.org (Postfix) with ESMTP id A8F5C4021F for ; Tue, 10 Sep 2024 10:41:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=x9hwtqpO4JPr/KX/Tl2OGxkg4d04Bhl8GUYugFpgtjUhI6i/pFIcE0EWk/VrfhJlBmfPFeRyrGWVp11CHkusj9gxsKcw2UgJ7d2xOW9Eti26wdKPzd+9TEqjJ2GNO22tf8hDtzyGiV5BjqaMyP1SFo4KfUfkANCV+lV37XxTsWCE5bBpON6bhdJe/L7kf1sX+sbfuvEq2RLztffEG0utqDA1RvugP70Jbe0vUEMLuwV6kXXIqnq3HE2Q2M1lgmcmqHboXf0leLINEgndElTIJ1+F/y+2uBie2r58JdQJhqTepr4Kyd5naySnFTMpd7RLqh1vuNzhsDm8c/7Ei5K0Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FORcAcTImC3VO+jULR5YD9MPGU81/5BIeguEUjIfy6I=; b=dOcfHSJiiHz+2heEjIBR+hFRqNb1keMeatfSyyzWyy/Xdz1vV9eK2a2LpZJAqU/TQ1nMC5JGnZ9ScPRCRtMlNmSdzjZQArxY/5qhUOhr5IeJex9BH8kkVluXnqMhwYdI//X1eFMPAJEbmbX7t7gexv7bHbVeaMUdiEJovduI/s0lbxwPsBOyHKg8nAuQpgmuZvTpp46lb0Q3SduM5okbSJe1+HPQTWSHGTbMnh0sXAj3NE/0+89DOEdRPlWFS19X/WxQ/rqTJ0ghnnDhLlkLQkm2gj1N4IwBjml3vqFX/ijyS8Hs4VmhSt6j0Uqkv8mfS38U1+cwqkSDWqjI3DuT8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FORcAcTImC3VO+jULR5YD9MPGU81/5BIeguEUjIfy6I=; b=LZ53CWP5AqhCj6/EN0VXhyLsWj8Rr3NXSELQT0Y8RsMyfCIF5FywtgDgtvGfz1rp794COLjXFzCe+yz7Qn+uB7OpqOAamt4CcfVXoGOzNxvn/yN96Hi6smlAIdf3Bd8BouV/J7F+gmzeJCdhYagkHwXkUFmMoCb8KuCp2e2ySPNCeWk/E7Fk8LXYYqi/PI/Pp08oNhuD1GcTX38XPpEobHKrF4yMJyYEJoE/qEMDVM65oBlOb77Cftkw4QIjKPgepIkrkU9bfNMalsdkn7/m37Zaci5OBKzY959x05r4IeNDOmDzhdzL64xFCnWUJLCwt5KWYee5CLl8s4QBMjo2lA== Received: from DU7P190CA0021.EURP190.PROD.OUTLOOK.COM (2603:10a6:10:550::17) by PAVPR07MB9309.eurprd07.prod.outlook.com (2603:10a6:102:314::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.22; Tue, 10 Sep 2024 08:41:09 +0000 Received: from DB1PEPF000509E5.eurprd03.prod.outlook.com (2603:10a6:10:550:cafe::7c) by DU7P190CA0021.outlook.office365.com (2603:10a6:10:550::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.25 via Frontend Transport; Tue, 10 Sep 2024 08:41:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DB1PEPF000509E5.mail.protection.outlook.com (10.167.242.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Tue, 10 Sep 2024 08:41:09 +0000 Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.60) with Microsoft SMTP Server id 15.2.1544.11; Tue, 10 Sep 2024 10:41:08 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id CACBE380061; Tue, 10 Sep 2024 10:41:08 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Jack Bond-Preston , David Marchand , Chengwen Feng , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [PATCH v6 5/6] eal: add unit tests for atomic bit access functions Date: Tue, 10 Sep 2024 10:31:38 +0200 Message-ID: <20240910083139.699291-6-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240910083139.699291-1-mattias.ronnblom@ericsson.com> References: <20240910062051.699096-2-mattias.ronnblom@ericsson.com> <20240910083139.699291-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509E5:EE_|PAVPR07MB9309:EE_ X-MS-Office365-Filtering-Correlation-Id: af42e1fe-502a-4228-e479-08dcd1745197 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RVExUUhGN1ZPdVRZdjZycExuSEN0Z01PRUNJaUtIUVNaWHRsMFhseUcvUjZN?= =?utf-8?B?clMwWk5qWkM0NWNYQ2JDL0w0UmM5Z3ZTeTZxelBNQlRGSGpERXZLRVE4Qkdh?= =?utf-8?B?YUVhWTRjUjVCNE1yLzMzZjB4cGZCZldqWnNZZUtmWHhuVFVVS2k5eHIvRWVH?= =?utf-8?B?MUpJYndKNld1MUxjTTNwU25MWW1wbXVTczFCaXI2MngxbUVKZTVEWDZLKzcr?= =?utf-8?B?bmdSVDZCaTJCcG5OSU10WlBKUHlTU3RzK3Z4Qm8wQ2ZDYzFBMFZ3Ny9idmhQ?= =?utf-8?B?NDVvMUdyMXpQVVBlaHBOTzFYL0Q3VmRMQkZaWXNrTlJscFZIL3NSbHFlTTdT?= =?utf-8?B?SUtpc2toWnN4WkpkL1VneFRiY2dhbkE3NHdlRC9ueTExWkp3V0NmbzRBT2Jl?= =?utf-8?B?UU5EWmpNcTcvVlZWeEhWZEUrS2hqNldONWZQdVZPTFFnaGZabU5yeWtjTjJW?= =?utf-8?B?VkV0UFl4VDY1N2J4NER1M1NrOElnOEhvbTVESHhlZEc4Q3p3NnJIejVTMTg4?= =?utf-8?B?RENSZWJoU2lwMFNJRnVibldFTHkzekd4YW43OEMwMzNNTldYLzVibTE3UExh?= =?utf-8?B?WGQzUGdsTUtZZis5YncxWGgvcitwMURvZ1hiUnNGLzJPeExTZndsTkZTVHpZ?= =?utf-8?B?a3NsNm9mVFdPaEtuaVVEcUdlOThzcGlqaUdpa0ZhSzZJV3F5cFhLVVY4bGgz?= =?utf-8?B?WWhjT0dtRm54QWRnOWVXdWNuSkh5YUVGWGpoYUM0SFpjWUdZczVwK1NOdnhl?= =?utf-8?B?S1Yrak1xQmtydWxGb0VXSm1VNWJLYll0dDh1eWxHc29yRHRvL3liaWMvT3BC?= =?utf-8?B?dU5SeTYxZ2lJbmRobUhjOXptYVJGa3gyZmZmQ3B1aTd6NTVqVmFVTy9EY1I2?= =?utf-8?B?aUxxQ3pXODU1Q2IvaStLRElFRno0MFhrYlVWSlIrZ3dab2RNRFNTN3BmK1ZJ?= =?utf-8?B?WWxqcTR6QTVZN2JNWDRQVUJzdnFnMmF4TThMUHpPc0h5aFZtR2VkZ01HRkdz?= =?utf-8?B?aWF1UlAxOGJVelFYQWd0eTR2L2Yvbkt2bzVQbnpxcS9rb1lBdlNpcXRNQ1Zs?= =?utf-8?B?V1MySEFTUkJRQ1R4bDBpVW9ZcUR2ZGNuOWpGTkNwdlpFMUlRVjFsV2xRRjhv?= =?utf-8?B?T0VEcWo2MTRQWFA2SFQrZUIyUTFnOTF1dE9GaFozaHowV3dha29yL0t2ZzBq?= =?utf-8?B?K3R1U2JCeXpLNHNJSXdOZVhEc0tNMmlsQUJ3Sm13ajY1S1lnK01aTkFseXBR?= =?utf-8?B?YUFvcHZ2dkFMRnVFckNJak1LVFdoTW53aENtUkNBSWZtU1BuNlRsa2ZPaUwy?= =?utf-8?B?dXNPTnlqS01vS2djdi9WaE9QQUltSlZzMDZjdE1wb2laSG5GUkJTY1JxZGhJ?= =?utf-8?B?MVJ1cHVzNGZtRXBWRC82dHpOOEZrbnZlbitaWXFUWHd5KzIrbWx2ak1oWmFI?= =?utf-8?B?VlRzQ2hGR2hCT3ZHVTArdHI4RnBxVHVRNzZXOU5kcTYxUVNLK1o0Q1o1dGdx?= =?utf-8?B?QVBOdFl0YmlLRmtCb3VUMVNBVHpjWEd4RWpxcnBOd1ppVjM3Vml5WXNPVkg2?= =?utf-8?B?RUVCRUFoc0FURG05QlZKbnQybnZMd25pR2VDSC9UcUlzRnltUFhjd2dLSVV3?= =?utf-8?B?eWV3Z0ZUS2tMNU16SHdWY0RacnZFREhYZVhIVDVwSFRjWkR6ZjQ4RDZqRWNO?= =?utf-8?B?c1NOczZLVnBTeVhYTHdFdVhJZ0hMWnNkL0l1K3JDTHlOME5KbXhGYjZXbHFI?= =?utf-8?B?dkQ4amdXSTcxd3d5WVFldFpBTEpLZjViZEFXSG4xUDJySGV0NW1hUWNyd2Zx?= =?utf-8?B?QmhhYXJsdVViOWUxMGdvdllYTXdiSHViTkZEOFFxZmE5dmZRTVoxMjVvOTZx?= =?utf-8?B?MCtvbFJxRzdSZFFBaHE2azgzSjVrc1d6dDlFTHdsdHhUdGpveFdYMys4VHEv?= =?utf-8?Q?ZDYPw8ZIBrQ9FRFYS48bUshlpmNI45eg?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2024 08:41:09.4150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af42e1fe-502a-4228-e479-08dcd1745197 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509E5.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR07MB9309 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --- app/test/test_bitops.c | 313 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 312 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index 322f58c066..b80216a0a1 100644 --- a/app/test/test_bitops.c +++ b/app/test/test_bitops.c @@ -3,10 +3,13 @@ * Copyright(c) 2024 Ericsson AB */ +#include #include -#include #include +#include +#include +#include #include #include "test.h" @@ -61,6 +64,304 @@ GEN_TEST_BIT_ACCESS(test_bit_access32, rte_bit_set, rte_bit_clear, GEN_TEST_BIT_ACCESS(test_bit_access64, rte_bit_set, rte_bit_clear, rte_bit_assign, rte_bit_flip, rte_bit_test, 64) +#define bit_atomic_set(addr, nr) \ + rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_clear(addr, nr) \ + rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_assign(addr, nr, value) \ + rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed) + +#define bit_atomic_flip(addr, nr) \ + rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_test(addr, nr) \ + rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 32) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 64) + +#define PARALLEL_TEST_RUNTIME 0.25 + +#define GEN_TEST_BIT_PARALLEL_ASSIGN(size) \ + \ + struct parallel_access_lcore ## size \ + { \ + unsigned int bit; \ + uint ## size ##_t *word; \ + bool failed; \ + }; \ + \ + static int \ + run_parallel_assign ## size(void *arg) \ + { \ + struct parallel_access_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + bool value = false; \ + \ + do { \ + bool new_value = rte_rand() & 1; \ + bool use_test_and_modify = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (rte_bit_atomic_test(lcore->word, lcore->bit, \ + rte_memory_order_relaxed) != value) { \ + lcore->failed = true; \ + break; \ + } \ + \ + if (use_test_and_modify) { \ + bool old_value; \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else { \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + if (old_value != value) { \ + lcore->failed = true; \ + break; \ + } \ + } else { \ + if (use_assign) \ + rte_bit_atomic_assign(lcore->word, lcore->bit, \ + new_value, \ + rte_memory_order_relaxed); \ + else { \ + if (new_value) \ + rte_bit_atomic_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + else \ + rte_bit_atomic_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + } \ + \ + value = new_value; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_assign ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + struct parallel_access_lcore ## size lmain = { \ + .word = &word \ + }; \ + struct parallel_access_lcore ## size lworker = { \ + .word = &word \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + lmain.bit = rte_rand_max(size); \ + do { \ + lworker.bit = rte_rand_max(size); \ + } while (lworker.bit == lmain.bit); \ + \ + int rc = rte_eal_remote_launch(run_parallel_assign ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_assign ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \ + TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \ + "failed"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_ASSIGN(32) +GEN_TEST_BIT_PARALLEL_ASSIGN(64) + +#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size) \ + \ + struct parallel_test_and_set_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_test_and_modify ## size(void *arg) \ + { \ + struct parallel_test_and_set_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + bool old_value; \ + bool new_value = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + if (old_value != new_value) \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_test_and_modify ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_test_and_set_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_test_and_set_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_test_and_modify ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32) +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64) + +#define GEN_TEST_BIT_PARALLEL_FLIP(size) \ + \ + struct parallel_flip_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_flip ## size(void *arg) \ + { \ + struct parallel_flip_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + rte_bit_atomic_flip(lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_flip ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_flip_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_flip_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_flip ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_flip ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_FLIP(32) +GEN_TEST_BIT_PARALLEL_FLIP(64) + static uint32_t val32; static uint64_t val64; @@ -177,6 +478,16 @@ static struct unit_test_suite test_suite = { .unit_test_cases = { TEST_CASE(test_bit_access32), TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_access32), + TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_atomic_access32), + TEST_CASE(test_bit_atomic_access64), + TEST_CASE(test_bit_atomic_parallel_assign32), + TEST_CASE(test_bit_atomic_parallel_assign64), + TEST_CASE(test_bit_atomic_parallel_test_and_modify32), + TEST_CASE(test_bit_atomic_parallel_test_and_modify64), + TEST_CASE(test_bit_atomic_parallel_flip32), + TEST_CASE(test_bit_atomic_parallel_flip64), TEST_CASE(test_bit_relaxed_set), TEST_CASE(test_bit_relaxed_clear), TEST_CASE(test_bit_relaxed_test_set_clear), -- 2.34.1