From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60A3845954; Tue, 10 Sep 2024 11:00:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94EA142D3F; Tue, 10 Sep 2024 10:59:45 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 309634281D for ; Tue, 10 Sep 2024 10:59:44 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48A4qBeY029385 for ; Tue, 10 Sep 2024 01:59:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=1 FTQQVwtuIW2BZYRE/4DZH3X+Hqcltn2TIFKUtKMF14=; b=Y4NWTGekZfeCSPOTY GwllbnQ7E4W8WWIDKkxAITtjN+KrBfGkaIXLr4y5DPUJITUjGpU9W0SMaZZZfDO9 KUtuMorhYKDa3CIvbg0/m407Jp0J14nvO/pek+SQ6uAd3PGIfbcjelJJGela+E9d XQOO/DK3M3nw6bta66YWiyqsfevXInBBX6ATIdjbqmhycdMSXy9CMalNshmetbAW GkjlQf8zUkNVwkwM20cAA3qtJxAdhYPkXGg6SPJhsXQDK/wPFGeEi8cGxn0E/nx5 8jx0dPyrFhgjbCvSpdj6F2VnQCayQDmLqt++D2Ouf9Uv4J5404lD//4/13s9Gnk+ 3JFtg== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 41gygtg1fg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 10 Sep 2024 01:59:43 -0700 (PDT) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 10 Sep 2024 01:59:42 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Tue, 10 Sep 2024 01:59:42 -0700 Received: from hyd1588t430.caveonetworks.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id B57FA3F709E; Tue, 10 Sep 2024 01:59:39 -0700 (PDT) From: Nithin Dabilpuram To: , Nithin Dabilpuram , "Kiran Kumar K" , Sunil Kumar Kori , Satha Rao , Harman Kalra CC: , Rakesh Kudurumalla Subject: [PATCH 05/33] net/cnxk: added telemetry support do dump SA information Date: Tue, 10 Sep 2024 14:28:41 +0530 Message-ID: <20240910085909.1514457-6-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240910085909.1514457-1-ndabilpuram@marvell.com> References: <20240910085909.1514457-1-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: WovT334eSAgdw9Y-3eIKVkHcV3g2qhu_ X-Proofpoint-GUID: WovT334eSAgdw9Y-3eIKVkHcV3g2qhu_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Rakesh Kudurumalla Added new telemetry command to dump SA taking portid and SA index as parameters. Ex: /cnxk/ipsec/sa_info,0,3 dumps inbound and outbound SA information of SA index 3 Signed-off-by: Rakesh Kudurumalla --- drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 145 ++++++++++++++++--- 1 file changed, 128 insertions(+), 17 deletions(-) diff --git a/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c b/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c index 386278cfc9..86c2453c09 100644 --- a/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c +++ b/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c @@ -207,17 +207,121 @@ copy_inb_sa_10k(struct rte_tel_data *d, uint32_t i, void *sa) return 0; } +/* n_vals is the number of params to be parsed. */ +static int +parse_params(const char *params, uint32_t *vals, size_t n_vals) +{ + char dlim[2] = ","; + char *params_args; + size_t count = 0; + char *token; + + if (vals == NULL || params == NULL || strlen(params) == 0) + return -1; + + /* strtok expects char * and param is const char *. Hence on using + * params as "const char *" compiler throws warning. + */ + params_args = strdup(params); + if (params_args == NULL) + return -1; + + token = strtok(params_args, dlim); + while (token && isdigit(*token) && count < n_vals) { + vals[count++] = strtoul(token, NULL, 10); + token = strtok(NULL, dlim); + } + + free(params_args); + + if (count < n_vals) + return -1; + + return 0; +} + +static int +ethdev_sec_tel_handle_sa_info(const char *cmd __rte_unused, const char *params, + struct rte_tel_data *d) +{ + struct cnxk_eth_sec_sess *eth_sec, *tvar; + struct rte_eth_dev *eth_dev; + struct cnxk_eth_dev *dev; + uint32_t port_id, sa_idx; + uint32_t vals[2] = {0}; + uint32_t i; + int ret; + + if (params == NULL || strlen(params) == 0 || !isdigit(*params)) + return -EINVAL; + + if (parse_params(params, vals, RTE_DIM(vals)) < 0) + return -EINVAL; + + port_id = vals[0]; + sa_idx = vals[1]; + + if (!rte_eth_dev_is_valid_port(port_id)) { + plt_err("Invalid port id %u", port_id); + return -EINVAL; + } + + eth_dev = &rte_eth_devices[port_id]; + if (!eth_dev) { + plt_err("Ethdev not available"); + return -EINVAL; + } + dev = cnxk_eth_pmd_priv(eth_dev); + + rte_tel_data_start_dict(d); + + i = 0; + if (dev->tx_offloads & RTE_ETH_TX_OFFLOAD_SECURITY) { + tvar = NULL; + RTE_TAILQ_FOREACH_SAFE(eth_sec, &dev->outb.list, entry, tvar) { + if (eth_sec->sa_idx == sa_idx) { + rte_tel_data_add_dict_int(d, "outb_sa", 1); + if (roc_model_is_cn10k()) + ret = copy_outb_sa_10k(d, i, eth_sec->sa); + else + ret = copy_outb_sa_9k(d, i, eth_sec->sa); + if (ret < 0) + return ret; + break; + } + } + } + + i = 0; + if (dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY) { + tvar = NULL; + RTE_TAILQ_FOREACH_SAFE(eth_sec, &dev->inb.list, entry, tvar) { + if (eth_sec->sa_idx == sa_idx) { + rte_tel_data_add_dict_int(d, "inb_sa", 1); + if (roc_model_is_cn10k()) + ret = copy_inb_sa_10k(d, i, eth_sec->sa); + else + ret = copy_inb_sa_9k(d, i, eth_sec->sa); + if (ret < 0) + return ret; + break; + } + } + } + return 0; +} + static int ethdev_sec_tel_handle_info(const char *cmd __rte_unused, const char *params, struct rte_tel_data *d) { + uint32_t min_outb_sa = UINT32_MAX, max_outb_sa = 0; + uint32_t min_inb_sa = UINT32_MAX, max_inb_sa = 0; struct cnxk_eth_sec_sess *eth_sec, *tvar; struct rte_eth_dev *eth_dev; struct cnxk_eth_dev *dev; uint16_t port_id; char *end_p; - uint32_t i; - int ret; if (params == NULL || strlen(params) == 0 || !isdigit(*params)) return -EINVAL; @@ -246,32 +350,36 @@ ethdev_sec_tel_handle_info(const char *cmd __rte_unused, const char *params, rte_tel_data_add_dict_int(d, "nb_outb_sa", dev->outb.nb_sess); - i = 0; + if (!dev->outb.nb_sess) + min_outb_sa = 0; + if (dev->tx_offloads & RTE_ETH_TX_OFFLOAD_SECURITY) { tvar = NULL; RTE_TAILQ_FOREACH_SAFE(eth_sec, &dev->outb.list, entry, tvar) { - if (roc_model_is_cn10k()) - ret = copy_outb_sa_10k(d, i++, eth_sec->sa); - else - ret = copy_outb_sa_9k(d, i++, eth_sec->sa); - if (ret < 0) - return ret; + if (eth_sec->sa_idx < min_outb_sa) + min_outb_sa = eth_sec->sa_idx; + if (eth_sec->sa_idx > max_outb_sa) + max_outb_sa = eth_sec->sa_idx; } + rte_tel_data_add_dict_int(d, "min_outb_sa", min_outb_sa); + rte_tel_data_add_dict_int(d, "max_outb_sa", max_outb_sa); } rte_tel_data_add_dict_int(d, "nb_inb_sa", dev->inb.nb_sess); - i = 0; + if (!dev->inb.nb_sess) + min_inb_sa = 0; + if (dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY) { tvar = NULL; RTE_TAILQ_FOREACH_SAFE(eth_sec, &dev->inb.list, entry, tvar) { - if (roc_model_is_cn10k()) - ret = copy_inb_sa_10k(d, i++, eth_sec->sa); - else - ret = copy_inb_sa_9k(d, i++, eth_sec->sa); - if (ret < 0) - return ret; + if (eth_sec->sa_idx < min_inb_sa) + min_inb_sa = eth_sec->sa_idx; + if (eth_sec->sa_idx > max_inb_sa) + max_inb_sa = eth_sec->sa_idx; } + rte_tel_data_add_dict_int(d, "min_inb_sa", min_inb_sa); + rte_tel_data_add_dict_int(d, "max_inb_sa", max_inb_sa); } return 0; @@ -281,5 +389,8 @@ RTE_INIT(cnxk_ipsec_init_telemetry) { rte_telemetry_register_cmd("/cnxk/ipsec/info", ethdev_sec_tel_handle_info, - "Returns ipsec info. Parameters: port id"); + "Returns number of SA's and Max and Min SA. Parameters: port id"); + rte_telemetry_register_cmd("/cnxk/ipsec/sa_info", + ethdev_sec_tel_handle_sa_info, + "Returns ipsec info. Parameters: port id & sa_idx"); } -- 2.34.1