DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "WanRenyong" <wanry@yunsilicon.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>
Subject: Re: [PATCH v2 04/19] net/xsc: add xsc device init and uninit
Date: Tue, 10 Sep 2024 20:47:48 -0700	[thread overview]
Message-ID: <20240910204748.1fee9fe1@hermes.local> (raw)
In-Reply-To: <20240911020740.3950704-5-wanry@yunsilicon.com>

On Wed, 11 Sep 2024 10:07:25 +0800
"WanRenyong" <wanry@yunsilicon.com> wrote:

> +
> +	sprintf(path, "%s/device/uevent", dev_path);

better to use snprintf for safety

> +	while (fgets(line, sizeof(line), file) == line) {
> +		size_t len = strlen(line);
> +
> +		/* Truncate long lines. */
> +		if (len == (sizeof(line) - 1)) {
> +			while (line[(len - 1)] != '\n') {
> +				int n = fgetc(file);
> +
> +				if (n == EOF)
> +					goto out;
> +				line[(len - 1)] = n;
> +			}
> +			/* No match for long lines. */
> +			continue;
> +		}

If you have to deal with long lines better to use something
like getline() that handles arbitrary length.

  reply	other threads:[~2024-09-11  3:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11  2:07 WanRenyong
2024-09-11  3:47 ` Stephen Hemminger [this message]
2024-09-12  3:58   ` WanRenyong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240910204748.1fee9fe1@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=thomas@monjalon.net \
    --cc=wanry@yunsilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).