From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19E8345967; Thu, 12 Sep 2024 07:50:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE1044025E; Thu, 12 Sep 2024 07:50:26 +0200 (CEST) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id EE20A40144 for ; Thu, 12 Sep 2024 07:50:24 +0200 (CEST) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7179802b8fcso373671b3a.1 for ; Wed, 11 Sep 2024 22:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726120224; x=1726725024; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jIP8R7GoKfLeW+WrutSDFmW/yQG0iXaWyXMEPKnSlko=; b=ThV+Hn1dFRzOModJej8JGIrWIQh+PD6qQs9FGeTdBMb4g16JTe+cchKWYkM3Gvhdjt MK+B4oZC3nPuhE42guzF/sPPQh/iORmUMcuxdOyBboo0Ae2dALCuvj3WPMvNQYiFYjWh Nr1SWFzlmVxoCBd/eK32/PPXLMP48Vkq6BY31mQ5Z3Jb4XcbyUctSiepXeNx+W7SglLG 5ZXHCqoOQtQ6bdaifpuqStAOiWujRTnubBB2xmSXng3kbp9uyTjxBmQfjBXWJwsR6tuI 8kig15o2kqNDuJbiAY38khAA4OT9n0/2ItHMaVYktsEdmB/AOVY9QQqjOLjyHAhZzFq2 TD+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726120224; x=1726725024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jIP8R7GoKfLeW+WrutSDFmW/yQG0iXaWyXMEPKnSlko=; b=sfPXH9CUBnMmqxkaWD/CUvHi64HhCSqq1/fawZJK2arpEsyD+wybEKoBz0x7zQ6joQ lnrR5Vg7fROks48Itk9PdMgUDFlkiqvrNKCoN27Ea8bu9eKjlv7ayL1bAUTS6bueXBjs i16vb442vAt8jZMvyU1cjFX4+rLQX7gXNXPX80TErVgKAUdVjzug6osj2A6T8tJ9lGXT hkJFEUYAYkt3IJSHHL+yF8J+Y8D6Ck8fvPbNiJ/C8E37Rw3S/xQZWKG/b814xBJFRzCa F3lYps/clveWUdDT1ims+PjFyIYZoRrIkkNM2QY85rnUHCo28Sx0dxRdZGT3J5BMRiQe KYdg== X-Gm-Message-State: AOJu0YwDAaJFBAwmJieCpvZ/mrW7JIeWGAqRhzQ/HPs90ybY6Uk/cpMu BhQIbytcR3YO2v1EiBIqNcGWu6XfxmJrOxscheUL0D1C4to4a0FYvN4Fr7wi8F4= X-Google-Smtp-Source: AGHT+IGzcFOD2EZhVXQ22aCymtoFeiaWnYTRy7vCyhCJ/tND0i9HebFvfubI9k6sxgaB4aT5//IKOQ== X-Received: by 2002:a05:6a00:2789:b0:713:f127:ad5c with SMTP id d2e1a72fcca58-7192622c7a3mr2237103b3a.28.1726120223683; Wed, 11 Sep 2024 22:50:23 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7190909252esm3867710b3a.124.2024.09.11.22.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2024 22:50:23 -0700 (PDT) Date: Wed, 11 Sep 2024 22:50:21 -0700 From: Stephen Hemminger To: "WanRenyong" Cc: , , Subject: Re: [PATCH v2 05/19] net/xsc: add ioctl command interface Message-ID: <20240911225021.16839cb2@hermes.local> In-Reply-To: <8cf9b5e8-cab4-45e6-b959-1d87f8a8ea99@yunsilicon.com> References: <20240911020740.3950704-6-wanry@yunsilicon.com> <20240910205058.25bf5f8c@hermes.local> <8cf9b5e8-cab4-45e6-b959-1d87f8a8ea99@yunsilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 12 Sep 2024 12:14:08 +0800 "WanRenyong" wrote: > > =20 > >> +}; > >> + =20 > > Does this device driver depend on some upstr =20 > Yes, it depends on linux kernel driver of the device. >=20 > Hello, Stephen, >=20 > Thanks for your review,=C2=A0 please see above. What is the driver? I don't see in the current kernel.org tree. My concern is that if the driver is not upstream, it is probably not going to pass the review of kernel developers. This means security and API changes would be required. Ioctl's are considered the worst API to the kernel and unlikely to be accepted.