From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25C5445967; Thu, 12 Sep 2024 07:12:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B79574025E; Thu, 12 Sep 2024 07:12:44 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id D2A0D40144 for ; Thu, 12 Sep 2024 07:12:43 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 1262220B9A9A; Wed, 11 Sep 2024 22:12:43 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1262220B9A9A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1726117963; bh=Xwy5Jew8c9CGPs5rvm1Wpxa0l4Y70JGWd5aH5iw6bew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HuA/7xUG9kJD8A6OtNf2EOZA6nCGcbyeOmYmC1chQhAy4+8Cv2rpiOJ4C7uMhPSyA q1A29OSJVh7XDjdvY1IB9cpDAyzjXOUbPzWFr4mIMVfOBXngrf54PxLXHEIs0SqJb7 r6YKPv1nbdzEo35RIRnVCM6Er5rKu+kAx3sxvXas= Date: Wed, 11 Sep 2024 22:12:43 -0700 From: Tyler Retzlaff To: Stephen Hemminger Cc: dev@dpdk.org, Shai Brandes , Evgeny Schemeilin , Ron Beider , Amit Bernstein , Wajeeh Atrash , Igor Chauskin , Michal Krawczyk , Artur Rojek Subject: Re: [PATCH] net/ena: revert redefining memcpy Message-ID: <20240912051243.GC6879@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <200~bug-1510-3@http.bugs.dpdk.org> <20240812153417.65225-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240812153417.65225-1-stephen@networkplumber.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote: > Redefining memcpy as rte_memcpy has no performance gain on > current compilers, and introduced bugs like this one where > rte_memcpy() will be detected as referencing past the destination. > > Bugzilla ID: 1510 > Fixes: 142778b3702a ("net/ena: switch memcpy to optimized version") > > Signed-off-by: Stephen Hemminger > --- Acked-by: Tyler Retzlaff