From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 91F0245967;
	Thu, 12 Sep 2024 07:56:03 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2C5C84025E;
	Thu, 12 Sep 2024 07:56:03 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 8298540144;
 Thu, 12 Sep 2024 07:56:01 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id AFEB920B9A9A; Wed, 11 Sep 2024 22:56:00 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AFEB920B9A9A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1726120560;
 bh=RQWRbJgRdlA/VIJOhVIt19q/afJ13J+mvicxUmWy4hU=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=My/TPIn0t2LjtPVo/ztG+Nzoj9XIWq37wKan7ymysY4yYCWyDTleXvUkEjw3YOrr7
 VZb6/iWcSnjyHedgF5Eue642XFak231mE9/yzjTlpegkG4jtzalIbt0EkWkB/CFzOJ
 oh0zirRJAoRCgzcXFc83v66Wgi1raNrA7JONIioM=
Date: Wed, 11 Sep 2024 22:56:00 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, radu.nicolau@intel.com, stable@dpdk.org
Subject: Re: [PATCH] eal/x86: fix 32-bit write-combined stores
Message-ID: <20240912055600.GE6879@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20240906132757.457921-1-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240906132757.457921-1-bruce.richardson@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Sep 06, 2024 at 02:27:57PM +0100, Bruce Richardson wrote:
> The "movdiri" instruction is given as a series of bytes in rte_io.h so
> that it works on compilers/assemblers which are unaware of the
> instruction. The REX prefix (0x40) on this instruction is invalid for
> 32-bit code, causing issues. Thankfully, the prefix is unnecessary in
> 64-bit code, since the data size used is 32-bits.
> 
> Fixes: 8a00dfc738fe ("eal: add write combining store")
> Cc: radu.nicolau@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>