From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03F474597F; Fri, 13 Sep 2024 17:25:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A32144060B; Fri, 13 Sep 2024 17:25:23 +0200 (CEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 0B21640295 for ; Fri, 13 Sep 2024 17:25:22 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2057c6c57b5so13752345ad.1 for ; Fri, 13 Sep 2024 08:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726241122; x=1726845922; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=mmZ+13SFuFG8A65FL6aYWxVZGwp4pHv5+Ny/vqRLv5Y=; b=bE0/SGJF5ni1bVGVA/aYzJVJWrNWueu8wJlapSkqOvNmZ6N0dsEEx+WFb4BPsOzMWO RIOxKcgzhybsx7z2Z0nMomu4yDch0Wh/bX8NjAJzNwDtsuYMFIHNFUYPC5+lYuOL+az4 lsn5kx8HdaohmX+iWdZxbMEF18Dhd4EQIqfMWI7cZmnlDCZmMaCHzD/jEy9uFzPFwzAa a0pmt1kwS+IBfHAdacRvE4QGSvWa5TYTveooFp3sZArz1bs0di89nSLse5s9QTpjE0Gl 2izbjdunJu4srLgw/544QDuooUjyBFATMJvHnyMAPVIj+1twrRED5jQ4XcJaCIC8jHNj rudQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726241122; x=1726845922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mmZ+13SFuFG8A65FL6aYWxVZGwp4pHv5+Ny/vqRLv5Y=; b=G9vRJAzRrbd9VG1HTgsBt2zCuPbc2T+Q8PX3CZUTalynbwBAsPTyvCiLTuUtl9gQ+z NB3XyM3GinIRq3XN1zHkQK3qJ95uQjxrkn+zP2NISM48VppzK+dzV4CZK6MW7Cga05rQ 7MslCKTVijdlLToN/aLeP+6u8RWiw3M3BJM4DxFs0XXIiD8r5p/PZ9VfMiVO1VPVh5BM fMG9LsfFVNZjIoKeFbpoce1pG9q/ZsOUPuvgF0ToifRP+ijydDOMlYUWpQz3e/0+305J HG6KCWjeEuOpxYNRHJeak6bQEdL1/2Jwz0gmiz3SkwxnqDFs9ielAq53e4oO6myS8iWO r6DQ== X-Forwarded-Encrypted: i=1; AJvYcCVkAdSYscY/kufEX3Bkxa7nFdxL9O+pfaqO2Ke5BGDAn4C4LX51wu2PKXLo7/jU5LxZWQU=@dpdk.org X-Gm-Message-State: AOJu0YxzONID9/FONJLsF57C2Aoh6s8KBBGaG1MBSMSX2ZB/iU85Kme8 a50lAfLj/viO9CugxnNxcYin2enDrG9iM/Ct7jSZuQk3aCwfKfr/XjGYQ2U2DcE= X-Google-Smtp-Source: AGHT+IHu9pe6qZwDAQFZA9wqiarpH/g2tXS7tW1b7P8qqrfopwC01jUBuGn36xaL/yJgdFM5Sl0OcA== X-Received: by 2002:a17:903:41c9:b0:1fd:6033:f94e with SMTP id d9443c01a7336-2076e61ddabmr120935255ad.27.1726241121937; Fri, 13 Sep 2024 08:25:21 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2076afec599sm29334745ad.235.2024.09.13.08.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2024 08:25:21 -0700 (PDT) Date: Fri, 13 Sep 2024 08:25:20 -0700 From: Stephen Hemminger To: Oleksandr Nahnybida Cc: reshma.pattan@intel.com, dev@dpdk.org Subject: Re: [PATCH 1/2] pcapng: fix handling of chained mbufs Message-ID: <20240913082520.78b32bd8@hermes.local> In-Reply-To: <7yrjcy7sk4nexcqynikybhjvpxlhhmlwvubngwqvib5o752sys@644loude6vbd> References: <7yrjcy7sk4nexcqynikybhjvpxlhhmlwvubngwqvib5o752sys@644loude6vbd> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 13 Sep 2024 15:19:18 +0300 Oleksandr Nahnybida wrote: > The pcapng generates corrupted files when dealing with chained mbufs. > This issue arises because in rte_pcapng_copy the length of the EPB block > is incorrectly calculated using the data_len of the first mbuf instead > of the pkt_len, despite that rte_pcapng_write_packets correctly writing > the mbuf chain to disk. > > This fix ensures that the block length is calculated based on the pkt_len, > aligning it with the actual data written to disk. > > Signed-off-by: Oleksandr Nahnybida Fixes: 8d23ce8f5ee9 ("pcapng: add new library for writing pcapng files") Reviewed-by: Stephen Hemminger