From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62DA74597E; Fri, 13 Sep 2024 18:08:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6D65402B3; Fri, 13 Sep 2024 18:08:32 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 2F03140295 for ; Fri, 13 Sep 2024 18:08:32 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-206e614953aso25669335ad.1 for ; Fri, 13 Sep 2024 09:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726243711; x=1726848511; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=awff7sxDcLop+e3SoilU001kyBagRt0JxxYCAJjyb0E=; b=AEvxRDG6d4D6m9zzX8de2BXDztgys/GwIxC1plhBJh+i/H8wekl+iI8wGM86IFi1/Y XoPkXoWRycrXZkDnIaTPcpQuFlQA3AqGlurW2p3MYp06BRp8/2dJ7CcimftuffQRy7Uh XFQmAUrAvR2E1Ak9rHFufEYL4rIOGg1F0vS82gBDp/Xh0sTJmJ+kqipcY1EEqjrb9B1B UuHnLkWwbK23uG40DlwHXWcdv6sG6jJ9KS8HlkyEyxZ/1/TMXzqtFCSEDoB2BuPZ/rhS CD8hmQhknYTICqlh1DRmN53M5A1FHgoOYtFaDWXvPoBguaCIUWC27eglyV970qZcLlQq 7oxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726243711; x=1726848511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=awff7sxDcLop+e3SoilU001kyBagRt0JxxYCAJjyb0E=; b=RkAeoBp6WPxEr5FCMERdAXabMMFKBC5u3whHoAvfMaoaQsoeBaFtd+16wUXId5g8yS cQVq7GknZckUUXQD592OO7IaalPq+sOa/SE5JD0ePqlIsgHe9iDgkb2heBSUUs94lEfn G6d2PFUO987ZInnt8Xdq8y7OEJzGU7JNpOTKMClYkQi51NMjup99ug/OjTLYHK8PMyh0 raFzuXDv9w2UvJO4dzAlEbOQ8FSnuIoeeHL5crU7JLqXtFETk7XMwv5sU9KRmqTGci/o C8OWShJPBw4a7argd8tkVaRuQVlyvYAGbDGPl2XZxJXEeo6gvx2aBLg7X2bCsvppuwCI qK0w== X-Forwarded-Encrypted: i=1; AJvYcCX4dNbuFI2XzxsgNk4iWJ5h091IqkAnnlLhVEvxHBRC6orb81MTa5Nez/EVpgrfHNxbPRE=@dpdk.org X-Gm-Message-State: AOJu0YxrFA+/8mbVzOx93qkg4ouTbzKDfWzwT3qguMJ9nrM8QUxiAnZK vLXyrtMG6Xdxzem3KCgqQ3veX7qhxdtehKBS1F+aBvtbo/bNDaLR74tlZ0piLE1b0K5o5BAIFuS F X-Google-Smtp-Source: AGHT+IE66VnU1uFIIgJDmMZHO+8HA5Viblgv1I0F9ydAcXdWe/w4Evm3NfdyjMvs1XxYTPATWUQM/A== X-Received: by 2002:a17:903:228f:b0:206:90ac:4412 with SMTP id d9443c01a7336-2076e31edfamr90404285ad.2.1726243710884; Fri, 13 Sep 2024 09:08:30 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2076b01af3fsm29608925ad.301.2024.09.13.09.08.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2024 09:08:30 -0700 (PDT) Date: Fri, 13 Sep 2024 09:08:28 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: WanRenyong , dev@dpdk.org, Nandini Persad , Thomas Monjalon Subject: Re: [PATCH v3] doc: add new driver guidelines Message-ID: <20240913090828.6640b994@hermes.local> In-Reply-To: References: <20240814190901.14912-1-stephen@networkplumber.org> <20240912202734.24440-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 13 Sep 2024 10:07:26 +0100 Ferruh Yigit wrote: > > 4. If a distribution does not include > the dependency, I redistribute > it with the dependency and open source, > > this is somewhat similar to mlnx_ofed, is it publicly or freely? > > > > All looks good from DPDK perspective, although it is preferred that > dependency upstreamed to its upstream distribution. > > Problematic cases are like (not limited to), dependency only delivered > if you purchase the HW, or it is distributed only if you sign some > agreement, or you need to reach out to company and provide some > information to be able to get the SW etc... This policy is based on three principles: 1. DPDK test infrastructure must be able to cover the driver during build and release process. Even if the DPDK CI does not have the hardware, want to make sure that every release and patch still builds and no regression slips in. 2. DPDK developers should be able to make broad changes to the internal API's and be able to validate that all drivers still build. If a driver depended on a non-available library, then it would likely get overlooked and suffer bit rot. 3. DPDK is open source software, we don't want to be seen as being a way to "open source wash" a proprietary internal driver. My other concern is that if Linux kernel drivers are hard. Drivers that have not been reviewed and merged into kernel.org are likely to have bugs. For example, both KNI and igb_uio have serious issues that could be exploited for security exploits. And if a non-upstream driver uses some unsupported API it is going to be stuck running on some old unstable kernel version. If DPDK depends on such an unstable driver, when the next security disaster happens (like Crowdstrike), DPDK might get blamed but the real culprit would be the proprietary kernel driver. Since DPDK is LF project, that might also get involved. This is not an absolute rule, and probably other Technical Board members have different opinions.