From: Stephen Hemminger <stephen@networkplumber.org>
To: "Brandes, Shai" <shaibran@amazon.com>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Beider, Ron" <rbeider@amazon.com>,
"Bernstein, Amit" <amitbern@amazon.com>,
"Atrash, Wajeeh" <atrwajee@amazon.com>
Subject: Re: [PATCH] net/ena: revert redefining memcpy
Date: Mon, 16 Sep 2024 08:11:40 -0700 [thread overview]
Message-ID: <20240916081140.58c052ab@hermes.local> (raw)
In-Reply-To: <7f545f9575b444e5b31be18f033a940e@amazon.com>
On Mon, 16 Sep 2024 06:33:26 +0000
"Brandes, Shai" <shaibran@amazon.com> wrote:
> > Did you have any chance to check/test this patch?
> [Brandes, Shai] We are currently conducting tests and will provide an update shortly. In the meantime, could you advise whether it is recommended to entirely avoid using rte_memcpy in our driver, considering we have direct calls to it?
There is a long term goal to remove rte_memcpy(). It exists only as workaround for
cases where older compilers do not produce optimium code.
When rte_memcpy() is used the checks done by fortify, gcc, coverity etc are
less and there is higher probability of bugs going undetected.
My current recommendation is to only use rte_memcpy() in the data path and for
variable size data items.
next prev parent reply other threads:[~2024-09-16 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200~bug-1510-3@http.bugs.dpdk.org>
2024-08-12 15:34 ` Stephen Hemminger
2024-08-12 20:53 ` Wathsala Wathawana Vithanage
2024-08-13 8:57 ` Morten Brørup
2024-09-12 5:12 ` Tyler Retzlaff
2024-09-12 8:19 ` Ferruh Yigit
2024-09-12 14:53 ` Brandes, Shai
2024-09-16 6:33 ` Brandes, Shai
2024-09-16 15:11 ` Stephen Hemminger [this message]
2024-09-16 16:06 ` Brandes, Shai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916081140.58c052ab@hermes.local \
--to=stephen@networkplumber.org \
--cc=amitbern@amazon.com \
--cc=atrwajee@amazon.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=ferruh.yigit@amd.com \
--cc=rbeider@amazon.com \
--cc=roretzla@linux.microsoft.com \
--cc=shaibran@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).