From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BE8C459BC; Tue, 17 Sep 2024 11:46:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E7C74025F; Tue, 17 Sep 2024 11:46:15 +0200 (CEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2053.outbound.protection.outlook.com [40.107.105.53]) by mails.dpdk.org (Postfix) with ESMTP id B259840663 for ; Tue, 17 Sep 2024 11:46:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=haOqw4w0zA9lBhw1N66jWCPiOe5odtNMKUY/EspmaTMtxvcSDX0z6bjqNLZNWB41Iyh/71Y5KT80NBquQlzBLO2MP7eP71LkWWJG4CV83sB0KsYweItoMW0y4bHi0ULqmHw97/IY4AhGefTGNwBKcJj3TCNtwK0838pFPt/DuTWollwLDR36mCLBH+nO2kYP6YiRWyVoNZtIQv6c0so2Dn/zOsF2G7v/eTI0Wbeqa+kTbOc7kVidHakjIKBiCYJthcMeZmF2Rue6mXyArF2XVMoh0bWb0dgp8WeDSD059m+aYyvY6fE/o7vLLaXeHfRg06WYgcM/VrqXfG5qRldkrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FORcAcTImC3VO+jULR5YD9MPGU81/5BIeguEUjIfy6I=; b=CKipr6eGo6W/mXfQxQjDYandVsfWK1CC2YRTp2qzSUS9XijBrchyotkpyYpc0cFbGomsj95epa2gUsoj9kmNv5uLOwrMG1nuuP1P2P1YjdaZj61UruVZ2M1N40tfShZbz9+IP/km0khNdOdlLTyIgVjMEiaBAMH3kfmGiKbGBInnwIDtOBHgqsNBijujfaoj2tq/5XfN7Eopdd4qUrp1Akqnfi5UbX9AMczw0IHfVHInYfPxZ9DKkWwnUnBPDhdN5IkOraDMH7maIO0A1s7waexU1orprc4Ywzu+CHmd6wyEP7YYdTOJEXxYWUOh6UMYrj4CIRRGmd1IfS8ZbVa2ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FORcAcTImC3VO+jULR5YD9MPGU81/5BIeguEUjIfy6I=; b=gmJseoDnfAJTFH94dw7eZUP/E3sx8xvDu+ohZZJuFYYnaInyKJVObAIc0YvcL7nR0m8dh5wKeIRxQh1PN8NkMjgAEQ9nINIXIa9YcLSYK2Pv1KUTwJQXr7erw9KO+8WpjQT4INA7hexRdqyuLld7e05IejoztN5xALoUxh5kwfEKYyWgGkJOvfEMMU04W/YOJm2HcVdJ8ccXHVm2n1cQiLF0SxAWMlV2DhxLey0KK1V4fV0TqxKPYxUtULpmBaAKgXOp74PvG4GAqz8/1e6DXanseG5+GZfnPnEQScnWRWmmjAvExA5uqP3F07IJt1D/YnrH4RJAHqwpPYPeswFacQ== Received: from DUZPR01CA0298.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::15) by AM9PR07MB8018.eurprd07.prod.outlook.com (2603:10a6:20b:2fd::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.24; Tue, 17 Sep 2024 09:46:08 +0000 Received: from DB1PEPF000509F1.eurprd03.prod.outlook.com (2603:10a6:10:4b7:cafe::af) by DUZPR01CA0298.outlook.office365.com (2603:10a6:10:4b7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.30 via Frontend Transport; Tue, 17 Sep 2024 09:46:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DB1PEPF000509F1.mail.protection.outlook.com (10.167.242.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Tue, 17 Sep 2024 09:46:06 +0000 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.60) with Microsoft SMTP Server id 15.2.1544.11; Tue, 17 Sep 2024 11:46:04 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id A036C1C0070; Tue, 17 Sep 2024 11:46:04 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Jack Bond-Preston , David Marchand , Chengwen Feng , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [PATCH v7 5/6] eal: add unit tests for atomic bit access functions Date: Tue, 17 Sep 2024 11:36:45 +0200 Message-ID: <20240917093646.723777-6-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240917093646.723777-1-mattias.ronnblom@ericsson.com> References: <20240809201440.590464-1-mattias.ronnblom@ericsson.com> <20240917093646.723777-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509F1:EE_|AM9PR07MB8018:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e4cb68d-b966-4f9a-c5d6-08dcd6fd8d84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VzRVbmFMaUFWYjI4bmNRdHRwdGR5YnJpb2k3WDVOTW52YnY1ekxrenQ3aW5W?= =?utf-8?B?azdwWVRpenpZSWkyWWYrejJQMDBZdjY0QjRWTHFuVE13Z3FzWklFOHNva1pj?= =?utf-8?B?TlpueHBEWXJwYkVoMWxTN1Y4dFRSU05pZEhoM2VXTVFHWGxNTndKenQ0SzU2?= =?utf-8?B?VXhiQXFYT0VLUGlxY2thRG45cUVZZERIRWNabHR4UElSKzJDeUpVUE02alJz?= =?utf-8?B?dHE1T2xDaDJOQlFzWldaV3ExT2pBTTZ5eUQ2ajNrUkJOdUprV01kQmduVjVn?= =?utf-8?B?SlBudGllQzlJZXp1RDF1U09MTzMxK3BjMTQzMDlxcllIUHlxdGlhdXpFa3Bh?= =?utf-8?B?ZzEwaWdtdjV1a3VkREF4Ujg1TXJ0VGVLWG5oaUV3WHNic2h0d3VOc2xBWFl2?= =?utf-8?B?SkNSM3RRTEtRK0ZKYXRuYWhBL0JnMElVYWN6eDU5QktwTExkMEhTd3ArbWRt?= =?utf-8?B?U3lpK3dCS3RscVRhb1JiQkhKNHFoQnE1cnV3RVBxRUdnU2lDS3NqNjBPcDlp?= =?utf-8?B?TzB5T1dYVitXbm9UL2Roa3RyWDFLcEdlNDAxMGp2b0wwai9TVXNRdm8xU3dk?= =?utf-8?B?ZU1VVW1RSDgvMWI0NlNZb0RwcU9wTy9YeStWQ2Q3dmRpaEVidDFYeU1mTG5o?= =?utf-8?B?S1dVZ1pKRkRPeEpwMTdOUHlMYVVBd25rNEhSNGJ6aGJNR3U3SDQ5RERSSldt?= =?utf-8?B?Qkw0OFJlMml2Um9wbGg3Rk1ONVdha3E2allWdHYxUWpvVmtJaEFBR01WVzV0?= =?utf-8?B?Smh6dE12YWNuYTJXa0x3R2JZbHAwTjJkTVQ3R0dqdXZoTENsWkx2WkQ2dnlH?= =?utf-8?B?T3F4L0ZCWmczc0NBcnRUY2I4WkZrZWdDSGYzUk9HVmtuOVJDUzk5SXVwY1ZF?= =?utf-8?B?M3VMWk5LUW9JVmxGSktGWFpKb3Zwdk5XUVRxaVVZaW1qOHJuZXVMRDIvTHZk?= =?utf-8?B?YkVOVHlOWXFaMW0yVjkyUHhMZmJCZGcxWm5tZVphalRXSjdjSy9RUVE3ak1V?= =?utf-8?B?RXh3OUlyNGZlRUlreGNta3p1d2I2SFQ0ZDk3NWg2SThMbVd4amVGbnQ4eUdM?= =?utf-8?B?SWpHQUdyNGpXUUIvS1ltZEY0Z21IWE5sblFwdm5uUDRpaUtjN3dxRFpZWEtY?= =?utf-8?B?cEdpdGZ6K3JRS05hZUt6b00wS1ZHQUJOL05xbkh3c3hKdi9XczJVMlRLZ2Ev?= =?utf-8?B?SUJFbnJQSlRuRy9UV1NaTDQzUTNOcFBHVitjWkc2YkNveHdjV3ZnVkx5enFN?= =?utf-8?B?dllLMVliOHVCczBnWFhyMjVCK0dZc00xclJHbE1paGk0YW93UjhjOEQzTmNU?= =?utf-8?B?dEdZR1haanQvRGxyVjB1VERXeGlzMzdpZWFQWW5UaWNUNkVaMnhYS3hGOWZY?= =?utf-8?B?eVVsNGZZWGY3QWZtU1dRb2tDY2tXTlBTTS9PaDRlWitPMmIva0QrOGdidlVM?= =?utf-8?B?Q2g5bExtemxBUmh1dWVkK08rYTZPVG9KZVc5SVlBNnpPQmtFRzhDcjRNYUVz?= =?utf-8?B?bzlYTVd1ajY2U2J0a1lvT0JST1ZabFNVV1l2NDVDMk1qUC9BNmQ3dVFXeEVB?= =?utf-8?B?d1h1dlp0NVVPYVFwaTVJY2pQNFFRaC8wRFY4UGZLbjd2Q0IwN2orbjlDdWpN?= =?utf-8?B?RzZnYWVsMEpOR2JkWnV0alYzd0JvcmhhSFdHOXJRRDFvQ1NzSGVTV3dQc096?= =?utf-8?B?aHhmR3h2UXRDeXVuUUVjYzBDdUVDSVh6YUNTWTdvY0xiM3ZVNUNLTGVoMVB2?= =?utf-8?B?bUxjRlFBajc4d1FnYnFFcXNHdjBRdFRWSGRyc0t0K1R5bDZsQlI3QSt3V1ZD?= =?utf-8?B?Z2FYVzR3c1o2c2g4L1BjZnpHY0txOUJUcE1ISCtZcEJZQllFVTltMzFJZnUy?= =?utf-8?Q?meu08mvC7WI58?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2024 09:46:06.8189 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e4cb68d-b966-4f9a-c5d6-08dcd6fd8d84 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509F1.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR07MB8018 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --- app/test/test_bitops.c | 313 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 312 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index 322f58c066..b80216a0a1 100644 --- a/app/test/test_bitops.c +++ b/app/test/test_bitops.c @@ -3,10 +3,13 @@ * Copyright(c) 2024 Ericsson AB */ +#include #include -#include #include +#include +#include +#include #include #include "test.h" @@ -61,6 +64,304 @@ GEN_TEST_BIT_ACCESS(test_bit_access32, rte_bit_set, rte_bit_clear, GEN_TEST_BIT_ACCESS(test_bit_access64, rte_bit_set, rte_bit_clear, rte_bit_assign, rte_bit_flip, rte_bit_test, 64) +#define bit_atomic_set(addr, nr) \ + rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_clear(addr, nr) \ + rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_assign(addr, nr, value) \ + rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed) + +#define bit_atomic_flip(addr, nr) \ + rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_test(addr, nr) \ + rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 32) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 64) + +#define PARALLEL_TEST_RUNTIME 0.25 + +#define GEN_TEST_BIT_PARALLEL_ASSIGN(size) \ + \ + struct parallel_access_lcore ## size \ + { \ + unsigned int bit; \ + uint ## size ##_t *word; \ + bool failed; \ + }; \ + \ + static int \ + run_parallel_assign ## size(void *arg) \ + { \ + struct parallel_access_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + bool value = false; \ + \ + do { \ + bool new_value = rte_rand() & 1; \ + bool use_test_and_modify = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (rte_bit_atomic_test(lcore->word, lcore->bit, \ + rte_memory_order_relaxed) != value) { \ + lcore->failed = true; \ + break; \ + } \ + \ + if (use_test_and_modify) { \ + bool old_value; \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else { \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + if (old_value != value) { \ + lcore->failed = true; \ + break; \ + } \ + } else { \ + if (use_assign) \ + rte_bit_atomic_assign(lcore->word, lcore->bit, \ + new_value, \ + rte_memory_order_relaxed); \ + else { \ + if (new_value) \ + rte_bit_atomic_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + else \ + rte_bit_atomic_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + } \ + \ + value = new_value; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_assign ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + struct parallel_access_lcore ## size lmain = { \ + .word = &word \ + }; \ + struct parallel_access_lcore ## size lworker = { \ + .word = &word \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + lmain.bit = rte_rand_max(size); \ + do { \ + lworker.bit = rte_rand_max(size); \ + } while (lworker.bit == lmain.bit); \ + \ + int rc = rte_eal_remote_launch(run_parallel_assign ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_assign ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \ + TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \ + "failed"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_ASSIGN(32) +GEN_TEST_BIT_PARALLEL_ASSIGN(64) + +#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size) \ + \ + struct parallel_test_and_set_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_test_and_modify ## size(void *arg) \ + { \ + struct parallel_test_and_set_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + bool old_value; \ + bool new_value = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + if (old_value != new_value) \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_test_and_modify ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_test_and_set_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_test_and_set_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_test_and_modify ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32) +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64) + +#define GEN_TEST_BIT_PARALLEL_FLIP(size) \ + \ + struct parallel_flip_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_flip ## size(void *arg) \ + { \ + struct parallel_flip_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + rte_bit_atomic_flip(lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_flip ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_flip_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_flip_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_flip ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_flip ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_FLIP(32) +GEN_TEST_BIT_PARALLEL_FLIP(64) + static uint32_t val32; static uint64_t val64; @@ -177,6 +478,16 @@ static struct unit_test_suite test_suite = { .unit_test_cases = { TEST_CASE(test_bit_access32), TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_access32), + TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_atomic_access32), + TEST_CASE(test_bit_atomic_access64), + TEST_CASE(test_bit_atomic_parallel_assign32), + TEST_CASE(test_bit_atomic_parallel_assign64), + TEST_CASE(test_bit_atomic_parallel_test_and_modify32), + TEST_CASE(test_bit_atomic_parallel_test_and_modify64), + TEST_CASE(test_bit_atomic_parallel_flip32), + TEST_CASE(test_bit_atomic_parallel_flip64), TEST_CASE(test_bit_relaxed_set), TEST_CASE(test_bit_relaxed_clear), TEST_CASE(test_bit_relaxed_test_set_clear), -- 2.34.1