From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39105459BD; Tue, 17 Sep 2024 12:58:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BAAA40BA2; Tue, 17 Sep 2024 12:57:40 +0200 (CEST) Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2080.outbound.protection.outlook.com [40.107.103.80]) by mails.dpdk.org (Postfix) with ESMTP id 9360340A4B for ; Tue, 17 Sep 2024 12:57:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VSEeE+ZCvhLTXMyThUItFwKhS3A4yqM27g2W6uO+M/CIegedU403TzfIRVcm/D3lcrLpvWd0LJWVqSSKcpVJ2KCUDl/5BEgx/I6eYjZyFpJ90+Uf2/1lEUewWCd0Q5SjHOY+bCqAUi1kcJPSPIw6c5wDbA75JNyMWSph1PVgutsjchZlGMSW1UDJ/r7eo1kaos6oOxbC1aLHgq35XzhLatzI8jacY2fYoF0aKSDK7S2cTfI1wJNGVc/HNfoEuXjsHE/grLr4I/czgP49IyY6ZKDEQ9ekU/EzvSGym9ApqFDGg6ueXkvnXlmn9YPqbYd0AEeNCFga4hd1gPaXGbu7iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FORcAcTImC3VO+jULR5YD9MPGU81/5BIeguEUjIfy6I=; b=xeHmxdjYnlGcAar0W6hdPgvIVKTRdWY81sKxJNeJBf+0B/ielx8QpIF/kVb1TLquOGEl2tk5mmdc7Vg+b7jCT8IZq5bFNHB6z6cOHG9HuO5BNe2BbMM/5tdgGw42yBau3yaPZTwRrjuzuza9TkFcjVKwo3I0MkArxMFq5fPyH/tYPMirVH3M3U3990UcteaQujOBw10FLfYR/i4vcfx9ILmdZgVYq3wQe57UfCFL2kOMfTqzbBgun8OLysU5vyAJzs7VU6Huqj5WPVDFBtSjDseQudNoV7buEGWxzCHOafH+suKJWCPeGjjUqfESJY6KtoBYAh1gzR23U6GmFM2Q8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FORcAcTImC3VO+jULR5YD9MPGU81/5BIeguEUjIfy6I=; b=ULCwsGqMpJ2qhhH7Ckw6XExOmq3mLGxdCXLYNEvF5wC7X1WyubHg7f7CEDw5YvU6ZeFe2v2gMf6eDcjUpqGxr0albmpzrs1OitTkvzeV1xFg71MWXMQ+ZSWUGt86agI+tbq4TtpkNu+aGeURZT/PPTbBspGN4gwBDueAMTnYrJxPcVjyizZeVi1eDVkQflBk7MkMXQ8W43ZqIKDEOXehhq4eFO5uWweaEkr6MHgA2ZL8PBcSQ3nIriIz259CLYF/CsMVElQzowcH2DWNCBMpKDJSm/rs4/AHUuhKGSZx/wVGFnY5f2U5CsHCOeW5Wtr1uu8rdZJAbpU90PqiN/lgwg== Received: from AS4P191CA0029.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d9::12) by VI1PR0701MB6781.eurprd07.prod.outlook.com (2603:10a6:800:193::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.24; Tue, 17 Sep 2024 10:57:31 +0000 Received: from AM3PEPF00009B9D.eurprd04.prod.outlook.com (2603:10a6:20b:5d9:cafe::fd) by AS4P191CA0029.outlook.office365.com (2603:10a6:20b:5d9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.30 via Frontend Transport; Tue, 17 Sep 2024 10:57:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AM3PEPF00009B9D.mail.protection.outlook.com (10.167.16.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Tue, 17 Sep 2024 10:57:31 +0000 Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.62) with Microsoft SMTP Server id 15.2.1544.11; Tue, 17 Sep 2024 12:57:29 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id 22D9D380061; Tue, 17 Sep 2024 12:57:29 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Jack Bond-Preston , David Marchand , Chengwen Feng , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [PATCH v8 5/6] eal: add unit tests for atomic bit access functions Date: Tue, 17 Sep 2024 12:48:10 +0200 Message-ID: <20240917104811.723863-6-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240917104811.723863-1-mattias.ronnblom@ericsson.com> References: <20240917093646.723777-2-mattias.ronnblom@ericsson.com> <20240917104811.723863-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF00009B9D:EE_|VI1PR0701MB6781:EE_ X-MS-Office365-Filtering-Correlation-Id: 3571ad30-d72c-4f71-c63a-08dcd7078723 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WW1obDFnZHlCT01lZHU5VFMzei93cE8vaklWQ1ZubHlaWng5MGNKS1k5WTJa?= =?utf-8?B?Y0hHWjVBaWNveXBua1h3clQrOGlNcUUxS1pLdEY4dVdnL1Q5cjlmaWhGaG5S?= =?utf-8?B?alhsWU5qMlk1cUpQMzVoTzlRYTJYWk11QnErbGtpazlVbkE3TVlSdkxXNUF1?= =?utf-8?B?SjN0VEJ5MGJKZGtsK25JVGtYRXh1Y3YvSTE2QlBha2xJd3JjYVFnV3JjNGhk?= =?utf-8?B?WXo1Q21USHJPdm1LMFBSU3NWWVBRblpldXlXc0M4VzB6ZXphei8vcFlaaU9G?= =?utf-8?B?a2tEdml2bWFjZmljWjR5Mm5lQnlacjlqUldGWHNyUXJxWVF2WE9aWkE1bnpX?= =?utf-8?B?RUNoeUo1dFFnVGhEVlZ4VEphZFNqYnkzcXhzK3NZblFPbWdob1YrdTZkc1Jn?= =?utf-8?B?UStVSDFiSENTVksxaVBjczlORlcvMFIyWHJwb0tyTUZ4YXNEb2ZkVDBXTDNI?= =?utf-8?B?TDBPaERweVBaU1RuN25xREF2Uk41QzNqVHVQWXpXZHJIeXJYRk1hRmVEREZv?= =?utf-8?B?R1RBWXB6cExoN0tQcXpZYVZaWUwwS2pVS3JQRTh2VEJFTWVhQTNudXJEYzRT?= =?utf-8?B?RWRDcmFES1VLK1hYY2x2bVFCTTlxZENiRjFtQ1JFdUY3aVVxdmgyVUpkdzZq?= =?utf-8?B?MzY5SUswdXRaeWwwTTNvTVprNUpjcWNQMkJRSnhqT0NtSXR2K1gwUUtUWUdK?= =?utf-8?B?aTE0RzNoeHNpZ0Z2dk10L05Bd1BmTHRGaEV0cVoyYXNjK0Y1OFNrWlo1Y1Q2?= =?utf-8?B?K01aTUxEc3dRUzRUOUtUa3hndWFJeng2NHBUNXhPQktETGxiK204WWpiWFVE?= =?utf-8?B?UTYzSjN1cWlPdmFWQlBxRVBPSTFnbCtWV2pwUHowWUlXd2U0VGhEZjdOYnhU?= =?utf-8?B?ZjArYXF1SVk4MTlNWER0MGxMb1JtNnhYNnlTTDJyMzdHTUh1aThxblZka3h1?= =?utf-8?B?VXNBa0U0Zml6NG9qbm9Xbi84NE1TM01lR21hcDNJS3lPVEJ2NEp2VE9JQjNL?= =?utf-8?B?VzZvM2VYbXlLNnhVU1ZudURrblpOMVBuM2pTRnZ4N0FDL2NoTTdqR0UwS2sr?= =?utf-8?B?aFpHblZaQW9VWDl4YlArR2E2SkluakZtZ1R5M0xFcXZ2STNoYzRxcW9tbE9L?= =?utf-8?B?TzFwWWpxODZrbXNneVgxVGR1bHZsbitoYmdSTHl5MXdCV0RVNnYyaFd2TENK?= =?utf-8?B?bHlvb2REY3FZL0hOZEdBaFZJOXBQOGFlbEVEakl3NXNJblZaaUg0b0xXdEhB?= =?utf-8?B?RldYM01DUjcvaUxrWmxpNjhGYWNJbU1QN0ZnUUJkeFlhbE9XL1lwenEyeVh4?= =?utf-8?B?dVlBbld0NG1jMGdmd0FEQUMxK3pURWEraEFCSDZzYzlKUXhuZks5WUNGaCsy?= =?utf-8?B?V0JLUE1KTG1lNklNY3NqWmx0dkg2QlhqWitUc3BBV1JIL2xTcGRLaHFjaUpC?= =?utf-8?B?NjlwckxBVlZBTUZUNVh3SUQvRzRTVnNSNS9FZ0RQZElUZTk3ajJxK1YxWS9J?= =?utf-8?B?TGxMVDFmUkYwcW5UOUduY1VVSFZMeWNMNmVheHdjbmI2N2FsTFJNUHZHTGhu?= =?utf-8?B?RDhweDF4Y3MyenNPaFB1U05hbGdSU3NBSjRsS0NCVDFobklCOFk1Tm5YTTNh?= =?utf-8?B?WjRHcWxNSkhNS1FFc2JIM0g5SUNTQTY0UUlsejFJRE0xVHZyVk44M2dNWEMw?= =?utf-8?B?SnhZclFpaFUyK1FvK3N6RStZcURMc1kzYzBaWmgxU29jb1NvZzEwQkhkd044?= =?utf-8?B?WVB5eUZvUzR4WlhGTGFLWURCMWJPQS84T2I5ODNOZ1Bpbk1nWW51RG5zWEtu?= =?utf-8?B?Vm1ZM1VRN2VtcjFqMDB1dUtpZXRFbGpZTDc1MGtYWUtheXFOaE4vbjlOUldC?= =?utf-8?Q?jue3QhKcNcqL/?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2024 10:57:31.1310 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3571ad30-d72c-4f71-c63a-08dcd7078723 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF00009B9D.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB6781 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --- app/test/test_bitops.c | 313 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 312 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index 322f58c066..b80216a0a1 100644 --- a/app/test/test_bitops.c +++ b/app/test/test_bitops.c @@ -3,10 +3,13 @@ * Copyright(c) 2024 Ericsson AB */ +#include #include -#include #include +#include +#include +#include #include #include "test.h" @@ -61,6 +64,304 @@ GEN_TEST_BIT_ACCESS(test_bit_access32, rte_bit_set, rte_bit_clear, GEN_TEST_BIT_ACCESS(test_bit_access64, rte_bit_set, rte_bit_clear, rte_bit_assign, rte_bit_flip, rte_bit_test, 64) +#define bit_atomic_set(addr, nr) \ + rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_clear(addr, nr) \ + rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_assign(addr, nr, value) \ + rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed) + +#define bit_atomic_flip(addr, nr) \ + rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_test(addr, nr) \ + rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 32) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 64) + +#define PARALLEL_TEST_RUNTIME 0.25 + +#define GEN_TEST_BIT_PARALLEL_ASSIGN(size) \ + \ + struct parallel_access_lcore ## size \ + { \ + unsigned int bit; \ + uint ## size ##_t *word; \ + bool failed; \ + }; \ + \ + static int \ + run_parallel_assign ## size(void *arg) \ + { \ + struct parallel_access_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + bool value = false; \ + \ + do { \ + bool new_value = rte_rand() & 1; \ + bool use_test_and_modify = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (rte_bit_atomic_test(lcore->word, lcore->bit, \ + rte_memory_order_relaxed) != value) { \ + lcore->failed = true; \ + break; \ + } \ + \ + if (use_test_and_modify) { \ + bool old_value; \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else { \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + if (old_value != value) { \ + lcore->failed = true; \ + break; \ + } \ + } else { \ + if (use_assign) \ + rte_bit_atomic_assign(lcore->word, lcore->bit, \ + new_value, \ + rte_memory_order_relaxed); \ + else { \ + if (new_value) \ + rte_bit_atomic_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + else \ + rte_bit_atomic_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + } \ + \ + value = new_value; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_assign ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + struct parallel_access_lcore ## size lmain = { \ + .word = &word \ + }; \ + struct parallel_access_lcore ## size lworker = { \ + .word = &word \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + lmain.bit = rte_rand_max(size); \ + do { \ + lworker.bit = rte_rand_max(size); \ + } while (lworker.bit == lmain.bit); \ + \ + int rc = rte_eal_remote_launch(run_parallel_assign ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_assign ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \ + TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \ + "failed"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_ASSIGN(32) +GEN_TEST_BIT_PARALLEL_ASSIGN(64) + +#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size) \ + \ + struct parallel_test_and_set_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_test_and_modify ## size(void *arg) \ + { \ + struct parallel_test_and_set_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + bool old_value; \ + bool new_value = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + if (old_value != new_value) \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_test_and_modify ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_test_and_set_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_test_and_set_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_test_and_modify ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32) +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64) + +#define GEN_TEST_BIT_PARALLEL_FLIP(size) \ + \ + struct parallel_flip_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_flip ## size(void *arg) \ + { \ + struct parallel_flip_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + rte_bit_atomic_flip(lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_flip ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_flip_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_flip_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_flip ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_flip ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_FLIP(32) +GEN_TEST_BIT_PARALLEL_FLIP(64) + static uint32_t val32; static uint64_t val64; @@ -177,6 +478,16 @@ static struct unit_test_suite test_suite = { .unit_test_cases = { TEST_CASE(test_bit_access32), TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_access32), + TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_atomic_access32), + TEST_CASE(test_bit_atomic_access64), + TEST_CASE(test_bit_atomic_parallel_assign32), + TEST_CASE(test_bit_atomic_parallel_assign64), + TEST_CASE(test_bit_atomic_parallel_test_and_modify32), + TEST_CASE(test_bit_atomic_parallel_test_and_modify64), + TEST_CASE(test_bit_atomic_parallel_flip32), + TEST_CASE(test_bit_atomic_parallel_flip64), TEST_CASE(test_bit_relaxed_set), TEST_CASE(test_bit_relaxed_clear), TEST_CASE(test_bit_relaxed_test_set_clear), -- 2.34.1