From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: <dev@dpdk.org>
Subject: [RFC 1/4] ethdev: rework config restore
Date: Wed, 18 Sep 2024 11:21:58 +0200 [thread overview]
Message-ID: <20240918092201.33772-2-dsosnowski@nvidia.com> (raw)
In-Reply-To: <20240918092201.33772-1-dsosnowski@nvidia.com>
Extract promiscuous and all multicast configuration restore
to separate functions.
This change will allow easier integration of disabling
these procedures for supporting PMDs in follow up commits.
Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
---
lib/ethdev/rte_ethdev.c | 34 +++++++++++++++++++++++++++++-----
1 file changed, 29 insertions(+), 5 deletions(-)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index f1c658f49e..362a1883f0 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -1648,14 +1648,10 @@ eth_dev_mac_restore(struct rte_eth_dev *dev,
}
static int
-eth_dev_config_restore(struct rte_eth_dev *dev,
- struct rte_eth_dev_info *dev_info, uint16_t port_id)
+eth_dev_promiscuous_restore(struct rte_eth_dev *dev, uint16_t port_id)
{
int ret;
- if (!(*dev_info->dev_flags & RTE_ETH_DEV_NOLIVE_MAC_ADDR))
- eth_dev_mac_restore(dev, dev_info);
-
/* replay promiscuous configuration */
/*
* use callbacks directly since we don't need port_id check and
@@ -1683,6 +1679,14 @@ eth_dev_config_restore(struct rte_eth_dev *dev,
}
}
+ return 0;
+}
+
+static int
+eth_dev_allmulticast_restore(struct rte_eth_dev *dev, uint16_t port_id)
+{
+ int ret;
+
/* replay all multicast configuration */
/*
* use callbacks directly since we don't need port_id check and
@@ -1713,6 +1717,26 @@ eth_dev_config_restore(struct rte_eth_dev *dev,
return 0;
}
+static int
+eth_dev_config_restore(struct rte_eth_dev *dev,
+ struct rte_eth_dev_info *dev_info, uint16_t port_id)
+{
+ int ret;
+
+ if (!(*dev_info->dev_flags & RTE_ETH_DEV_NOLIVE_MAC_ADDR))
+ eth_dev_mac_restore(dev, dev_info);
+
+ ret = eth_dev_promiscuous_restore(dev, port_id);
+ if (ret != 0)
+ return ret;
+
+ ret = eth_dev_allmulticast_restore(dev, port_id);
+ if (ret != 0)
+ return ret;
+
+ return 0;
+}
+
int
rte_eth_dev_start(uint16_t port_id)
{
--
2.39.5
next prev parent reply other threads:[~2024-09-18 9:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 9:21 [RFC 0/4] " Dariusz Sosnowski
2024-09-18 9:21 ` Dariusz Sosnowski [this message]
2024-09-18 9:21 ` [RFC 2/4] ethdev: omit promiscuous config restore if not required Dariusz Sosnowski
2024-09-18 9:22 ` [RFC 3/4] ethdev: omit all multicast " Dariusz Sosnowski
2024-09-18 9:22 ` [RFC 4/4] ethdev: omit MAC address " Dariusz Sosnowski
2024-09-29 23:31 ` [RFC 0/4] ethdev: rework config restore Ferruh Yigit
2024-10-04 19:13 ` Dariusz Sosnowski
2024-10-07 9:27 ` Konstantin Ananyev
2024-10-07 22:56 ` Ferruh Yigit
2024-10-08 17:21 ` Konstantin Ananyev
2024-10-09 1:07 ` Ferruh Yigit
2024-10-09 10:54 ` Konstantin Ananyev
2024-10-09 16:18 ` Dariusz Sosnowski
2024-10-09 23:16 ` Ferruh Yigit
2024-10-10 12:08 ` Dariusz Sosnowski
2024-10-10 12:51 ` Ferruh Yigit
2024-10-10 16:23 ` Dariusz Sosnowski
2024-10-10 17:08 ` Ferruh Yigit
2024-10-10 22:58 ` Konstantin Ananyev
2024-10-11 0:02 ` Ferruh Yigit
2024-10-11 8:23 ` Dariusz Sosnowski
2024-10-11 8:29 ` Konstantin Ananyev
2024-10-11 9:37 ` Dariusz Sosnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918092201.33772-2-dsosnowski@nvidia.com \
--to=dsosnowski@nvidia.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).